From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C1E0810A7 for ; Wed, 7 Jun 2017 19:20:46 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jun 2017 10:20:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,311,1493708400"; d="scan'208";a="271400133" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by fmsmga004.fm.intel.com with ESMTP; 07 Jun 2017 10:20:44 -0700 To: Gowrishankar Cc: dev@dpdk.org References: <1494502172-16950-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com> <1494503486-20876-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com> From: Ferruh Yigit Message-ID: <4ca53d20-a36a-f769-fefe-1619bd1a36af@intel.com> Date: Wed, 7 Jun 2017 18:20:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1494503486-20876-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] kni: add new mbuf in alloc_q only based on its empty slots X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2017 17:20:47 -0000 On 5/11/2017 12:51 PM, Gowrishankar wrote: > From: Gowrishankar Muthukrishnan > > In kni_allocate_mbufs(), we attempt to add max_burst (32) count of mbuf > always into alloc_q, which is excessively leading too many rte_pktmbuf_ > free() when alloc_q is contending at high packet rate (for eg 10Gig data). > In a situation when alloc_q fifo can only accommodate very few (or zero) > mbuf, create only what needed and add in fifo. > > With this patch, we could stop random network stall in KNI at higher packet > rate (eg 1G or 10G data between vEth0 and PMD) sufficiently exhausting > alloc_q on above condition. I tested i40e PMD for this purpose in ppc64le. > > Changes: > v2 - alloc_q free count calculation corrected. > line wrap fixed for commit message. > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Ferruh Yigit