From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57E83A0C41; Wed, 15 Sep 2021 15:50:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25A8E4014F; Wed, 15 Sep 2021 15:50:16 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 9989B4003C for ; Wed, 15 Sep 2021 15:50:14 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 25E6A7F52A; Wed, 15 Sep 2021 16:50:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 25E6A7F52A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1631713814; bh=aJFCXkXyZwXWSx2PovAuJON9kDB+ZF+qvlXdIEzASNQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=MfzEFX5DCscjEVqC3tqW/qOW+e3146huG0Yx/GMjj6+YApN6MpmtIdq2EYjPomZSq Bo9b8u65rXnTloAcLK0MdEQvJ7J8ezbXYDKa2rS9xAL0KBkGzAXVHeEhD51M+R+r3T KMtUP+p3eR+mVQI05if5GdaAOlKXxLUwlgVaP9Gg= To: Ferruh Yigit , Xiaoyun Li Cc: dev@dpdk.org, Xueming Li , Viacheslav Galaktionov , Andy Moreton References: <20210827063935.1834143-1-andrew.rybchenko@oktetlabs.ru> <20210831161242.3465395-1-andrew.rybchenko@oktetlabs.ru> <78232368-50f3-a03e-aedf-b7f0a8249792@intel.com> <7591e9b6-feea-e7e9-ff07-3c35d1243031@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <4cadb202-d4da-7b86-01a1-c4e117e3cbd8@oktetlabs.ru> Date: Wed, 15 Sep 2021 16:50:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <7591e9b6-feea-e7e9-ff07-3c35d1243031@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add command to print representor info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/14/21 7:36 PM, Ferruh Yigit wrote: > On 9/14/2021 5:17 PM, Andrew Rybchenko wrote: >> On 9/14/21 6:52 PM, Ferruh Yigit wrote: >>> On 8/31/2021 5:12 PM, Andrew Rybchenko wrote: >>>> From: Viacheslav Galaktionov >>>> >>>> Make it simpler to debug configurations and code related to the representor >>>> info API. >>>> >>>> Signed-off-by: Viacheslav Galaktionov >>>> Signed-off-by: Andrew Rybchenko >>>> Reviewed-by: Andy Moreton >>>> --- >>>> v2: >>>> - change output format to log just one line per range >>>> >>>> app/test-pmd/cmdline.c | 135 +++++++++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 135 insertions(+) >>>> >>>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >>>> index 82253bc751..ae700f9dd1 100644 >>>> --- a/app/test-pmd/cmdline.c >>>> +++ b/app/test-pmd/cmdline.c >>>> @@ -236,6 +236,10 @@ static void cmd_help_long_parsed(void *parsed_result, >>>> " Show port supported ptypes" >>>> " for a specific port\n\n" >>>> >>>> + "show port (port_id) representor info\n" >>>> + " Show supported representors" >>>> + " for a specific port\n\n" >>>> + >>> >>> What do you think extending existing "show port info #" command instead of >>> creating a new command for it? >> >> My fear with such approach is that output of the "show port >> info #" is already too long and adding representors info >> there will make it even much longer. >> > > That is fair concern, what about extend existing command with a new keyword to > just print representor info: > "show port info # representor" Good idea, see v3. >>> Since "show port info #" is a well known command, it can simplify the usage. >>> When port is representor port it can display additional info. >>> >> >> Just to be clear: it will output information for "backer" >> (or parent) port which should be used to create representors. >>