[dpdk-dev] [PATCH] examples/vm_power: fix build

[dpdk-dev] [PATCH] examples/vm_power: fix build

[Ferruh Yigit]

Fixes: 70febdcfd60f ("examples: check status of getting MAC address")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Igor Romanov <igor.romanov@oktetlabs.ru>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
---
 examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
index 77e54401a..fe09b0778 100644
--- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
+++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
@@ -55,10 +55,10 @@ set_policy_mac(int port, int idx)
 
 	/* Use port MAC address as the vfid */
 	ret = rte_eth_macaddr_get(port, &pfid.addr);
-	if (retval != 0) {
+	if (ret != 0) {
 		printf("Failed to get device (port %u) MAC address: %s\n",
-				port, rte_strerror(-retval));
-		return retval;
+				port, rte_strerror(-ret));
+		return ret;
 	}
 
 	printf("Port %u MAC: %02" PRIx8 ":%02" PRIx8 ":%02" PRIx8 ":"
@@ -108,6 +108,8 @@ set_policy_defaults(struct channel_packet *pkt)
 	pkt->policy_to_use = TIME;
 	pkt->command = PKT_POLICY;
 	strcpy(pkt->vm_name, "ubuntu2");
+
+	return 0;
 }
 
 static void cmd_quit_parsed(__attribute__((unused)) void *parsed_result,
-- 
2.21.0

Re: [dpdk-dev] [PATCH] examples/vm_power: fix build

[Andrew Rybchenko]

On 10/14/19 1:03 PM, Ferruh Yigit wrote:
> Fixes: 70febdcfd60f ("examples: check status of getting MAC address")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Thanks Ferruh, it is consequences of vm_power_manager
excluded from build because of missing libvirt dependency and
our inattentiveness when checking build results.

Re: [dpdk-dev] [PATCH] examples/vm_power: fix build

[Ferruh Yigit]

On 10/14/2019 11:10 AM, Andrew Rybchenko wrote:
> On 10/14/19 1:03 PM, Ferruh Yigit wrote:
>> Fixes: 70febdcfd60f ("examples: check status of getting MAC address")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Thanks Ferruh, it is consequences of vm_power_manager
> excluded from build because of missing libvirt dependency and
> our inattentiveness when checking build results.
> 

I also missed it because of same reason, validation team caught it :)

Re: [dpdk-dev] [PATCH] examples/vm_power: fix build

[Bruce Richardson]

On Mon, Oct 14, 2019 at 11:03:50AM +0100, Ferruh Yigit wrote:
> Fixes: 70febdcfd60f ("examples: check status of getting MAC address")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Igor Romanov <igor.romanov@oktetlabs.ru>
> Cc: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
>  examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
The guest_cli part of the example app was not being built by the meson
builds. I'm now reworking series [1] to include it (a one-line addition is
really all that's needed). When added I see these build errors and this
patch fixes them.

Tested-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

[1] http://patches.dpdk.org/project/dpdk/list/?series=6864

Re: [dpdk-dev] [PATCH] examples/vm_power: fix build

[Thomas Monjalon]

22/10/2019 15:13, Bruce Richardson:
> On Mon, Oct 14, 2019 at 11:03:50AM +0100, Ferruh Yigit wrote:
> > Fixes: 70febdcfd60f ("examples: check status of getting MAC address")
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks