From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 18B2F324D for ; Tue, 26 Feb 2019 15:44:23 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 30D2558594; Tue, 26 Feb 2019 14:44:22 +0000 (UTC) Received: from [10.36.112.64] (ovpn-112-64.ams2.redhat.com [10.36.112.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF63E600C0; Tue, 26 Feb 2019 14:44:20 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org References: <20190222024209.30879-1-tiwei.bie@intel.com> <20190222024209.30879-5-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <4cbc699e-a136-8b5f-ce25-278af179bb42@redhat.com> Date: Tue, 26 Feb 2019 15:44:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190222024209.30879-5-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 26 Feb 2019 14:44:22 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 4/4] doc: improve vhost zero copy guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 14:44:23 -0000 On 2/22/19 3:42 AM, Tiwei Bie wrote: > Highlight that vhost zero copy mbufs should be consumed > as soon as possible. > > Signed-off-by: Tiwei Bie > --- > doc/guides/prog_guide/vhost_lib.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst > index c77df338f..a86c07a62 100644 > --- a/doc/guides/prog_guide/vhost_lib.rst > +++ b/doc/guides/prog_guide/vhost_lib.rst > @@ -92,6 +92,9 @@ The following is an overview of some key Vhost API functions: > to use vfio-pci driver, please insert vfio-pci kernel module in noiommu > mode. > > + * The consumer of zero copy mbufs should consume these mbufs as soon as > + possible, otherwise it may block the operations in vhost. > + > - ``RTE_VHOST_USER_IOMMU_SUPPORT`` > > IOMMU support will be enabled when this flag is set. It is disabled by > Indeed, and it may also block QEMU. That's what I find really fragile with dequeue zero-copy. Reviewed-by: Maxime Coquelin Thanks, Maxime