From: Garrett D'Amore <garrett@damore.org>
To: dev@dpdk.org
Subject: Incoming changes for GVNIC
Date: Sat, 14 Sep 2024 13:10:20 -0700 [thread overview]
Message-ID: <4cbd4920-5dd2-4efa-9d47-6ddb4fdf9ddc@Spark> (raw)
[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]
This is mostly a heads up....
We (WEKA) use various drivers with specific alignment requirements, which causes us to need to need to use multibuffer (scatter/gather) functionality in various drivers.
Unfortunately, the GVNIC driver was ... very... buggy in this regard (in fact it doesn't work at all in this case!), especially for the DQO mode used on gen 3 (C3) instances. It turns out it was also buggy in that it was not properly resetting the device on teardown, creating a situation where DMA could be occurring to memory regions after process exit (and thus to invalid memory!)
I've fixed this in our code (its still under review and testing internally) -- but I'd like to upstream these fixes too. (For benefit of anyone who may have concerns about my "credentials" -- I'm well known for my work in NIC drivers (and many others) in Solaris/illumos, and to a lesser extent (and longer ago) NetBSD.
Anyway, I think I have the detailed instructions for submitting changes to DPDK, but as this is code that is associated with a vendor (Google), I thought I'd reach out first -- if there is a specific code owner here I'd be happy to work with them.
My changes are based on a cherry pick of this driver's code from the upstream 24.07, but mostly we (WEKA) are using DPDK 24.03.
Thanks in advance.
[-- Attachment #2: Type: text/html, Size: 1587 bytes --]
next reply other threads:[~2024-09-14 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 20:10 Garrett D'Amore [this message]
2024-09-15 20:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cbd4920-5dd2-4efa-9d47-6ddb4fdf9ddc@Spark \
--to=garrett@damore.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).