From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6F7C45992; Sat, 14 Sep 2024 22:10:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 831C94025A; Sat, 14 Sep 2024 22:10:33 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 4E6D84014F for ; Sat, 14 Sep 2024 22:10:32 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2068bee21d8so34791795ad.2 for ; Sat, 14 Sep 2024 13:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=damore-org.20230601.gappssmtp.com; s=20230601; t=1726344630; x=1726949430; darn=dpdk.org; h=mime-version:subject:message-id:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=v2aXqyC7fISgXKCwHJ9KTdE/SF2iWwGrWwJoG9WQNeE=; b=xQPSd6x7lthx/Q9hSFIq3kAMa+CXFv4TUuwegZbTTLHLdsLJyA1KqsWjbgl8djJKNt vd4Vp1MEW32cOOro1Bp/LNQTgT/tZ8dpJ3sVAuANrujeC5LizCGU6YH7UOcAkG/TOk/E p/kliz+hnvDiVerQFCBUPHCnxSo69VSt7kqBDZLVLVIGUB+hzw/90cc2MON30GTMspFd UhOQ4KY0OSBYulqvHuCf8vusSybyT+/rVXmoxlnDaGZS9pQn55ehxNXYLUeiXOVecuJZ 28IFiOFEXp3FecIh9KdMn7WAdbuTWIXtd/wKWa5BdrcGah56cRGhYKFnNvvN1H8owLnb GD8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726344630; x=1726949430; h=mime-version:subject:message-id:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=v2aXqyC7fISgXKCwHJ9KTdE/SF2iWwGrWwJoG9WQNeE=; b=ALx9Lixij6yuYGrPO15v/pkdZnbRSQ1nnI7Hyuy8JCF+Fna4oRacvwVjpcW0DZM7Cl Y8CUjjaS+gj/E7aNtxnWF+wTlqC1LLDnFSkCf9+eSigqwDVVoyUqFUYZsi/eWH76QXXb aJBX4U+UBEDOWF2D3TRDW5mUw+OyVppkaS+s/8u2TYK7fjoNzrvX3LtuLwMWOQxS4bdU ZsoskJNpapU+foSVK3vhy8v52ABYVEXrlFEBRF/7okqdvjxb1Ingy5SdcdrmhDaU7UK5 KmELTkzjK1goK6AJvdaLYKCLvMoXr7sZq4wsdI+k8slIQiBHbq1TBNf/oOWdGH/82Z4V JgNw== X-Gm-Message-State: AOJu0YznH05IQ/vJb730Tk/EQkruALFQR9bJ0q0KkFQm1yNAHu2JuH5Q QC/bNKfPdKpzcQEIyqY9tykjDl5pOmTlcTQcrwrfFmCb44d9zESc3CNCPV9pTJFg2bCe9N7DCPG W X-Google-Smtp-Source: AGHT+IGNDZ7wnOM4ftBbXjjIGwqx/QXTVGklFjYLAihUdOBOJXv5JVAsLQ/fhslmq9o8zZoU9d9HXQ== X-Received: by 2002:a17:903:110e:b0:207:1722:37d4 with SMTP id d9443c01a7336-2076e3a2307mr138040065ad.33.1726344629929; Sat, 14 Sep 2024 13:10:29 -0700 (PDT) Received: from [10.41.181.138] ([149.20.194.219]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20794730be0sm12751105ad.264.2024.09.14.13.10.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Sep 2024 13:10:28 -0700 (PDT) Date: Sat, 14 Sep 2024 13:10:20 -0700 From: Garrett D'Amore To: dev@dpdk.org Message-ID: <4cbd4920-5dd2-4efa-9d47-6ddb4fdf9ddc@Spark> Subject: Incoming changes for GVNIC X-Readdle-Message-ID: 4cbd4920-5dd2-4efa-9d47-6ddb4fdf9ddc@Spark MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="66e5edb2_6e534cde_1355" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --66e5edb2_6e534cde_1355 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline This is mostly a heads up.... We (WEKA) use various drivers with specific alignment requirements, which= causes us to need to need to use multibuffer (scatter/gather) functional= ity in various drivers. Unfortunately, the GVNIC driver was ... very... buggy in this regard (in = fact it doesn't work at all in this case=21), especially for the DQO mode= used on gen 3 (C3) instances.=C2=A0=C2=A0It turns out it was also buggy = in that it was not properly resetting the device on teardown, creating a = situation where DMA could be occurring to memory regions after process ex= it (and thus to invalid memory=21) I've fixed this in our code (its still under review and testing internall= y) -- but I'd like to upstream these fixes too.=C2=A0=C2=A0(=46or benefit= of anyone who may have concerns about my =22credentials=22 -- I'm well k= nown for my work in NIC drivers (and many others) in Solaris/illumos, and= to a lesser extent (and longer ago) NetBSD. Anyway, I think I have the detailed instructions for submitting changes t= o DPDK, but as this is code that is associated with a vendor (Google), I = thought I'd reach out first -- if there is a specific code owner here I'd= be happy to work with them. My changes are based on a cherry pick of this driver's code from the upst= ream 24.07, but mostly we (WEKA) are using DPDK 24.03. Thanks in advance. --66e5edb2_6e534cde_1355 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
This is mostly a heads up....

We (WEKA) use various drivers with specific alignment requirements, which= causes us to need to need to use multibuffer (scatter/gather) functional= ity in various drivers.

Unfortunately, the GVNIC driver was ... very... buggy in this regard (in = fact it doesn't work at all in this case=21), especially for the DQO mode= used on gen 3 (C3) instances.&=23160;&=23160;It turns out it was also bu= ggy in that it was not properly resetting the device on teardown, creatin= g a situation where DMA could be occurring to memory regions after proces= s exit (and thus to invalid memory=21)

I've fixed this in our code (its still under review and testing internall= y) -- but I'd like to upstream these fixes too.&=23160;&=23160;(=46or ben= efit of anyone who may have concerns about my =22credentials=22 -- I'm we= ll known for my work in NIC drivers (and many others) in Solaris/illumos,= and to a lesser extent (and longer ago) NetBSD.

Anyway, I think I have the detailed instructions for submitting changes t= o DPDK, but as this is code that is associated with a vendor (Google), I = thought I'd reach out first -- if there is a specific code owner here I'd= be happy to work with them.

My changes are based on a cherry pick of this driver's code from the upst= ream 24.07, but mostly we (WEKA) are using DPDK 24.03.

Thanks in advance.
--66e5edb2_6e534cde_1355--