From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95CC6A04F6; Wed, 11 Dec 2019 17:43:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A1C534EF; Wed, 11 Dec 2019 17:43:48 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3292E1D9E for ; Wed, 11 Dec 2019 17:43:46 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 08:43:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,301,1571727600"; d="scan'208";a="210823029" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.237.220.96]) ([10.237.220.96]) by fmsmga008.fm.intel.com with ESMTP; 11 Dec 2019 08:43:44 -0800 From: "Medvedkin, Vladimir" To: dev@dpdk.org Cc: konstantin.ananyev@intel.com, akhil.goyal@nxp.com References: <4697977e04cf3622d1752e171956709a3eff6e10.1576080741.git.vladimir.medvedkin@intel.com> Message-ID: <4d0f64de-897c-4a90-0156-516d13e4896c@intel.com> Date: Wed, 11 Dec 2019 16:43:43 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <4697977e04cf3622d1752e171956709a3eff6e10.1576080741.git.vladimir.medvedkin@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 1/4] ipsec: move ipsec sad name length into .h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Self NACK for series Forgot cover letter, will resend again. On 11/12/2019 16:13, Vladimir Medvedkin wrote: > Move IPSEC_SAD_NAMESIZE into public header > and rename it to RTE_IPSEC_SAD_NAMESIZE > > Signed-off-by: Vladimir Medvedkin > --- > lib/librte_ipsec/ipsec_sad.c | 20 ++++++++++---------- > lib/librte_ipsec/rte_ipsec_sad.h | 2 ++ > 2 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/lib/librte_ipsec/ipsec_sad.c b/lib/librte_ipsec/ipsec_sad.c > index db2c44c..2c994ed 100644 > --- a/lib/librte_ipsec/ipsec_sad.c > +++ b/lib/librte_ipsec/ipsec_sad.c > @@ -20,7 +20,6 @@ > * indicate presence of entries with the same SPI in DIP and DIP+SIP tables. > */ > > -#define IPSEC_SAD_NAMESIZE 64 > #define SAD_PREFIX "SAD_" > /* "SAD_" */ > #define SAD_FORMAT SAD_PREFIX "%s" > @@ -34,7 +33,7 @@ struct hash_cnt { > }; > > struct rte_ipsec_sad { > - char name[IPSEC_SAD_NAMESIZE]; > + char name[RTE_IPSEC_SAD_NAMESIZE]; > struct rte_hash *hash[RTE_IPSEC_SAD_KEY_TYPE_MASK]; > /* Array to track number of more specific rules > * (spi_dip or spi_dip_sip). Used only in add/delete > @@ -231,7 +230,7 @@ struct rte_ipsec_sad * > rte_ipsec_sad_create(const char *name, const struct rte_ipsec_sad_conf *conf) > { > char hash_name[RTE_HASH_NAMESIZE]; > - char sad_name[IPSEC_SAD_NAMESIZE]; > + char sad_name[RTE_IPSEC_SAD_NAMESIZE]; > struct rte_tailq_entry *te; > struct rte_ipsec_sad_list *sad_list; > struct rte_ipsec_sad *sad, *tmp_sad = NULL; > @@ -249,8 +248,8 @@ rte_ipsec_sad_create(const char *name, const struct rte_ipsec_sad_conf *conf) > return NULL; > } > > - ret = snprintf(sad_name, IPSEC_SAD_NAMESIZE, SAD_FORMAT, name); > - if (ret < 0 || ret >= IPSEC_SAD_NAMESIZE) { > + ret = snprintf(sad_name, RTE_IPSEC_SAD_NAMESIZE, SAD_FORMAT, name); > + if (ret < 0 || ret >= RTE_IPSEC_SAD_NAMESIZE) { > rte_errno = ENAMETOOLONG; > return NULL; > } > @@ -326,7 +325,8 @@ rte_ipsec_sad_create(const char *name, const struct rte_ipsec_sad_conf *conf) > /* guarantee there's no existing */ > TAILQ_FOREACH(te, sad_list, next) { > tmp_sad = (struct rte_ipsec_sad *)te->data; > - if (strncmp(sad_name, tmp_sad->name, IPSEC_SAD_NAMESIZE) == 0) > + if (strncmp(sad_name, tmp_sad->name, > + RTE_IPSEC_SAD_NAMESIZE) == 0) > break; > } > if (te != NULL) { > @@ -354,14 +354,14 @@ rte_ipsec_sad_create(const char *name, const struct rte_ipsec_sad_conf *conf) > struct rte_ipsec_sad * > rte_ipsec_sad_find_existing(const char *name) > { > - char sad_name[IPSEC_SAD_NAMESIZE]; > + char sad_name[RTE_IPSEC_SAD_NAMESIZE]; > struct rte_ipsec_sad *sad = NULL; > struct rte_tailq_entry *te; > struct rte_ipsec_sad_list *sad_list; > int ret; > > - ret = snprintf(sad_name, IPSEC_SAD_NAMESIZE, SAD_FORMAT, name); > - if (ret < 0 || ret >= IPSEC_SAD_NAMESIZE) { > + ret = snprintf(sad_name, RTE_IPSEC_SAD_NAMESIZE, SAD_FORMAT, name); > + if (ret < 0 || ret >= RTE_IPSEC_SAD_NAMESIZE) { > rte_errno = ENAMETOOLONG; > return NULL; > } > @@ -372,7 +372,7 @@ rte_ipsec_sad_find_existing(const char *name) > rte_mcfg_tailq_read_lock(); > TAILQ_FOREACH(te, sad_list, next) { > sad = (struct rte_ipsec_sad *) te->data; > - if (strncmp(sad_name, sad->name, IPSEC_SAD_NAMESIZE) == 0) > + if (strncmp(sad_name, sad->name, RTE_IPSEC_SAD_NAMESIZE) == 0) > break; > } > rte_mcfg_tailq_read_unlock(); > diff --git a/lib/librte_ipsec/rte_ipsec_sad.h b/lib/librte_ipsec/rte_ipsec_sad.h > index 8386f73..dcc8224 100644 > --- a/lib/librte_ipsec/rte_ipsec_sad.h > +++ b/lib/librte_ipsec/rte_ipsec_sad.h > @@ -47,6 +47,8 @@ union rte_ipsec_sad_key { > struct rte_ipsec_sadv6_key v6; > }; > > +/** Max number of characters in SAD name. */ > +#define RTE_IPSEC_SAD_NAMESIZE 64 > /** Flag to create SAD with ipv6 dip and sip addresses */ > #define RTE_IPSEC_SAD_FLAG_IPV6 0x1 > /** Flag to support reader writer concurrency */ -- Regards, Vladimir