From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06B31A034F; Wed, 31 Mar 2021 10:23:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72EC84069E; Wed, 31 Mar 2021 10:23:41 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id C80E040141 for ; Wed, 31 Mar 2021 10:23:39 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 730B85C00E6; Wed, 31 Mar 2021 04:23:39 -0400 (EDT) Received: from imap22 ([10.202.2.72]) by compute1.internal (MEProxy); Wed, 31 Mar 2021 04:23:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u256.net; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=oHGf3jVYfAjgvn7ycSmR+w6Yu/YYvPX glbElQgeBiWs=; b=Tj6NSVe1vSrxwDr95Zz4FUok54JN9kSuoyq3+FTmVlmCV5A 3NPv7gLuuCIJBhdN5m8gjhzwH1Evc1l9Dw5RNROF47Ofrbyu3gbgC+dXvE+HmGoy QFIrKWkscvB2ChdsO8siEFCTQcbsbwp76UDG+B43NlNbY76qoBNlqhwxPwputg4B 5S+hc+fpO8T5DTdPN2CaNgzTIqsEL39ACtqhqecvBXSFeB0Z1tO+eAVZiqf8G//U lOY+F6CLA1/oCpv8zUh1I3R8qomICAWqyimPox5CjXsGF9ADMqAAfkXbIMRqrQco G//ALKj9JwisZoh+wK4FHt6bTiaOW0c4KQu5ylA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=oHGf3j VYfAjgvn7ycSmR+w6Yu/YYvPXglbElQgeBiWs=; b=Zco/ftMOTewRYy6hDf4bId aIBZgb3GR5MLgxtmup8XyeG7bCAEstjOhGyGusYKdLcf7xm9orvAjWkbw1Ivqo93 Hu/K/OsmGtfmEw61RWj9WFu5w4MEovtxc3mJjJfwDDD2tFURcric6Iwlc9K8fT32 U32QOgbFozchVHKEVY+uU4RD59WL/s2o731WHFq4oRslB4Vq36/uudqbuVwQqSrx 9Q/k7+b6e64vtm7eDzvc2iYyH8N8+LDLD4bPi2D2Uq1NEFfUwDIj+r0wwa0sg3IK LHDxqlZ8mXp5Aebv4i/RWzALTfiWzHzF9PCkqb3Mn0Pl3AOxTdf3Oe/0mtiV3yAQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeivddgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepifgrtoht rghnpgftihhvvghtuceoghhrihhvvgesuhdvheeirdhnvghtqeenucggtffrrghtthgvrh hnpeeitedvuefgiefhhfdtleelveehieetfedthfelffefiefhueeugfekudfggfekteen ucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepghhrihhvvgesuhdvheeirdhnvght X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id D574562C0064; Wed, 31 Mar 2021 04:23:38 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-273-g8500d2492d-fm-20210323.002-g8500d249 Mime-Version: 1.0 Message-Id: <4d1646e7-2a93-4999-b631-15c98f22ea1d@www.fastmail.com> In-Reply-To: <1617106521-25931-1-git-send-email-xuemingl@nvidia.com> References: <1608304614-13908-2-git-send-email-xuemingl@nvidia.com> <1617106521-25931-1-git-send-email-xuemingl@nvidia.com> Date: Wed, 31 Mar 2021 10:23:18 +0200 From: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= To: "Xueming(Steven) Li" , "Thomas Monjalon" , "Gaetan Rivet" Cc: dev@dpdk.org, "Asaf Penso" Content-Type: text/plain Subject: Re: [dpdk-dev] =?utf-8?q?=5BPATCH_v3_0/5=5D_eal=3A_enable_global_dev?= =?utf-8?q?ice_syntax_by_default?= X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 30, 2021, at 14:15, Xueming Li wrote: > The new Global Device Syntax [1] is used to identify a device with full > bus, class and driver description, example: > -a bus=pci,addr=82:00.0/class=eth/driver=mlx5,... > > This patchset fixes bugs and enable global device syntax with > backward compatibility by: > - unify devargs memory buffer cleanup > - parse name from bus callback > - try new global syntax parsing firstly and fallback to legacy parsing. > > > History: > > V1: > - Inital version > > V2: > - add devargs.src as complete source dev string > - change devargs.data to scratch buffer > - add rte_devargs_free() to release scratch memory > - change name policy to align with rte_eth_iterator_init() > - remove PCI bus fix as name already resolved in rte_devargs_parse(). > V3: > - remove devargs.src > - rename rte_devargs_free() to rte_devargs_reset() > - add bus callback api to resolve devargs. > > [1] Global Device Syntax: > https://www.dpdk.org/wp-content/uploads/sites/35/2018/10/am-07-DPDK-hotplug-20180905.pdf > > [2] RFC: > http://patchwork.dpdk.org/project/dpdk/list/?series=14378 > > [3] V1: > http://patchwork.dpdk.org/project/dpdk/list/?series=14610 > > [4] V2: > http://patchwork.dpdk.org/project/dpdk/list/?series=14816 > > > Xueming Li (5): > devargs: unify scratch buffer storage > devargs: fix memory leak on parsing error > kvargs: add get by key function > bus: add device arguments name parsing API > devargs: parse global device syntax > > app/test-pmd/config.c | 3 +- > app/test-pmd/testpmd.c | 5 +- > drivers/bus/pci/pci_common.c | 1 + > drivers/bus/pci/pci_params.c | 48 +++++++++++++++++ > drivers/bus/pci/private.h | 14 +++++ > drivers/bus/vdev/vdev.c | 10 ++-- > drivers/bus/vdev/vdev_params.c | 43 +++++++++++++++ > drivers/bus/vdev/vdev_private.h | 15 ++++++ > drivers/net/failsafe/failsafe_args.c | 3 +- > drivers/net/failsafe/failsafe_eal.c | 2 +- > examples/multi_process/hotplug_mp/commands.c | 6 +-- > lib/librte_eal/common/eal_common_dev.c | 9 ++-- > lib/librte_eal/common/eal_common_devargs.c | 57 ++++++++++++++------ > lib/librte_eal/common/hotplug_mp.c | 6 +-- > lib/librte_eal/include/rte_bus.h | 19 +++++++ > lib/librte_eal/include/rte_devargs.h | 18 +++++-- > lib/librte_eal/rte_eal_exports.def | 1 + > lib/librte_eal/version.map | 1 + > lib/librte_ethdev/rte_ethdev.c | 8 +-- > lib/librte_kvargs/rte_kvargs.c | 20 +++++++ > lib/librte_kvargs/rte_kvargs.h | 21 ++++++++ > lib/librte_kvargs/version.map | 1 + > 22 files changed, 263 insertions(+), 48 deletions(-) > > -- > 2.25.1 > > Hello, For the series: Reviewed-by: Gaetan Rivet -- Gaetan Rivet