From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09082A04BC; Wed, 2 Sep 2020 13:08:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D043B1C0AD; Wed, 2 Sep 2020 13:08:42 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C93E9137D for ; Wed, 2 Sep 2020 13:08:41 +0200 (CEST) IronPort-SDR: quyVGanu9mV5oAjIVG9NknSpwJ+T/kihl6m2yrd/n/E+cL59GXotvwsoTtJDLQWlGclmAT/Gm3 Q9o6q7s0+Low== X-IronPort-AV: E=McAfee;i="6000,8403,9731"; a="156626996" X-IronPort-AV: E=Sophos;i="5.76,381,1592895600"; d="scan'208";a="156626996" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2020 04:08:40 -0700 IronPort-SDR: dGxIWMEruFjFhFpclJ24tszEiLy25dUSQEVxYmjVtP4u9TtRYMR9yYdicH/B7gRi49g0oic8pW kpucMI7IF+ew== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,381,1592895600"; d="scan'208";a="446488260" Received: from klaatz-mobl1.ger.corp.intel.com (HELO [10.213.245.172]) ([10.213.245.172]) by orsmga004.jf.intel.com with ESMTP; 02 Sep 2020 04:08:38 -0700 To: Ciara Power , dev@dpdk.org Cc: Wenzhuo Lu , Beilei Xing , Bernard Iremonger , John McNamara , Marko Kovacevic References: <20200807123009.21266-1-ciara.power@intel.com> <20200820124140.13451-1-ciara.power@intel.com> <20200820124140.13451-37-ciara.power@intel.com> From: "Laatz, Kevin" Message-ID: <4d21dde9-3e6b-e5fe-a77a-345374ddaf45@intel.com> Date: Wed, 2 Sep 2020 12:08:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200820124140.13451-37-ciara.power@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 36/37] doc: remove references to make in testpmd guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 20/08/2020 13:41, Ciara Power wrote: > Make is no longer supported for compiling DPDK, references are now > removed in the documentation. > > Signed-off-by: Ciara Power > --- > doc/guides/testpmd_app_ug/run_app.rst | 6 +++--- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +-------- > 2 files changed, 4 insertions(+), 11 deletions(-) > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index 90cf252df5..f0d838321c 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -71,7 +71,7 @@ practical or possible testpmd supports alternative methods for executing command > > .. code-block:: console > > - ./testpmd -n4 -r2 ... -- -i --cmdline-file=/home/ubuntu/flow-create-commands.txt > + ./dpdk-testpmd -n4 -r2 ... -- -i --cmdline-file=/home/ubuntu/flow-create-commands.txt > Interactive-mode selected > CLI commands to be read from /home/ubuntu/flow-create-commands.txt > Configuring Port 0 (socket 0) > @@ -329,8 +329,6 @@ The available information categories are: > > * ``icmpecho``: Receives a burst of packets, lookup for ICMP echo requests and, if any, send back ICMP echo replies. > > -* ``ieee1588``: Demonstrate L2 IEEE1588 V2 PTP timestamping for RX and TX. Requires ``CONFIG_RTE_LIBRTE_IEEE1588=y``. > - The support for ieee1588 info is not being removed, this line should stay in the documentation. Just remove the "CONFIG..." part. LGTM other than that. Reviewed-by: Kevin Laatz