From: Ferruh Yigit <ferruh.yigit@amd.com>
To: mmaatuq <mahmoudmatook.mm@gmail.com>, Long Li <longli@microsoft.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] net/mana: fix uninitialized scalar variable
Date: Wed, 12 Jun 2024 14:17:50 +0100 [thread overview]
Message-ID: <4d598e54-d6b4-44f8-b7d6-0609b449be90@amd.com> (raw)
In-Reply-To: <20240610220703.679689-1-mahmoudmatook.mm@gmail.com>
On 6/10/2024 11:07 PM, mmaatuq wrote:
> in case we didn't enter or finished the loop without getting ifname we
> ret shouldn't have an arbitrary value.
>
> Coverity issue: 424690
>
> Signed-off-by: mmaatuq <mahmoudmatook.mm@gmail.com>
>
Change looks good to me,
but can you please add Fixes tag [1] and perhaps stable tag based on the
fixes tag, checkpatch will generate a warning for it if required, after
Fixes tag added.
Also can you please use full name, as following capitalization:
Name Surname <email-all-lowercase@domain.com>
[1]
https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body
> ---
> v2:
> Fixed typo in word "arbitrary"
> ---
> drivers/net/mana/mana.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c
> index 68c625258e..c37c4e3444 100644
> --- a/drivers/net/mana/mana.c
> +++ b/drivers/net/mana/mana.c
> @@ -715,7 +715,7 @@ mana_dev_stats_reset(struct rte_eth_dev *dev __rte_unused)
> static int
> mana_get_ifname(const struct mana_priv *priv, char (*ifname)[IF_NAMESIZE])
> {
> - int ret;
> + int ret = -ENODEV;
> DIR *dir;
> struct dirent *dent;
>
> --
> 2.43.0
>
prev parent reply other threads:[~2024-06-12 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 22:07 mmaatuq
2024-06-12 13:17 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d598e54-d6b4-44f8-b7d6-0609b449be90@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=longli@microsoft.com \
--cc=mahmoudmatook.mm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).