From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8828B43F04; Wed, 12 Jun 2024 15:18:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7731340395; Wed, 12 Jun 2024 15:18:00 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2078.outbound.protection.outlook.com [40.107.212.78]) by mails.dpdk.org (Postfix) with ESMTP id 35DB74029A for ; Wed, 12 Jun 2024 15:17:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nnryXepPcSy3AlvD9TarADo6I3Wm+qKXWiXid8+duuTqU42TL58gkuwJ7HFj2Lu2YPIdX7zgkcpXu4gbDDq/jE6fJPOBGOhBdLT1amcSwUn6OoD/lHICVmxA8Btn145ZZS6fLRrIXyP73TtAMkCn3laE/+dn2Z4kqeASbzL1uj086IYJt3TjzKYwkVzsKTE6nsuDCpF9RHFmCnE3MsOrR562rIcvJDQhwfNwk49OHmG5VyPmxwTEYuSzkcaD6M54UQPeJCqDyLSDNWnvNy4j1wPqU57YJ3rEtZ7YutX/La/9lJaFhQgLEX9LM4G6YBFeTxt7yuTXMe1qNXIWkZpXZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YVajb90RryhlZPPBH4Jt6kRxIE94SQCrJCrQB9SLpw0=; b=ippBymdJEEmtHxVRCd4DqmWxzBp4Ghw3H4TuJiSKcnWDgP698v2YS14zti5q73r2DD5MaFRV7aPTXlz3nQNGszn8OVVehqJXnXM94qTKLoVaP1lVi5JAKpmKQadH71yGgQoeVQyh4wgLFHjTEeG6dusxYUU1DOM3KeoCMT9M01zuK7Q4wMUKveLe5j7uWJPvHJRAsFhObnBKwQ/4JtLDcfSQROiZK51ar4kOqYzQBFrb+wIVuA03t+Fr6V1m5ELdG9S8T+ydkGZ2mP0k5PLHisNK8puh4E7YZ+j4NEeRXbUj9IG6sHIBspV1yXYub72mxyFcjifzlUU//5W1aw8shQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YVajb90RryhlZPPBH4Jt6kRxIE94SQCrJCrQB9SLpw0=; b=Hh1P/ku/4wB6S2t12HJ6pSGPVsmDVh6eaQs4UVanJ2pJWwzR26DTGvrZj9QTyvH0A1CS7dgdhVBpwRuA4I/9t6W12U1reNijVOCYq6lR8fdbQbOTJAmGpwUgSYXGONHix9OrnbEsrTWVH0aT37tyNXTwCipbP0eC+G9VFatEz1E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS7PR12MB5911.namprd12.prod.outlook.com (2603:10b6:8:7c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.36; Wed, 12 Jun 2024 13:17:55 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7677.019; Wed, 12 Jun 2024 13:17:54 +0000 Message-ID: <4d598e54-d6b4-44f8-b7d6-0609b449be90@amd.com> Date: Wed, 12 Jun 2024 14:17:50 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] net/mana: fix uninitialized scalar variable To: mmaatuq , Long Li Cc: dev@dpdk.org References: <20240610220703.679689-1-mahmoudmatook.mm@gmail.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240610220703.679689-1-mahmoudmatook.mm@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB3PR06CA0017.eurprd06.prod.outlook.com (2603:10a6:8:1::30) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS7PR12MB5911:EE_ X-MS-Office365-Filtering-Correlation-Id: cd2f1f48-fbf2-4afe-a204-08dc8ae211cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230032|1800799016|366008|376006; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Mm8zMzlmTVFubDJldzk5d2VpNkcya0lFTEUxMGtDMERqKzQ4ekQwSUExYzNk?= =?utf-8?B?OVhtcWlwM0gzWXA4b1VvRlVBTTNrKzBjZWwvTSt2cjYvc3V6a2Ryc0J5Q2xK?= =?utf-8?B?YXYyVDM0R2RDdjE3aEROZEhndXh2S1RPM0NIdEFsMGRHbnRKVGY4cEdWekha?= =?utf-8?B?NG1BbFFxZGxVYS9kU25BelZobXIxaWpaYUdKWTlVdElNYzlaM3phU3ZDSUlX?= =?utf-8?B?Mnh5ZlFzbVY5NVBrcHVpQjhJWkJjcmN4aS9JKzZpeGs4MWk2a3BjL2U5VFhP?= =?utf-8?B?cjFQWmVOOEdCL3N4MzJ5ZGMrd3NwZUp2SlVJY2xYcTBhbTUrc0lXM2hwYUhr?= =?utf-8?B?ZlY5RUtYQktmWmdyUlQ0bWRCdEt2OWg0d1BLRFZIRnZMVHNSamVxZFU1Ukpn?= =?utf-8?B?c0gxd0gxVHVyVjJuVmtDVzdHTlNJWjV3MWw3aVJhOTArZHNBbTRaY3JhZzVa?= =?utf-8?B?RXZhdkpqdWlGVjEvK3BFUytwNUhTcDN2MFpUOUpEVWd2ZEp2R2R6SXp2WXpO?= =?utf-8?B?S2NwZS81bW5VVnVQd25FUWFjUnR3ZUlQOXhaK3pnd1RnS2tPTC9oMzJjS1M2?= =?utf-8?B?QUxZZmlmWXZBNEJ5U09WVy8rbVZyR0IrWUpKU296UVFIOEdYekRwcTI2VHd5?= =?utf-8?B?YzB4S0lRZDhuZ0Nnd2t6OXp4NGZwMWIrKzJ1RzA4Nzh0WjJzbUJDNDcyQXJo?= =?utf-8?B?a1NmdWo5UXBSaXVPYjBFMU9lbGhQaE1XNnlUcG5WUTRqcjdLZGV2NlhKQktJ?= =?utf-8?B?eE1MZVJ2a3ZjdjY2R3pUWlIvMGlKMGNmOWo1cTFJK3VvcnorVXhkcGxKMUxs?= =?utf-8?B?QWVYajZiYmxxLzlLTm8rTHRNV3M5SENjcDFhRnlKbDFhbXpQWEkwN2NOUEpM?= =?utf-8?B?TXczS3BlclQ0K1V2NS9yREphYmg0TlUyS0U5R0dkbE10Sjh5Q3Q5WkRNUUxk?= =?utf-8?B?R2E4RHVzTjdsajV2U0g5NlVsMEE1THBPL09pSzdlajBSeExtV0t6UFlrVGR3?= =?utf-8?B?VlRzNVhqdlFodkdGRnNhdHFRMnVYRGhnOXdXMC9sT0NsbXRDUVFQQnFjTjFG?= =?utf-8?B?blk1bmZXMVY4WjQ1cmJrL21RZ1NqYW84QzFHdVVsWllCd05YUW0wbURTeFEz?= =?utf-8?B?NGJBWGRMY3BwdGo0QWo4M2hrbGU3QUQ2V0hYcEgyZ3lTZzdiS3hTOG9LWkc0?= =?utf-8?B?MFVNNTZVWVZ1UmpCQk1XS3k3RVRNOTExVklyTDcwZks4Q0wyUFBVcC9wVFFi?= =?utf-8?B?VW9DNE1UVXdFMVpCeW9ZbGJwZ1c1VWpLYlNoSTVtMkJZV2FtLzBSQ0Nrd2hp?= =?utf-8?B?V1A1aHZ4N29iV2htckNlMDJabkRZMDg5VHg1bXZCUTV4MGZqcXp0dnFNanIx?= =?utf-8?B?SG1wUUJRZ21QeVF5WGJRN3ZUNkxlbnBUS080ZzMycW1GY2ZwWTJybzRWTkxF?= =?utf-8?B?ei9TbmRNRkNtSVRFMlhjaFBWU2hwckNJRERGSWpMbkh5bzU3Z2s2anBTaEpt?= =?utf-8?B?bnVWL1BiNElwUHJ3eEkrRkwvZHg3bFIvMTNxVjB5c2RVMmQwS0tGaG5hSGo0?= =?utf-8?B?V1NySmsrdVYwNkUrclRMd2c1NllkS1g4TDBSZzRLSitPQmwvTU9pamhrS2Ro?= =?utf-8?B?MGdLcTF4dlVHaFJNNUdGNzA5WjBxdVU2SThPdVJyOGFQS0VVSWEySFUvTTds?= =?utf-8?Q?eqr6qK/tipRgnVCgDOb0?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230032)(1800799016)(366008)(376006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SE1MK3c5Zlp1R2thQS93WjZmSklDNU9oa2tUdDRLRW4wS0IrSVJad3NENWxW?= =?utf-8?B?dDJlWkVqR0lUc0NsRVRnSFpibzMxencxRVB5SzBYUUp2eHdsMWxzVXp2U3lq?= =?utf-8?B?U0UrcVZOQnM1QVkwR0ZsMmR3Y2E4Vy80eEhGcTl2cVpvZHpKeldJQnFlUG5D?= =?utf-8?B?REFPSGJmVjVWWW5kMzRSSHJKMjN6YmxsK0tMK2o0WEZkTmRJTDZkdmEvV2Jq?= =?utf-8?B?NFYxV3V2aW5MVDNIeTAwemFVZnd6OVZwMFR2YWZUakJRdTZuZk1nK0ptdTYv?= =?utf-8?B?WFk0Z1dQeFAvQ0hzd2RUektpc2tIMldrM0VkZ2wzeFNzOWRIM0U3R3BIWGJ3?= =?utf-8?B?N1ZkOUFXTUllcHhoNDIzbDNnaVJVMmk4Wk1SbjVWbzROd0x4Z2ZtRk9ySGNF?= =?utf-8?B?QytjLyszYnJIdk9XOEYvQnlWOFYyV25lVVkrOW9UYzl5a2hZbzM0NllaaDRk?= =?utf-8?B?NEV0UmVFV01paXEzU0pvaGVkQzhWVGZYanY2bmYxdnA2V0RJSlpBbTJQVlNT?= =?utf-8?B?dytXQmtOTnZNcjlabVJiMDhNYWNrcUlmU2tzQmtYRERZb0pReTdzMXJ3TWE4?= =?utf-8?B?NWNYVC9wYjNvTEM5UndJY0lqZVl6SnNwNkJiWXl6YlRrUTBOUVc1SlplbGJO?= =?utf-8?B?QUJQNFRTQ1V6Z0d6L2dNQVVFSENuWTZLYkhxd2xjWFUxemsvL0l5Qm9nc0pq?= =?utf-8?B?bXBMTmxEbHgwdVAraGU0SDg5SjlKMmtDaklWRmhaUS8rR0FqYlRpQzFDbjFr?= =?utf-8?B?MmZ4RGxVNlU1K3FVMG1Fa3N4ZldKTFlFV2h6T21aZW1paFh1aGlWMzZDYWxT?= =?utf-8?B?YnE2SFRzTC81eWRJQWhncVo2N2Fzbmc5Rk5IaXdoQzV4Q1haakcrOU0zSnB1?= =?utf-8?B?ZUhrdU5HTmVkZzVpektEREZ2QnFvOWQrU2tHRDQvNEtQeUlnMllzTEtEODY1?= =?utf-8?B?ZlFaK1NzRU0wWjNoZjlNbDIyQlVFUkRzNjV5akZXejMrVmxwam5iWXRqTHpH?= =?utf-8?B?eUFHSVZyZFRBNnRzQStBelh6aW5FSVlUdmI1eXQrUEtzdjZzR2V2STd3OEcw?= =?utf-8?B?VjA4WjlTRThML0IyWFEwOHJwcFF1d1FPdWtvOXU3VGFJc3Fsd2R6YjgzK2Yr?= =?utf-8?B?TWRleEtDR1c0VThrTWJjSUh6UTVaczJPa25MSU94dWpiZjZNaS90WkVBRDFQ?= =?utf-8?B?cEhxaTNkZDVyNUpPVGp5TTZXczJoR2c4QzZVYnp3Wit3dXo2RVB0eDAxS1dm?= =?utf-8?B?Tms0anRPOC9mOEJGcGhvTERxN2lNMTFuNmliUE5GWmJBMHZpQjIvSlVTWmRq?= =?utf-8?B?Vk1tVlVXN0xLekUrMnVneWJ1T0kxcnNWQ1piMjN5UFNOUjg3eWdDb3U3MGxp?= =?utf-8?B?SXdKejZaTjlDcC9RdFM1NVFVNVlTZUlyYkQxcmJiUWFXT0txbTlSR2tDaXk2?= =?utf-8?B?UzkwMTEydnlwMjV4VmRFaCtXSG9TMFJwai9jS3J1UDVvdmdFYWNrUVd4ekF1?= =?utf-8?B?dnRtMmxiTUJtemNDMlNENEcxenhuMUFudFE2akFWQ0pKRDVHOEdyZ2tIOG9Z?= =?utf-8?B?WEhpa2Vnb1FUT1kvTllTQW55Z1UxZGdJazZ0UnBLUkp1b3hIMktndnBrRFhM?= =?utf-8?B?SHNBZ01KUjQ4REc4dHJocGVxR0szQThER1NEZjFPVnBkUU4rT1RQT3h5dlFh?= =?utf-8?B?bjBOQkVrSFgwcnhiaElOYUMwanRNdnVoUjBWRzl2MlZUOWFzQmh0RndmWE40?= =?utf-8?B?dWpOZjJXbUtLRXBZTkJma3JCeWRLWVBvQzIydmZCa1RLckpaVE5IU2pjY1FQ?= =?utf-8?B?QlAvb3pwREYzYzNDLzBBck1jSHJBUHNmb0lvUmRJdW5qTFNBZGNLeXJhRTBV?= =?utf-8?B?d2lUcmtOeU5WVWprUkEvTkNOcFZPUWlieXZYRC8zYzZLQ2d5WCtZUjBRYm1k?= =?utf-8?B?M1hvOVRWa081KzZ2UXdKd24yTHY0YVJRV2QreUExU2RPWWNZOG96dnBYaWhC?= =?utf-8?B?NXFlNnMwUnpOTEZhT0VabDNkdit4SnNEbjExeFJOTUQzOGVOL3FRWHlZR2xh?= =?utf-8?B?bkpxUUV5OHBkeDRONHFPODQxTXM4MjUwSGJ0dnJ2NTVUT0lTR2pKaXRiNUZp?= =?utf-8?Q?UtB4xSIz35Ecw+Iynm11P5urK?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd2f1f48-fbf2-4afe-a204-08dc8ae211cc X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 13:17:54.8410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s9X2alvsXlukfP2qR0pGwwByVjsZ6dA4RigkbsZAqjIjags5gzKAcHYRd7R3ornq X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5911 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/10/2024 11:07 PM, mmaatuq wrote: > in case we didn't enter or finished the loop without getting ifname we > ret shouldn't have an arbitrary value. > > Coverity issue: 424690 > > Signed-off-by: mmaatuq > Change looks good to me, but can you please add Fixes tag [1] and perhaps stable tag based on the fixes tag, checkpatch will generate a warning for it if required, after Fixes tag added. Also can you please use full name, as following capitalization: Name Surname [1] https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body > --- > v2: > Fixed typo in word "arbitrary" > --- > drivers/net/mana/mana.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c > index 68c625258e..c37c4e3444 100644 > --- a/drivers/net/mana/mana.c > +++ b/drivers/net/mana/mana.c > @@ -715,7 +715,7 @@ mana_dev_stats_reset(struct rte_eth_dev *dev __rte_unused) > static int > mana_get_ifname(const struct mana_priv *priv, char (*ifname)[IF_NAMESIZE]) > { > - int ret; > + int ret = -ENODEV; > DIR *dir; > struct dirent *dent; > > -- > 2.43.0 >