From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 401D842D06; Tue, 20 Jun 2023 11:49:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 356B0410D7; Tue, 20 Jun 2023 11:49:42 +0200 (CEST) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id 19F93410D7 for ; Tue, 20 Jun 2023 11:49:40 +0200 (CEST) Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3113675d582so2044384f8f.3 for ; Tue, 20 Jun 2023 02:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1687254580; x=1689846580; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mIisosd6Id90iAIZkdwfNlOTa3M6d/G3AdkxEUTTs3Q=; b=TbwmIq+02VFVFnqWSy0PSOaLo077lZ3C9330+Ri+2esKWssS/NofJFPy4+gtbGufdb AGTqQ6VLZjU+Tv8g8L4TyTa8m8gsGsEBhvUCSprK0ocALGbhpUu4s7KJLGJPx0hN+6/8 eo2YctZYfsGo346oLqqjsSXYGJZ2P88amMIStXJ//5stOGRJpHh2XJ0vPfZ1P7gkHpyr RBvrv71b3RwaVq3QTs4FG+dfqOb1wrGCdtyN0uyIsGKYZdDQpSuX9juCtXKlGerAZUB5 e59FRbFLOVOEQtxTSha3pjVLcIMHjS6uB7fUFnOLIxpwz5JbkmnhqdE/4aDj0iKU8BFV klZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687254580; x=1689846580; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mIisosd6Id90iAIZkdwfNlOTa3M6d/G3AdkxEUTTs3Q=; b=d1lhQO+u2ldYapLvVdut2GEDFLWoB92XSGHHOEoeo+suF5vrDr8bORNTQYK1A85Um5 i0qHQba8SuHWA6eyiwWeFE3Chze4utL6TCeyVa9eOKN03qzLpF+VS6oCO53T8eybaEx0 XqZtthzXUDZXwvyB5UMsd5sr9VK6k+PQzT+ljSmmBnu+pTD5PANUh2NwCglBFP0RSQdy EHklqnOkB1lOa31QOL4s2WjoEFtlZspvdH3YH3sPVNo1PVYwY2Gi7XJeoZ6zww5CseyW UZ+Xm+KeBHE3EQOx5SEFHksennlyRQhSxccAE58R0HMPtYw4pifLmB5Zz5FnaLIKbM35 P3Cw== X-Gm-Message-State: AC+VfDxlSjMOR+pEE+h/WGIAUmSx6TcF95mruQisbf0h9X6odoTCDSI2 yqCU8+tgSYTbRukrE7r3AlAF2YSJf8v3/lPy/g== X-Google-Smtp-Source: ACHHUZ5sB0YmtNEJdK9/J32BCzXs2ryRLugLoBvERk3Tp7zw7aqz3jlf5AHYwAQf0+n4a6BNYCDMAQ== X-Received: by 2002:a5d:5960:0:b0:30f:c56c:b5b0 with SMTP id e32-20020a5d5960000000b0030fc56cb5b0mr8166056wri.4.1687254579793; Tue, 20 Jun 2023 02:49:39 -0700 (PDT) Received: from [10.17.1.39] ([185.13.181.2]) by smtp.gmail.com with ESMTPSA id j11-20020a5d604b000000b003078681a1e8sm1600055wrt.54.2023.06.20.02.49.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jun 2023 02:49:39 -0700 (PDT) Message-ID: <4d76098c-e883-98be-89da-40fafa083d56@6wind.com> Date: Tue, 20 Jun 2023 11:49:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] common/cnxk/roc_npa: fix npa_aura_fini Content-Language: en-US To: David Marchand , Ashwin Sekhar T K , Nithin Dabilpuram , Satha Koteswara Rao Kottidi , Jerin Jacob Kollanukkaran Cc: dev@dpdk.org, Thomas Monjalon References: <20230620085134.3124796-1-thierry.herbelot@6wind.com> From: Thierry Herbelot In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello David, I added a trace in mbox_get() to print when a mbox lock was already locked. The traces were displayed when running an internal CI/CD test suite. Best regards Thierry On 6/20/23 11:32, David Marchand wrote: > On Tue, Jun 20, 2023 at 10:51 AM Thierry Herbelot > wrote: >> >> Unlock mbox when an error is detected. > > Out of curiosity, how did you catch it? > > This issue could probably be caught with clang thread safety checks, > but it is disabled on this driver atm. > https://git.dpdk.org/dpdk/commit/drivers/common/cnxk?id=70cc4e1fed665712e68f2f45d98dda4abc6accda > > -- Thierry Herbelot Senior Software Engineer Tel: +33 1 39 30 92 61 http://www.6wind.com/ Follow us: https://www.linkedin.com/company/6wind/ https://twitter.com/6WINDsoftware https://www.youtube.com/user/6windsoftware