DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 0/2] meson build fixes for hns3
@ 2021-02-03 12:46 Lijun Ou
  2021-02-03 12:46 ` [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build Lijun Ou
                   ` (4 more replies)
  0 siblings, 5 replies; 45+ messages in thread
From: Lijun Ou @ 2021-02-03 12:46 UTC (permalink / raw)
  To: ferruh.yigit; +Cc: dev, linuxarm

This series fix meson build for kunpeng920 and
kunpeng930 boards.

Chengchang Tang (2):
  config/arm: fix Hisilicon kunpeng920 SoC build
  config/arm: fix Hisilicon kunpeng930 Soc build

 config/arm/arm64_kunpeng920_linux_gcc              | 19 +++++++++++++++
 config/arm/arm64_kunpeng930_linux_gcc              | 19 +++++++++++++++
 config/arm/meson.build                             | 27 ++++++++++++++++++++++
 .../linux_gsg/cross_build_dpdk_for_arm64.rst       |  5 ++++
 4 files changed, 70 insertions(+)
 create mode 100644 config/arm/arm64_kunpeng920_linux_gcc
 create mode 100644 config/arm/arm64_kunpeng930_linux_gcc

-- 
2.7.4


^ permalink raw reply	[flat|nested] 45+ messages in thread

* [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
  2021-02-03 12:46 [dpdk-dev] [PATCH 0/2] meson build fixes for hns3 Lijun Ou
@ 2021-02-03 12:46 ` Lijun Ou
  2021-02-10  9:41   ` Thomas Monjalon
  2021-02-03 12:46 ` [dpdk-dev] [PATCH 2/2] config/arm: fix Hisilicon kunpeng930 Soc build Lijun Ou
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 45+ messages in thread
From: Lijun Ou @ 2021-02-03 12:46 UTC (permalink / raw)
  To: ferruh.yigit; +Cc: dev, linuxarm

From: Chengchang Tang <tangchengchang@huawei.com>

Because of the '9ca2f16' have merged, the current hns3
pmd driver can not be directly complied on the kunpeng920
server board. Therefore, we need to fix the meson build.
Besides, add kunpeng 920 SoC meson cross compile target.

Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")

Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
 config/arm/arm64_kunpeng920_linux_gcc               | 19 +++++++++++++++++++
 config/arm/meson.build                              | 20 ++++++++++++++++++++
 doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst |  4 ++++
 3 files changed, 43 insertions(+)
 create mode 100644 config/arm/arm64_kunpeng920_linux_gcc

diff --git a/config/arm/arm64_kunpeng920_linux_gcc b/config/arm/arm64_kunpeng920_linux_gcc
new file mode 100644
index 0000000..3eeb2e9
--- /dev/null
+++ b/config/arm/arm64_kunpeng920_linux_gcc
@@ -0,0 +1,19 @@
+[binaries]
+c = 'aarch64-linux-gnu-gcc'
+cpp = 'aarch64-linux-gnu-cpp'
+ar = 'aarch64-linux-gnu-gcc-ar'
+strip = 'aarch64-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+implementer_id = '0x48'
+part_number = '0xd01'
+max_lcores = 128
+max_numa_nodes = 4
diff --git a/config/arm/meson.build b/config/arm/meson.build
index f948768..9b87f5a 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -133,6 +133,25 @@ implementer_cavium = {
 	}
 }
 
+implementer_hisilicon = {
+	'description': 'Hisilicon',
+	'flags': [
+		['RTE_USE_C11_MEM_MODEL', true],
+		['RTE_CACHE_LINE_SIZE', 128],
+		['RTE_MAX_NUMA_NODES', 4]
+	],
+	'part_number_config': {
+		'0xd01': {
+			'machine_args': ['-march=armv8.2-a+crypto',
+					 '-mtune=tsv110'],
+			'flag': [['RTE_MACHINE', '"kunpeng920"'],
+				 ['RTE_MAX_LCORE', 128],
+				 ['RTE_ARM_FEATURE_ATOMICS', true]
+			]
+		}
+	}
+}
+
 implementer_ampere = {
 	'description': 'Ampere Computing',
 	'flags': [
@@ -176,6 +195,7 @@ implementers = {
 	'generic': implementer_generic,
 	'0x41': implementer_arm,
 	'0x43': implementer_cavium,
+	'0x48': implementer_hisilicon,
 	'0x50': implementer_ampere,
 	'0x56': implementer_marvell,
 	'dpaa': implementer_dpaa
diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
index faaf24b..afe4f8e 100644
--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
@@ -197,6 +197,7 @@ you may use various combinations of implementer/part number::
       'generic': Generic armv8
       '0x41':    Arm
       '0x43':    Cavium
+      '0x48':    Hisilicon
       '0x50':    Ampere Computing
       '0x56':    Marvell ARMADA
       'dpaa':    NXP DPAA
@@ -219,6 +220,9 @@ you may use various combinations of implementer/part number::
       '0xaf':    thunderx2t99
       '0xb2':    octeontx2
 
+   Supported part_numbers for 0x48:
+      '0xd01':    kunpeng920
+
    Supported part_numbers for 0x50:
       '0x0':     emag
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 45+ messages in thread

* [dpdk-dev] [PATCH 2/2] config/arm: fix Hisilicon kunpeng930 Soc build
  2021-02-03 12:46 [dpdk-dev] [PATCH 0/2] meson build fixes for hns3 Lijun Ou
  2021-02-03 12:46 ` [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build Lijun Ou
@ 2021-02-03 12:46 ` Lijun Ou
  2021-03-05  1:38 ` [dpdk-dev] [PATCH 0/2] meson build fixes for hns3 oulijun
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 45+ messages in thread
From: Lijun Ou @ 2021-02-03 12:46 UTC (permalink / raw)
  To: ferruh.yigit; +Cc: dev, linuxarm

From: Chengchang Tang <tangchengchang@huawei.com>

Because of the '9ca2f16' have merged, the current hns3
pmd driver can not be directly complied on the kunpeng930
FPGA board. Therefore, we need to fix the meson build.
Besides, add kunpeng 930 SoC meson cross compile target.

Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")

Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
 config/arm/arm64_kunpeng930_linux_gcc               | 19 +++++++++++++++++++
 config/arm/meson.build                              |  7 +++++++
 doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst |  1 +
 3 files changed, 27 insertions(+)
 create mode 100644 config/arm/arm64_kunpeng930_linux_gcc

diff --git a/config/arm/arm64_kunpeng930_linux_gcc b/config/arm/arm64_kunpeng930_linux_gcc
new file mode 100644
index 0000000..464e44a
--- /dev/null
+++ b/config/arm/arm64_kunpeng930_linux_gcc
@@ -0,0 +1,19 @@
+[binaries]
+c = 'aarch64-linux-gnu-gcc'
+cpp = 'aarch64-linux-gnu-cpp'
+ar = 'aarch64-linux-gnu-gcc-ar'
+strip = 'aarch64-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+implementer_id = '0x48'
+part_number = '0xd02'
+max_lcores = 256
+max_numa_nodes = 4
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 9b87f5a..f834adb 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -148,6 +148,13 @@ implementer_hisilicon = {
 				 ['RTE_MAX_LCORE', 128],
 				 ['RTE_ARM_FEATURE_ATOMICS', true]
 			]
+		},
+		'0xd02': {
+			'machine_args': ['-march=armv8.2-a+crypto+sve'],
+			'flag': [['RTE_MACHINE', '"kunpeng930"'],
+				 ['RTE_MAX_LCORE', 256],
+				 ['RTE_ARM_FEATURE_ATOMICS', true]
+			]
 		}
 	}
 }
diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
index afe4f8e..1a54436 100644
--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
@@ -222,6 +222,7 @@ you may use various combinations of implementer/part number::
 
    Supported part_numbers for 0x48:
       '0xd01':    kunpeng920
+      '0xd02':    kunpeng930
 
    Supported part_numbers for 0x50:
       '0x0':     emag
-- 
2.7.4


^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
  2021-02-03 12:46 ` [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build Lijun Ou
@ 2021-02-10  9:41   ` Thomas Monjalon
  2021-02-24  1:34     ` oulijun
  0 siblings, 1 reply; 45+ messages in thread
From: Thomas Monjalon @ 2021-02-10  9:41 UTC (permalink / raw)
  To: Lijun Ou; +Cc: ferruh.yigit, dev, linuxarm

03/02/2021 13:46, Lijun Ou:
> From: Chengchang Tang <tangchengchang@huawei.com>
> 
> Because of the '9ca2f16' have merged, the current hns3
> pmd driver can not be directly complied on the kunpeng920
> server board. Therefore, we need to fix the meson build.
> Besides, add kunpeng 920 SoC meson cross compile target.
> 
> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")

Why do you think this patch is fixing the one above?
It looks just a new config, not a fix. Am I missing something?



^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
  2021-02-10  9:41   ` Thomas Monjalon
@ 2021-02-24  1:34     ` oulijun
  2021-02-24  7:41       ` Thomas Monjalon
  0 siblings, 1 reply; 45+ messages in thread
From: oulijun @ 2021-02-24  1:34 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: ferruh.yigit, dev, linuxarm



在 2021/2/10 17:41, Thomas Monjalon 写道:
> 03/02/2021 13:46, Lijun Ou:
>> From: Chengchang Tang <tangchengchang@huawei.com>
>>
>> Because of the '9ca2f16' have merged, the current hns3
>> pmd driver can not be directly complied on the kunpeng920
>> server board. Therefore, we need to fix the meson build.
>> Besides, add kunpeng 920 SoC meson cross compile target.
>>
>> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
> 
> Why do you think this patch is fixing the one above?
> It looks just a new config, not a fix. Am I missing something?
> 
I'm sorry to see you so late. In the meantime, we are celebrating the 
Spring Festival. This patch fixes the problem. If the patch is not 
added, the latest version cannot be directly compiled on the Kunpeng 930 
server board.In addition, the cross compilation configuration file is added.
> 
> .
> 

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
  2021-02-24  1:34     ` oulijun
@ 2021-02-24  7:41       ` Thomas Monjalon
  2021-02-24  9:17         ` oulijun
  2021-02-24 11:55         ` Juraj Linkeš
  0 siblings, 2 replies; 45+ messages in thread
From: Thomas Monjalon @ 2021-02-24  7:41 UTC (permalink / raw)
  To: oulijun; +Cc: ferruh.yigit, dev, linuxarm

24/02/2021 02:34, oulijun:
> 
> 在 2021/2/10 17:41, Thomas Monjalon 写道:
> > 03/02/2021 13:46, Lijun Ou:
> >> From: Chengchang Tang <tangchengchang@huawei.com>
> >>
> >> Because of the '9ca2f16' have merged, the current hns3
> >> pmd driver can not be directly complied on the kunpeng920
> >> server board. Therefore, we need to fix the meson build.
> >> Besides, add kunpeng 920 SoC meson cross compile target.
> >>
> >> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
> > 
> > Why do you think this patch is fixing the one above?
> > It looks just a new config, not a fix. Am I missing something?
> > 
> I'm sorry to see you so late. In the meantime, we are celebrating the 
> Spring Festival. This patch fixes the problem. If the patch is not 
> added, the latest version cannot be directly compiled on the Kunpeng 930 
> server board.In addition, the cross compilation configuration file is added.

Please can you explain what was removed which breaks your compilation?



^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
  2021-02-24  7:41       ` Thomas Monjalon
@ 2021-02-24  9:17         ` oulijun
  2021-02-24 10:24           ` Thomas Monjalon
  2021-02-24 11:55         ` Juraj Linkeš
  1 sibling, 1 reply; 45+ messages in thread
From: oulijun @ 2021-02-24  9:17 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: ferruh.yigit, dev, linuxarm



在 2021/2/24 15:41, Thomas Monjalon 写道:
> 24/02/2021 02:34, oulijun:
>>
>> 在 2021/2/10 17:41, Thomas Monjalon 写道:
>>> 03/02/2021 13:46, Lijun Ou:
>>>> From: Chengchang Tang <tangchengchang@huawei.com>
>>>>
>>>> Because of the '9ca2f16' have merged, the current hns3
>>>> pmd driver can not be directly complied on the kunpeng920
>>>> server board. Therefore, we need to fix the meson build.
>>>> Besides, add kunpeng 920 SoC meson cross compile target.
>>>>
>>>> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
>>>
>>> Why do you think this patch is fixing the one above?
>>> It looks just a new config, not a fix. Am I missing something?
>>>
>> I'm sorry to see you so late. In the meantime, we are celebrating the
>> Spring Festival. This patch fixes the problem. If the patch is not
>> added, the latest version cannot be directly compiled on the Kunpeng 930
>> server board.In addition, the cross compilation configuration file is added.
> 
> Please can you explain what was removed which breaks your compilation?
> 
I understand that implementation_id is identified in 9ca2f16. If the 
configuration file does not contain implementation_id, it will be 
displayed as unsupported.

The error as follows:
config/arm/meson.build:227:2: ERROR: Problem encountered: Unsupported 
Arm implementer: 0x48. Please add support for it or use the generic 
(-Dmachine=generic) build.

Besides, we use the -Dmachine=generic, the bug is not resolved.
the cmd as:
  meson build or meson -Dmachine=generic build
> 
> .
> 

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
  2021-02-24  9:17         ` oulijun
@ 2021-02-24 10:24           ` Thomas Monjalon
  0 siblings, 0 replies; 45+ messages in thread
From: Thomas Monjalon @ 2021-02-24 10:24 UTC (permalink / raw)
  To: oulijun; +Cc: ferruh.yigit, dev, linuxarm, juraj.linkes, bruce.richardson

24/02/2021 10:17, oulijun:
> 
> 在 2021/2/24 15:41, Thomas Monjalon 写道:
> > 24/02/2021 02:34, oulijun:
> >>
> >> 在 2021/2/10 17:41, Thomas Monjalon 写道:
> >>> 03/02/2021 13:46, Lijun Ou:
> >>>> From: Chengchang Tang <tangchengchang@huawei.com>
> >>>>
> >>>> Because of the '9ca2f16' have merged, the current hns3
> >>>> pmd driver can not be directly complied on the kunpeng920
> >>>> server board. Therefore, we need to fix the meson build.
> >>>> Besides, add kunpeng 920 SoC meson cross compile target.
> >>>>
> >>>> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
> >>>
> >>> Why do you think this patch is fixing the one above?
> >>> It looks just a new config, not a fix. Am I missing something?
> >>>
> >> I'm sorry to see you so late. In the meantime, we are celebrating the
> >> Spring Festival. This patch fixes the problem. If the patch is not
> >> added, the latest version cannot be directly compiled on the Kunpeng 930
> >> server board.In addition, the cross compilation configuration file is added.
> > 
> > Please can you explain what was removed which breaks your compilation?
> > 
> I understand that implementation_id is identified in 9ca2f16. If the 
> configuration file does not contain implementation_id, it will be 
> displayed as unsupported.
> 
> The error as follows:
> config/arm/meson.build:227:2: ERROR: Problem encountered: Unsupported 
> Arm implementer: 0x48. Please add support for it or use the generic 
> (-Dmachine=generic) build.
> 
> Besides, we use the -Dmachine=generic, the bug is not resolved.
> the cmd as:
>   meson build or meson -Dmachine=generic build

What is the result of a generic build?






^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
  2021-02-24  7:41       ` Thomas Monjalon
  2021-02-24  9:17         ` oulijun
@ 2021-02-24 11:55         ` Juraj Linkeš
  2021-02-24 12:09           ` Thomas Monjalon
  1 sibling, 1 reply; 45+ messages in thread
From: Juraj Linkeš @ 2021-02-24 11:55 UTC (permalink / raw)
  To: Thomas Monjalon, oulijun; +Cc: ferruh.yigit, dev, linuxarm



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> Sent: Wednesday, February 24, 2021 8:42 AM
> To: oulijun <oulijun@huawei.com>
> Cc: ferruh.yigit@intel.com; dev@dpdk.org; linuxarm@openeuler.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC
> build
> 
> 24/02/2021 02:34, oulijun:
> >
> > 在 2021/2/10 17:41, Thomas Monjalon 写道:
> > > 03/02/2021 13:46, Lijun Ou:
> > >> From: Chengchang Tang <tangchengchang@huawei.com>
> > >>
> > >> Because of the '9ca2f16' have merged, the current hns3 pmd driver
> > >> can not be directly complied on the kunpeng920 server board.
> > >> Therefore, we need to fix the meson build.
> > >> Besides, add kunpeng 920 SoC meson cross compile target.
> > >>
> > >> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
> > >
> > > Why do you think this patch is fixing the one above?
> > > It looks just a new config, not a fix. Am I missing something?
> > >
> > I'm sorry to see you so late. In the meantime, we are celebrating the
> > Spring Festival. This patch fixes the problem. If the patch is not
> > added, the latest version cannot be directly compiled on the Kunpeng
> > 930 server board.In addition, the cross compilation configuration file is added.
> 
> Please can you explain what was removed which breaks your compilation?
> 
> 

I can explain what's changed and why we changed it.

The previous behavior was that when an uknown implementer was found (when we're building on an uknown build machine) we fell back to a generic build.
The current behavior is we raise an error when building on an unknown build machine and inform the user about the generic build (there's an error in the message, it should be -Dmachine=default instead of -Dmachine=generic). Lijun came across this scenario, so he wants to add an implementer, but it is not a fix, rather an addition that we wanted to encourage when we changed the behavior. The change in behavior also has an additional benefit in that it notifies the user that meson is not doing a tailored build for the build machine and the only permissible build is the generic one.

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
  2021-02-24 11:55         ` Juraj Linkeš
@ 2021-02-24 12:09           ` Thomas Monjalon
  2021-03-01 10:46             ` Juraj Linkeš
  0 siblings, 1 reply; 45+ messages in thread
From: Thomas Monjalon @ 2021-02-24 12:09 UTC (permalink / raw)
  To: Juraj Linkeš; +Cc: oulijun, ferruh.yigit, dev, linuxarm

24/02/2021 12:55, Juraj Linkeš:
> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> > 24/02/2021 02:34, oulijun:
> > >
> > > 在 2021/2/10 17:41, Thomas Monjalon 写道:
> > > > 03/02/2021 13:46, Lijun Ou:
> > > >> From: Chengchang Tang <tangchengchang@huawei.com>
> > > >>
> > > >> Because of the '9ca2f16' have merged, the current hns3 pmd driver
> > > >> can not be directly complied on the kunpeng920 server board.
> > > >> Therefore, we need to fix the meson build.
> > > >> Besides, add kunpeng 920 SoC meson cross compile target.
> > > >>
> > > >> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
> > > >
> > > > Why do you think this patch is fixing the one above?
> > > > It looks just a new config, not a fix. Am I missing something?
> > > >
> > > I'm sorry to see you so late. In the meantime, we are celebrating the
> > > Spring Festival. This patch fixes the problem. If the patch is not
> > > added, the latest version cannot be directly compiled on the Kunpeng
> > > 930 server board.In addition, the cross compilation configuration file is added.
> > 
> > Please can you explain what was removed which breaks your compilation?
> > 
> 
> I can explain what's changed and why we changed it.
> 
> The previous behavior was that when an uknown implementer was found (when we're building on an uknown build machine) we fell back to a generic build.
> The current behavior is we raise an error when building on an unknown build machine and inform the user about the generic build (there's an error in the message, it should be -Dmachine=default instead of -Dmachine=generic). Lijun came across this scenario, so he wants to add an implementer, but it is not a fix, rather an addition that we wanted to encourage when we changed the behavior. The change in behavior also has an additional benefit in that it notifies the user that meson is not doing a tailored build for the build machine and the only permissible build is the generic one.

There were already many fixes for that rework.
Please check if there are other missing updates.




^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
  2021-02-24 12:09           ` Thomas Monjalon
@ 2021-03-01 10:46             ` Juraj Linkeš
  2021-03-05  1:36               ` oulijun
  0 siblings, 1 reply; 45+ messages in thread
From: Juraj Linkeš @ 2021-03-01 10:46 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: oulijun, ferruh.yigit, dev, linuxarm



> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, February 24, 2021 1:10 PM
> To: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Cc: oulijun <oulijun@huawei.com>; ferruh.yigit@intel.com; dev@dpdk.org;
> linuxarm@openeuler.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC
> build
> 
> 24/02/2021 12:55, Juraj Linkeš:
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> > > 24/02/2021 02:34, oulijun:
> > > >
> > > > 在 2021/2/10 17:41, Thomas Monjalon 写道:
> > > > > 03/02/2021 13:46, Lijun Ou:
> > > > >> From: Chengchang Tang <tangchengchang@huawei.com>
> > > > >>
> > > > >> Because of the '9ca2f16' have merged, the current hns3 pmd
> > > > >> driver can not be directly complied on the kunpeng920 server board.
> > > > >> Therefore, we need to fix the meson build.
> > > > >> Besides, add kunpeng 920 SoC meson cross compile target.
> > > > >>
> > > > >> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
> > > > >
> > > > > Why do you think this patch is fixing the one above?
> > > > > It looks just a new config, not a fix. Am I missing something?
> > > > >
> > > > I'm sorry to see you so late. In the meantime, we are celebrating
> > > > the Spring Festival. This patch fixes the problem. If the patch is
> > > > not added, the latest version cannot be directly compiled on the
> > > > Kunpeng
> > > > 930 server board.In addition, the cross compilation configuration file is
> added.
> > >
> > > Please can you explain what was removed which breaks your compilation?
> > >
> >
> > I can explain what's changed and why we changed it.
> >
> > The previous behavior was that when an uknown implementer was found
> (when we're building on an uknown build machine) we fell back to a generic
> build.
> > The current behavior is we raise an error when building on an unknown build
> machine and inform the user about the generic build (there's an error in the
> message, it should be -Dmachine=default instead of -Dmachine=generic). Lijun
> came across this scenario, so he wants to add an implementer, but it is not a fix,
> rather an addition that we wanted to encourage when we changed the
> behavior. The change in behavior also has an additional benefit in that it notifies
> the user that meson is not doing a tailored build for the build machine and the
> only permissible build is the generic one.
> 
> There were already many fixes for that rework.
> Please check if there are other missing updates.
> 

This is actually the first mistake that my testing missed. I tested that the message is properly emitted, but I didn't test the message after we extracted the default->generic rename patch. As a side note, we could address this issue with http://patches.dpdk.org/project/dpdk/patch/1613657555-17683-1-git-send-email-juraj.linkes@pantheon.tech/ - then we can leave the message in place as is (with -Dmachine=generic).

I went through all of the patches again but I didn't find anything that needs addressing.

As far as I'm aware, there were two other fixes for the series. One was a failure of communication (the native margs fix - I implemented what we thought we agreed on) and the other is not really a fix, just the addition of one implementer configuration (I removed the implementer because we didn't have its configuration). The clang cross-compile fixes are related, but those are the problem with that series, not the rework series.

> 
> 


^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
  2021-03-01 10:46             ` Juraj Linkeš
@ 2021-03-05  1:36               ` oulijun
  2021-03-22  1:01                 ` Min Hu (Connor)
  0 siblings, 1 reply; 45+ messages in thread
From: oulijun @ 2021-03-05  1:36 UTC (permalink / raw)
  To: Juraj Linkeš, Thomas Monjalon; +Cc: ferruh.yigit, dev, linuxarm



在 2021/3/1 18:46, Juraj Linkeš 写道:
> 
> 
>> -----Original Message-----
>> From: Thomas Monjalon <thomas@monjalon.net>
>> Sent: Wednesday, February 24, 2021 1:10 PM
>> To: Juraj Linkeš <juraj.linkes@pantheon.tech>
>> Cc: oulijun <oulijun@huawei.com>; ferruh.yigit@intel.com; dev@dpdk.org;
>> linuxarm@openeuler.org
>> Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC
>> build
>>
>> 24/02/2021 12:55, Juraj Linkeš:
>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
>>>> 24/02/2021 02:34, oulijun:
>>>>>
>>>>> 在 2021/2/10 17:41, Thomas Monjalon 写道:
>>>>>> 03/02/2021 13:46, Lijun Ou:
>>>>>>> From: Chengchang Tang <tangchengchang@huawei.com>
>>>>>>>
>>>>>>> Because of the '9ca2f16' have merged, the current hns3 pmd
>>>>>>> driver can not be directly complied on the kunpeng920 server board.
>>>>>>> Therefore, we need to fix the meson build.
>>>>>>> Besides, add kunpeng 920 SoC meson cross compile target.
>>>>>>>
>>>>>>> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
>>>>>>
>>>>>> Why do you think this patch is fixing the one above?
>>>>>> It looks just a new config, not a fix. Am I missing something?
>>>>>>
>>>>> I'm sorry to see you so late. In the meantime, we are celebrating
>>>>> the Spring Festival. This patch fixes the problem. If the patch is
>>>>> not added, the latest version cannot be directly compiled on the
>>>>> Kunpeng
>>>>> 930 server board.In addition, the cross compilation configuration file is
>> added.
>>>>
>>>> Please can you explain what was removed which breaks your compilation?
>>>>
>>>
>>> I can explain what's changed and why we changed it.
>>>
>>> The previous behavior was that when an uknown implementer was found
>> (when we're building on an uknown build machine) we fell back to a generic
>> build.
>>> The current behavior is we raise an error when building on an unknown build
>> machine and inform the user about the generic build (there's an error in the
>> message, it should be -Dmachine=default instead of -Dmachine=generic). Lijun
>> came across this scenario, so he wants to add an implementer, but it is not a fix,
>> rather an addition that we wanted to encourage when we changed the
>> behavior. The change in behavior also has an additional benefit in that it notifies
>> the user that meson is not doing a tailored build for the build machine and the
>> only permissible build is the generic one.
>>
>> There were already many fixes for that rework.
>> Please check if there are other missing updates.
>>
> 
> This is actually the first mistake that my testing missed. I tested that the message is properly emitted, but I didn't test the message after we extracted the default->generic rename patch. As a side note, we could address this issue with http://patches.dpdk.org/project/dpdk/patch/1613657555-17683-1-git-send-email-juraj.linkes@pantheon.tech/ - then we can leave the message in place as is (with -Dmachine=generic).
> 
> I went through all of the patches again but I didn't find anything that needs addressing.
> 
> As far as I'm aware, there were two other fixes for the series. One was a failure of communication (the native margs fix - I implemented what we thought we agreed on) and the other is not really a fix, just the addition of one implementer configuration (I removed the implementer because we didn't have its configuration). The clang cross-compile fixes are related, but those are the problem with that series, not the rework series.
> 
Hi,
   the patch 
http://patches.dpdk.org/project/dpdk/patch/1613657555-17683-1-git-send-email-juraj.linkes@pantheon.tech/
will this patch be incorporated? We have realized this problem and fixed 
it in the internal version.
>>
>>
> 

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH 0/2] meson build fixes for hns3
  2021-02-03 12:46 [dpdk-dev] [PATCH 0/2] meson build fixes for hns3 Lijun Ou
  2021-02-03 12:46 ` [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build Lijun Ou
  2021-02-03 12:46 ` [dpdk-dev] [PATCH 2/2] config/arm: fix Hisilicon kunpeng930 Soc build Lijun Ou
@ 2021-03-05  1:38 ` oulijun
  2021-03-10  1:35 ` [dpdk-dev] [PATCH V2 0/4] add Hisilicon kunpeng CPU support Lijun Ou
       [not found] ` <6032863.io6GlxzLMq@thomas>
  4 siblings, 0 replies; 45+ messages in thread
From: oulijun @ 2021-03-05  1:38 UTC (permalink / raw)
  To: dev

Hi, Thomas Monjalon && Ferruh
   Is the patchset used for integration or resending? What's your opinion?

Thanks
Lijun Ou

在 2021/2/3 20:46, Lijun Ou 写道:
> This series fix meson build for kunpeng920 and
> kunpeng930 boards.
> 
> Chengchang Tang (2):
>    config/arm: fix Hisilicon kunpeng920 SoC build
>    config/arm: fix Hisilicon kunpeng930 Soc build
> 
>   config/arm/arm64_kunpeng920_linux_gcc              | 19 +++++++++++++++
>   config/arm/arm64_kunpeng930_linux_gcc              | 19 +++++++++++++++
>   config/arm/meson.build                             | 27 ++++++++++++++++++++++
>   .../linux_gsg/cross_build_dpdk_for_arm64.rst       |  5 ++++
>   4 files changed, 70 insertions(+)
>   create mode 100644 config/arm/arm64_kunpeng920_linux_gcc
>   create mode 100644 config/arm/arm64_kunpeng930_linux_gcc
> 

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [dpdk-dev] [PATCH V2 0/4] add Hisilicon kunpeng CPU support
  2021-02-03 12:46 [dpdk-dev] [PATCH 0/2] meson build fixes for hns3 Lijun Ou
                   ` (2 preceding siblings ...)
  2021-03-05  1:38 ` [dpdk-dev] [PATCH 0/2] meson build fixes for hns3 oulijun
@ 2021-03-10  1:35 ` Lijun Ou
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer Lijun Ou
                     ` (4 more replies)
       [not found] ` <6032863.io6GlxzLMq@thomas>
  4 siblings, 5 replies; 45+ messages in thread
From: Lijun Ou @ 2021-03-10  1:35 UTC (permalink / raw)
  To: thomas, ferruh.yigit; +Cc: dev, linuxarm

This series add meson build for Hisilicon kunpeng CPU.

Lijun Ou (4):
  config/arm: add Hisilicon kunpeng920 implementer
  config/arm: add Hisilicon kunpeng930 implementer
  config/arm: add kunpeng920 meson cross compile target
  config/arm: add kunpeng930 meson cross compile target

 config/arm/arm64_kunpeng920_linux_gcc              | 19 +++++++++++++++
 config/arm/arm64_kunpeng930_linux_gcc              | 19 +++++++++++++++
 config/arm/meson.build                             | 27 ++++++++++++++++++++++
 .../linux_gsg/cross_build_dpdk_for_arm64.rst       |  5 ++++
 4 files changed, 70 insertions(+)
 create mode 100644 config/arm/arm64_kunpeng920_linux_gcc
 create mode 100644 config/arm/arm64_kunpeng930_linux_gcc

-- 
2.7.4


^ permalink raw reply	[flat|nested] 45+ messages in thread

* [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
  2021-03-10  1:35 ` [dpdk-dev] [PATCH V2 0/4] add Hisilicon kunpeng CPU support Lijun Ou
@ 2021-03-10  1:35   ` Lijun Ou
  2021-03-20  2:27     ` Min Hu (Connor)
                       ` (2 more replies)
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 2/4] config/arm: add Hisilicon kunpeng930 implementer Lijun Ou
                     ` (3 subsequent siblings)
  4 siblings, 3 replies; 45+ messages in thread
From: Lijun Ou @ 2021-03-10  1:35 UTC (permalink / raw)
  To: thomas, ferruh.yigit; +Cc: dev, linuxarm

Here addes Kunpeng920 config back which was deleted.

Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")

Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
V1->V2:
- rewrite patch title.
- split the patch into two.
---
 config/arm/meson.build | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 00bc461..3826900 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -133,6 +133,25 @@ implementer_cavium = {
 	}
 }
 
+implementer_hisilicon = {
+	'description': 'Hisilicon',
+	'flags': [
+		['RTE_USE_C11_MEM_MODEL', true],
+		['RTE_CACHE_LINE_SIZE', 128],
+		['RTE_MAX_NUMA_NODES', 4]
+	],
+	'part_number_config': {
+		'0xd01': {
+			'machine_args': ['-march=armv8.2-a+crypto',
+					 '-mtune=tsv110'],
+			'flag': [['RTE_MACHINE', '"kunpeng920"'],
+				 ['RTE_MAX_LCORE', 128],
+				 ['RTE_ARM_FEATURE_ATOMICS', true]
+			]
+		}
+	}
+}
+
 implementer_ampere = {
 	'description': 'Ampere Computing',
 	'flags': [
@@ -190,6 +209,7 @@ implementers = {
 	'generic': implementer_generic,
 	'0x41': implementer_arm,
 	'0x43': implementer_cavium,
+	'0x48': implementer_hisilicon,
 	'0x50': implementer_ampere,
 	'0x51': implementer_qualcomm,
 	'0x56': implementer_marvell,
-- 
2.7.4


^ permalink raw reply	[flat|nested] 45+ messages in thread

* [dpdk-dev] [PATCH V2 2/4] config/arm: add Hisilicon kunpeng930 implementer
  2021-03-10  1:35 ` [dpdk-dev] [PATCH V2 0/4] add Hisilicon kunpeng CPU support Lijun Ou
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer Lijun Ou
@ 2021-03-10  1:35   ` Lijun Ou
  2021-03-26 12:42     ` Jerin Jacob
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 3/4] config/arm: add kunpeng920 meson cross compile target Lijun Ou
                     ` (2 subsequent siblings)
  4 siblings, 1 reply; 45+ messages in thread
From: Lijun Ou @ 2021-03-10  1:35 UTC (permalink / raw)
  To: thomas, ferruh.yigit; +Cc: dev, linuxarm

Here add Hisilicon kunpeng930 config back which was deleted.

Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")

Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
-rewrite the patch title.
-split the patch into two.
---
 config/arm/meson.build | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 3826900..a3f42c3 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -148,6 +148,13 @@ implementer_hisilicon = {
 				 ['RTE_MAX_LCORE', 128],
 				 ['RTE_ARM_FEATURE_ATOMICS', true]
 			]
+		},
+		'0xd02': {
+			'machine_args': ['-march=armv8.2-a+crypto+sve'],
+			'flag': [['RTE_MACHINE', '"kunpeng930"'],
+				 ['RTE_MAX_LCORE', 256],
+				 ['RTE_ARM_FEATURE_ATOMICS', true]
+			]
 		}
 	}
 }
-- 
2.7.4


^ permalink raw reply	[flat|nested] 45+ messages in thread

* [dpdk-dev] [PATCH V2 3/4] config/arm: add kunpeng920 meson cross compile target
  2021-03-10  1:35 ` [dpdk-dev] [PATCH V2 0/4] add Hisilicon kunpeng CPU support Lijun Ou
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer Lijun Ou
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 2/4] config/arm: add Hisilicon kunpeng930 implementer Lijun Ou
@ 2021-03-10  1:35   ` Lijun Ou
  2021-03-25  7:48     ` Ruifeng Wang
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 4/4] config/arm: add kunpeng930 " Lijun Ou
  2021-03-27  1:27   ` [dpdk-dev] [PATCH V3 0/3] add Hisilicon kunpeng CPU support Lijun Ou
  4 siblings, 1 reply; 45+ messages in thread
From: Lijun Ou @ 2021-03-10  1:35 UTC (permalink / raw)
  To: thomas, ferruh.yigit; +Cc: dev, linuxarm

Here add arm64 cross compile support for Hisilicon kunpeng920.

Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
 config/arm/arm64_kunpeng920_linux_gcc               | 19 +++++++++++++++++++
 doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst |  4 ++++
 2 files changed, 23 insertions(+)
 create mode 100644 config/arm/arm64_kunpeng920_linux_gcc

diff --git a/config/arm/arm64_kunpeng920_linux_gcc b/config/arm/arm64_kunpeng920_linux_gcc
new file mode 100644
index 0000000..3eeb2e9
--- /dev/null
+++ b/config/arm/arm64_kunpeng920_linux_gcc
@@ -0,0 +1,19 @@
+[binaries]
+c = 'aarch64-linux-gnu-gcc'
+cpp = 'aarch64-linux-gnu-cpp'
+ar = 'aarch64-linux-gnu-gcc-ar'
+strip = 'aarch64-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+implementer_id = '0x48'
+part_number = '0xd01'
+max_lcores = 128
+max_numa_nodes = 4
diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
index faaf24b..afe4f8e 100644
--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
@@ -197,6 +197,7 @@ you may use various combinations of implementer/part number::
       'generic': Generic armv8
       '0x41':    Arm
       '0x43':    Cavium
+      '0x48':    Hisilicon
       '0x50':    Ampere Computing
       '0x56':    Marvell ARMADA
       'dpaa':    NXP DPAA
@@ -219,6 +220,9 @@ you may use various combinations of implementer/part number::
       '0xaf':    thunderx2t99
       '0xb2':    octeontx2
 
+   Supported part_numbers for 0x48:
+      '0xd01':    kunpeng920
+
    Supported part_numbers for 0x50:
       '0x0':     emag
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 45+ messages in thread

* [dpdk-dev] [PATCH V2 4/4] config/arm: add kunpeng930 meson cross compile target
  2021-03-10  1:35 ` [dpdk-dev] [PATCH V2 0/4] add Hisilicon kunpeng CPU support Lijun Ou
                     ` (2 preceding siblings ...)
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 3/4] config/arm: add kunpeng920 meson cross compile target Lijun Ou
@ 2021-03-10  1:35   ` Lijun Ou
  2021-03-25  7:49     ` Ruifeng Wang
  2021-03-26 12:46     ` Jerin Jacob
  2021-03-27  1:27   ` [dpdk-dev] [PATCH V3 0/3] add Hisilicon kunpeng CPU support Lijun Ou
  4 siblings, 2 replies; 45+ messages in thread
From: Lijun Ou @ 2021-03-10  1:35 UTC (permalink / raw)
  To: thomas, ferruh.yigit; +Cc: dev, linuxarm

Here add arm64 cross compile support for Hisilicon kunpeng930.

Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
 config/arm/arm64_kunpeng930_linux_gcc               | 19 +++++++++++++++++++
 doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 config/arm/arm64_kunpeng930_linux_gcc

diff --git a/config/arm/arm64_kunpeng930_linux_gcc b/config/arm/arm64_kunpeng930_linux_gcc
new file mode 100644
index 0000000..464e44a
--- /dev/null
+++ b/config/arm/arm64_kunpeng930_linux_gcc
@@ -0,0 +1,19 @@
+[binaries]
+c = 'aarch64-linux-gnu-gcc'
+cpp = 'aarch64-linux-gnu-cpp'
+ar = 'aarch64-linux-gnu-gcc-ar'
+strip = 'aarch64-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+implementer_id = '0x48'
+part_number = '0xd02'
+max_lcores = 256
+max_numa_nodes = 4
diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
index afe4f8e..1a54436 100644
--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
@@ -222,6 +222,7 @@ you may use various combinations of implementer/part number::
 
    Supported part_numbers for 0x48:
       '0xd01':    kunpeng920
+      '0xd02':    kunpeng930
 
    Supported part_numbers for 0x50:
       '0x0':     emag
-- 
2.7.4


^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer Lijun Ou
@ 2021-03-20  2:27     ` Min Hu (Connor)
  2021-03-23  8:07     ` Ruifeng Wang
  2021-03-26 12:40     ` Jerin Jacob
  2 siblings, 0 replies; 45+ messages in thread
From: Min Hu (Connor) @ 2021-03-20  2:27 UTC (permalink / raw)
  To: dev


Hi, all,
	have any comments about this set of patches?
	thanks.

在 2021/3/10 9:35, Lijun Ou 写道:
> Here addes Kunpeng920 config back which was deleted.
> 
> Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")
> 
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
> V1->V2:
> - rewrite patch title.
> - split the patch into two.
> ---
>   config/arm/meson.build | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 00bc461..3826900 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -133,6 +133,25 @@ implementer_cavium = {
>   	}
>   }
>   
> +implementer_hisilicon = {
> +	'description': 'Hisilicon',
> +	'flags': [
> +		['RTE_USE_C11_MEM_MODEL', true],
> +		['RTE_CACHE_LINE_SIZE', 128],
> +		['RTE_MAX_NUMA_NODES', 4]
> +	],
> +	'part_number_config': {
> +		'0xd01': {
> +			'machine_args': ['-march=armv8.2-a+crypto',
> +					 '-mtune=tsv110'],
> +			'flag': [['RTE_MACHINE', '"kunpeng920"'],
> +				 ['RTE_MAX_LCORE', 128],
> +				 ['RTE_ARM_FEATURE_ATOMICS', true]
> +			]
> +		}
> +	}
> +}
> +
>   implementer_ampere = {
>   	'description': 'Ampere Computing',
>   	'flags': [
> @@ -190,6 +209,7 @@ implementers = {
>   	'generic': implementer_generic,
>   	'0x41': implementer_arm,
>   	'0x43': implementer_cavium,
> +	'0x48': implementer_hisilicon,
>   	'0x50': implementer_ampere,
>   	'0x51': implementer_qualcomm,
>   	'0x56': implementer_marvell,
> 

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
  2021-03-05  1:36               ` oulijun
@ 2021-03-22  1:01                 ` Min Hu (Connor)
  0 siblings, 0 replies; 45+ messages in thread
From: Min Hu (Connor) @ 2021-03-22  1:01 UTC (permalink / raw)
  To: oulijun, Juraj Linkeš, Thomas Monjalon; +Cc: ferruh.yigit, dev, linuxarm

Hi, all,
	any comments for this patch?
	Hope for your reply.
	Thanks.


在 2021/3/5 9:36, oulijun 写道:
> 
> 
> 在 2021/3/1 18:46, Juraj Linkeš 写道:
>>
>>
>>> -----Original Message-----
>>> From: Thomas Monjalon <thomas@monjalon.net>
>>> Sent: Wednesday, February 24, 2021 1:10 PM
>>> To: Juraj Linkeš <juraj.linkes@pantheon.tech>
>>> Cc: oulijun <oulijun@huawei.com>; ferruh.yigit@intel.com; dev@dpdk.org;
>>> linuxarm@openeuler.org
>>> Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon 
>>> kunpeng920 SoC
>>> build
>>>
>>> 24/02/2021 12:55, Juraj Linkeš:
>>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
>>>>> 24/02/2021 02:34, oulijun:
>>>>>>
>>>>>> 在 2021/2/10 17:41, Thomas Monjalon 写道:
>>>>>>> 03/02/2021 13:46, Lijun Ou:
>>>>>>>> From: Chengchang Tang <tangchengchang@huawei.com>
>>>>>>>>
>>>>>>>> Because of the '9ca2f16' have merged, the current hns3 pmd
>>>>>>>> driver can not be directly complied on the kunpeng920 server board.
>>>>>>>> Therefore, we need to fix the meson build.
>>>>>>>> Besides, add kunpeng 920 SoC meson cross compile target.
>>>>>>>>
>>>>>>>> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
>>>>>>>
>>>>>>> Why do you think this patch is fixing the one above?
>>>>>>> It looks just a new config, not a fix. Am I missing something?
>>>>>>>
>>>>>> I'm sorry to see you so late. In the meantime, we are celebrating
>>>>>> the Spring Festival. This patch fixes the problem. If the patch is
>>>>>> not added, the latest version cannot be directly compiled on the
>>>>>> Kunpeng
>>>>>> 930 server board.In addition, the cross compilation configuration 
>>>>>> file is
>>> added.
>>>>>
>>>>> Please can you explain what was removed which breaks your compilation?
>>>>>
>>>>
>>>> I can explain what's changed and why we changed it.
>>>>
>>>> The previous behavior was that when an uknown implementer was found
>>> (when we're building on an uknown build machine) we fell back to a 
>>> generic
>>> build.
>>>> The current behavior is we raise an error when building on an 
>>>> unknown build
>>> machine and inform the user about the generic build (there's an error 
>>> in the
>>> message, it should be -Dmachine=default instead of 
>>> -Dmachine=generic). Lijun
>>> came across this scenario, so he wants to add an implementer, but it 
>>> is not a fix,
>>> rather an addition that we wanted to encourage when we changed the
>>> behavior. The change in behavior also has an additional benefit in 
>>> that it notifies
>>> the user that meson is not doing a tailored build for the build 
>>> machine and the
>>> only permissible build is the generic one.
>>>
>>> There were already many fixes for that rework.
>>> Please check if there are other missing updates.
>>>
>>
>> This is actually the first mistake that my testing missed. I tested 
>> that the message is properly emitted, but I didn't test the message 
>> after we extracted the default->generic rename patch. As a side note, 
>> we could address this issue with 
>> http://patches.dpdk.org/project/dpdk/patch/1613657555-17683-1-git-send-email-juraj.linkes@pantheon.tech/ 
>> - then we can leave the message in place as is (with -Dmachine=generic).
>>
>> I went through all of the patches again but I didn't find anything 
>> that needs addressing.
>>
>> As far as I'm aware, there were two other fixes for the series. One 
>> was a failure of communication (the native margs fix - I implemented 
>> what we thought we agreed on) and the other is not really a fix, just 
>> the addition of one implementer configuration (I removed the 
>> implementer because we didn't have its configuration). The clang 
>> cross-compile fixes are related, but those are the problem with that 
>> series, not the rework series.
>>
> Hi,
>    the patch 
> http://patches.dpdk.org/project/dpdk/patch/1613657555-17683-1-git-send-email-juraj.linkes@pantheon.tech/ 
> 
> will this patch be incorporated? We have realized this problem and fixed 
> it in the internal version.
>>>
>>>
>>
> .

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer Lijun Ou
  2021-03-20  2:27     ` Min Hu (Connor)
@ 2021-03-23  8:07     ` Ruifeng Wang
  2021-03-23 13:51       ` oulijun
  2021-03-26 12:40     ` Jerin Jacob
  2 siblings, 1 reply; 45+ messages in thread
From: Ruifeng Wang @ 2021-03-23  8:07 UTC (permalink / raw)
  To: Lijun Ou, thomas, ferruh.yigit; +Cc: dev, linuxarm, nd

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
> Sent: Wednesday, March 10, 2021 9:36 AM
> To: thomas@monjalon.net; ferruh.yigit@intel.com
> Cc: dev@dpdk.org; linuxarm@openeuler.org
> Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920
> implementer
> 
> Here addes Kunpeng920 config back which was deleted.
> 
> Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")
> 
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
> V1->V2:
> - rewrite patch title.
> - split the patch into two.
> ---
>  config/arm/meson.build | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> 00bc461..3826900 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -133,6 +133,25 @@ implementer_cavium = {
>  	}
>  }
> 
> +implementer_hisilicon = {
> +	'description': 'Hisilicon',
> +	'flags': [
> +		['RTE_USE_C11_MEM_MODEL', true],
> +		['RTE_CACHE_LINE_SIZE', 128],

Just want to double check.
One Kunpeng920 box I can access have cache line size 64B.

Thanks.
> +		['RTE_MAX_NUMA_NODES', 4]
> +	],
> +	'part_number_config': {
> +		'0xd01': {
> +			'machine_args': ['-march=armv8.2-a+crypto',
> +					 '-mtune=tsv110'],
> +			'flag': [['RTE_MACHINE', '"kunpeng920"'],
> +				 ['RTE_MAX_LCORE', 128],
> +				 ['RTE_ARM_FEATURE_ATOMICS', true]
> +			]
> +		}
> +	}
> +}
> +
>  implementer_ampere = {
>  	'description': 'Ampere Computing',
>  	'flags': [
> @@ -190,6 +209,7 @@ implementers = {
>  	'generic': implementer_generic,
>  	'0x41': implementer_arm,
>  	'0x43': implementer_cavium,
> +	'0x48': implementer_hisilicon,
>  	'0x50': implementer_ampere,
>  	'0x51': implementer_qualcomm,
>  	'0x56': implementer_marvell,
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
  2021-03-23  8:07     ` Ruifeng Wang
@ 2021-03-23 13:51       ` oulijun
  2021-03-23 15:40         ` Ruifeng Wang
  0 siblings, 1 reply; 45+ messages in thread
From: oulijun @ 2021-03-23 13:51 UTC (permalink / raw)
  To: Ruifeng Wang, thomas, ferruh.yigit; +Cc: dev, linuxarm, nd



在 2021/3/23 16:07, Ruifeng Wang 写道:
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
>> Sent: Wednesday, March 10, 2021 9:36 AM
>> To: thomas@monjalon.net; ferruh.yigit@intel.com
>> Cc: dev@dpdk.org; linuxarm@openeuler.org
>> Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920
>> implementer
>>
>> Here addes Kunpeng920 config back which was deleted.
>>
>> Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")
>>
>> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> ---
>> V1->V2:
>> - rewrite patch title.
>> - split the patch into two.
>> ---
>>   config/arm/meson.build | 20 ++++++++++++++++++++
>>   1 file changed, 20 insertions(+)
>>
>> diff --git a/config/arm/meson.build b/config/arm/meson.build index
>> 00bc461..3826900 100644
>> --- a/config/arm/meson.build
>> +++ b/config/arm/meson.build
>> @@ -133,6 +133,25 @@ implementer_cavium = {
>>   	}
>>   }
>>
>> +implementer_hisilicon = {
>> +	'description': 'Hisilicon',
>> +	'flags': [
>> +		['RTE_USE_C11_MEM_MODEL', true],
>> +		['RTE_CACHE_LINE_SIZE', 128],
> 
> Just want to double check.
> One Kunpeng920 box I can access have cache line size 64B.
> 
I have a question, which level does RTE_CACHE_LINE_SIZE refer to? For 
kunpeng920, L1/L2 cache size is 64B,L3 is 128B
> Thanks.
>> +		['RTE_MAX_NUMA_NODES', 4]
>> +	],
>> +	'part_number_config': {
>> +		'0xd01': {
>> +			'machine_args': ['-march=armv8.2-a+crypto',
>> +					 '-mtune=tsv110'],
>> +			'flag': [['RTE_MACHINE', '"kunpeng920"'],
>> +				 ['RTE_MAX_LCORE', 128],
>> +				 ['RTE_ARM_FEATURE_ATOMICS', true]
>> +			]
>> +		}
>> +	}
>> +}
>> +
>>   implementer_ampere = {
>>   	'description': 'Ampere Computing',
>>   	'flags': [
>> @@ -190,6 +209,7 @@ implementers = {
>>   	'generic': implementer_generic,
>>   	'0x41': implementer_arm,
>>   	'0x43': implementer_cavium,
>> +	'0x48': implementer_hisilicon,
>>   	'0x50': implementer_ampere,
>>   	'0x51': implementer_qualcomm,
>>   	'0x56': implementer_marvell,
>> --
>> 2.7.4
> 
> .
> 

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
  2021-03-23 13:51       ` oulijun
@ 2021-03-23 15:40         ` Ruifeng Wang
  2021-03-25  7:21           ` oulijun
  0 siblings, 1 reply; 45+ messages in thread
From: Ruifeng Wang @ 2021-03-23 15:40 UTC (permalink / raw)
  To: oulijun, thomas, ferruh.yigit; +Cc: dev, linuxarm, nd, nd

> -----Original Message-----
> From: oulijun <oulijun@huawei.com>
> Sent: Tuesday, March 23, 2021 9:52 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net;
> ferruh.yigit@intel.com
> Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com>
> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
> kunpeng920 implementer
> 
> 
> 
>    2021/3/23 16:07, Ruifeng Wang д  :
> >> -----Original Message-----
> >> From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
> >> Sent: Wednesday, March 10, 2021 9:36 AM
> >> To: thomas@monjalon.net; ferruh.yigit@intel.com
> >> Cc: dev@dpdk.org; linuxarm@openeuler.org
> >> Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
> >> kunpeng920 implementer
> >>
> >> Here addes Kunpeng920 config back which was deleted.
> >>
> >> Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous
> >> variables")
> >>
> >> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> >> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> >> ---
> >> V1->V2:
> >> - rewrite patch title.
> >> - split the patch into two.
> >> ---
> >>   config/arm/meson.build | 20 ++++++++++++++++++++
> >>   1 file changed, 20 insertions(+)
> >>
> >> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> >> 00bc461..3826900 100644
> >> --- a/config/arm/meson.build
> >> +++ b/config/arm/meson.build
> >> @@ -133,6 +133,25 @@ implementer_cavium = {
> >>   	}
> >>   }
> >>
> >> +implementer_hisilicon = {
> >> +	'description': 'Hisilicon',
> >> +	'flags': [
> >> +		['RTE_USE_C11_MEM_MODEL', true],
> >> +		['RTE_CACHE_LINE_SIZE', 128],
> >
> > Just want to double check.
> > One Kunpeng920 box I can access have cache line size 64B.
> >
> I have a question, which level does RTE_CACHE_LINE_SIZE refer to? For
> kunpeng920, L1/L2 cache size is 64B  L3 is 128B

Got it. 
I think RTE_CACHE_LINE_SIZE is not defined for a certain level of cache.
Data can be prefetched into any level of cache by using different APIs.

> > Thanks.
> >> +		['RTE_MAX_NUMA_NODES', 4]
> >> +	],
> >> +	'part_number_config': {
> >> +		'0xd01': {
> >> +			'machine_args': ['-march=armv8.2-a+crypto',
> >> +					 '-mtune=tsv110'],
> >> +			'flag': [['RTE_MACHINE', '"kunpeng920"'],
> >> +				 ['RTE_MAX_LCORE', 128],
> >> +				 ['RTE_ARM_FEATURE_ATOMICS', true]
> >> +			]
> >> +		}
> >> +	}
> >> +}
> >> +
> >>   implementer_ampere = {
> >>   	'description': 'Ampere Computing',
> >>   	'flags': [
> >> @@ -190,6 +209,7 @@ implementers = {
> >>   	'generic': implementer_generic,
> >>   	'0x41': implementer_arm,
> >>   	'0x43': implementer_cavium,
> >> +	'0x48': implementer_hisilicon,
> >>   	'0x50': implementer_ampere,
> >>   	'0x51': implementer_qualcomm,
> >>   	'0x56': implementer_marvell,
> >> --
> >> 2.7.4
> >
> > .
> >

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
  2021-03-23 15:40         ` Ruifeng Wang
@ 2021-03-25  7:21           ` oulijun
  2021-03-25  7:45             ` Ruifeng Wang
  0 siblings, 1 reply; 45+ messages in thread
From: oulijun @ 2021-03-25  7:21 UTC (permalink / raw)
  To: Ruifeng Wang, thomas, ferruh.yigit; +Cc: dev, linuxarm, nd



在 2021/3/23 23:40, Ruifeng Wang 写道:
>> -----Original Message-----
>> From: oulijun <oulijun@huawei.com>
>> Sent: Tuesday, March 23, 2021 9:52 PM
>> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net;
>> ferruh.yigit@intel.com
>> Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com>
>> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
>> kunpeng920 implementer
>>
>>
>>
>>     2021/3/23 16:07, Ruifeng Wang д  :
>>>> -----Original Message-----
>>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
>>>> Sent: Wednesday, March 10, 2021 9:36 AM
>>>> To: thomas@monjalon.net; ferruh.yigit@intel.com
>>>> Cc: dev@dpdk.org; linuxarm@openeuler.org
>>>> Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
>>>> kunpeng920 implementer
>>>>
>>>> Here addes Kunpeng920 config back which was deleted.
>>>>
>>>> Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous
>>>> variables")
>>>>
>>>> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
>>>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>>>> ---
>>>> V1->V2:
>>>> - rewrite patch title.
>>>> - split the patch into two.
>>>> ---
>>>>    config/arm/meson.build | 20 ++++++++++++++++++++
>>>>    1 file changed, 20 insertions(+)
>>>>
>>>> diff --git a/config/arm/meson.build b/config/arm/meson.build index
>>>> 00bc461..3826900 100644
>>>> --- a/config/arm/meson.build
>>>> +++ b/config/arm/meson.build
>>>> @@ -133,6 +133,25 @@ implementer_cavium = {
>>>>    	}
>>>>    }
>>>>
>>>> +implementer_hisilicon = {
>>>> +	'description': 'Hisilicon',
>>>> +	'flags': [
>>>> +		['RTE_USE_C11_MEM_MODEL', true],
>>>> +		['RTE_CACHE_LINE_SIZE', 128],
>>>
>>> Just want to double check.
>>> One Kunpeng920 box I can access have cache line size 64B.
>>>
>> I have a question, which level does RTE_CACHE_LINE_SIZE refer to? For
>> kunpeng920, L1/L2 cache size is 64B  L3 is 128B
> 
> Got it.
> I think RTE_CACHE_LINE_SIZE is not defined for a certain level of cache.
> Data can be prefetched into any level of cache by using different APIs.
> 
So our current configuration should be fine.
>>> Thanks.
>>>> +		['RTE_MAX_NUMA_NODES', 4]
>>>> +	],
>>>> +	'part_number_config': {
>>>> +		'0xd01': {
>>>> +			'machine_args': ['-march=armv8.2-a+crypto',
>>>> +					 '-mtune=tsv110'],
>>>> +			'flag': [['RTE_MACHINE', '"kunpeng920"'],
>>>> +				 ['RTE_MAX_LCORE', 128],
>>>> +				 ['RTE_ARM_FEATURE_ATOMICS', true]
>>>> +			]
>>>> +		}
>>>> +	}
>>>> +}
>>>> +
>>>>    implementer_ampere = {
>>>>    	'description': 'Ampere Computing',
>>>>    	'flags': [
>>>> @@ -190,6 +209,7 @@ implementers = {
>>>>    	'generic': implementer_generic,
>>>>    	'0x41': implementer_arm,
>>>>    	'0x43': implementer_cavium,
>>>> +	'0x48': implementer_hisilicon,
>>>>    	'0x50': implementer_ampere,
>>>>    	'0x51': implementer_qualcomm,
>>>>    	'0x56': implementer_marvell,
>>>> --
>>>> 2.7.4
>>>
>>> .
>>>

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
  2021-03-25  7:21           ` oulijun
@ 2021-03-25  7:45             ` Ruifeng Wang
  2021-03-25  7:56               ` oulijun
  0 siblings, 1 reply; 45+ messages in thread
From: Ruifeng Wang @ 2021-03-25  7:45 UTC (permalink / raw)
  To: oulijun, thomas, ferruh.yigit; +Cc: dev, linuxarm, nd, nd

> -----Original Message-----
> From: oulijun <oulijun@huawei.com>
> Sent: Thursday, March 25, 2021 3:22 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net;
> ferruh.yigit@intel.com
> Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com>
> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
> kunpeng920 implementer
> 
> 
> 
> 在 2021/3/23 23:40, Ruifeng Wang 写道:
> >> -----Original Message-----
> >> From: oulijun <oulijun@huawei.com>
> >> Sent: Tuesday, March 23, 2021 9:52 PM
> >> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net;
> >> ferruh.yigit@intel.com
> >> Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com>
> >> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
> >> kunpeng920 implementer
> >>
> >>
> >>
> >>     2021/3/23 16:07, Ruifeng Wang д  :
> >>>> -----Original Message-----
> >>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
> >>>> Sent: Wednesday, March 10, 2021 9:36 AM
> >>>> To: thomas@monjalon.net; ferruh.yigit@intel.com
> >>>> Cc: dev@dpdk.org; linuxarm@openeuler.org
> >>>> Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
> >>>> kunpeng920 implementer
> >>>>
> >>>> Here addes Kunpeng920 config back which was deleted.

There was no Kunpeng920 specific config before change 91c730fd4e09.
It would fall back to generic build because the behavior was to do generic build for unknown implementor / part number.

> >>>>
> >>>> Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous
> >>>> variables")
> >>>>
> >>>> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> >>>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> >>>> ---
> >>>> V1->V2:
> >>>> - rewrite patch title.
> >>>> - split the patch into two.
> >>>> ---
> >>>>    config/arm/meson.build | 20 ++++++++++++++++++++
> >>>>    1 file changed, 20 insertions(+)
> >>>>
> >>>> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> >>>> 00bc461..3826900 100644
> >>>> --- a/config/arm/meson.build
> >>>> +++ b/config/arm/meson.build
> >>>> @@ -133,6 +133,25 @@ implementer_cavium = {
> >>>>    	}
> >>>>    }
> >>>>
> >>>> +implementer_hisilicon = {
> >>>> +	'description': 'Hisilicon',
> >>>> +	'flags': [
> >>>> +		['RTE_USE_C11_MEM_MODEL', true],
> >>>> +		['RTE_CACHE_LINE_SIZE', 128],
> >>>
> >>> Just want to double check.
> >>> One Kunpeng920 box I can access have cache line size 64B.
> >>>
> >> I have a question, which level does RTE_CACHE_LINE_SIZE refer to? For
> >> kunpeng920, L1/L2 cache size is 64B  L3 is 128B
> >
> > Got it.
> > I think RTE_CACHE_LINE_SIZE is not defined for a certain level of cache.
> > Data can be prefetched into any level of cache by using different APIs.
> >
> So our current configuration should be fine.

Agree.

> >>> Thanks.
> >>>> +		['RTE_MAX_NUMA_NODES', 4]
> >>>> +	],
> >>>> +	'part_number_config': {
> >>>> +		'0xd01': {
> >>>> +			'machine_args': ['-march=armv8.2-a+crypto',
> >>>> +					 '-mtune=tsv110'],
> >>>> +			'flag': [['RTE_MACHINE', '"kunpeng920"'],
> >>>> +				 ['RTE_MAX_LCORE', 128],
> >>>> +				 ['RTE_ARM_FEATURE_ATOMICS', true]
> >>>> +			]
> >>>> +		}
> >>>> +	}
> >>>> +}
> >>>> +
> >>>>    implementer_ampere = {
> >>>>    	'description': 'Ampere Computing',
> >>>>    	'flags': [
> >>>> @@ -190,6 +209,7 @@ implementers = {
> >>>>    	'generic': implementer_generic,
> >>>>    	'0x41': implementer_arm,
> >>>>    	'0x43': implementer_cavium,
> >>>> +	'0x48': implementer_hisilicon,
> >>>>    	'0x50': implementer_ampere,
> >>>>    	'0x51': implementer_qualcomm,
> >>>>    	'0x56': implementer_marvell,
> >>>> --
> >>>> 2.7.4
> >>>
> >>> .
> >>>

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH V2 3/4] config/arm: add kunpeng920 meson cross compile target
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 3/4] config/arm: add kunpeng920 meson cross compile target Lijun Ou
@ 2021-03-25  7:48     ` Ruifeng Wang
  2021-03-26 12:45       ` Jerin Jacob
  0 siblings, 1 reply; 45+ messages in thread
From: Ruifeng Wang @ 2021-03-25  7:48 UTC (permalink / raw)
  To: Lijun Ou, thomas, ferruh.yigit; +Cc: dev, linuxarm, nd

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
> Sent: Wednesday, March 10, 2021 9:36 AM
> To: thomas@monjalon.net; ferruh.yigit@intel.com
> Cc: dev@dpdk.org; linuxarm@openeuler.org
> Subject: [dpdk-dev] [PATCH V2 3/4] config/arm: add kunpeng920 meson
> cross compile target
> 
> Here add arm64 cross compile support for Hisilicon kunpeng920.
> 
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
>  config/arm/arm64_kunpeng920_linux_gcc               | 19
> +++++++++++++++++++
>  doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst |  4 ++++
>  2 files changed, 23 insertions(+)
>  create mode 100644 config/arm/arm64_kunpeng920_linux_gcc
> 
> diff --git a/config/arm/arm64_kunpeng920_linux_gcc
> b/config/arm/arm64_kunpeng920_linux_gcc
> new file mode 100644
> index 0000000..3eeb2e9
> --- /dev/null
> +++ b/config/arm/arm64_kunpeng920_linux_gcc
> @@ -0,0 +1,19 @@
> +[binaries]
> +c = 'aarch64-linux-gnu-gcc'
> +cpp = 'aarch64-linux-gnu-cpp'
> +ar = 'aarch64-linux-gnu-gcc-ar'
> +strip = 'aarch64-linux-gnu-strip'
> +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> +pcap-config = ''
> +
> +[host_machine]
> +system = 'linux'
> +cpu_family = 'aarch64'
> +cpu = 'armv8-a'
> +endian = 'little'
> +
> +[properties]
> +implementer_id = '0x48'
> +part_number = '0xd01'
> +max_lcores = 128
> +max_numa_nodes = 4
> diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> index faaf24b..afe4f8e 100644
> --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> @@ -197,6 +197,7 @@ you may use various combinations of
> implementer/part number::
>        'generic': Generic armv8
>        '0x41':    Arm
>        '0x43':    Cavium
> +      '0x48':    Hisilicon
>        '0x50':    Ampere Computing
>        '0x56':    Marvell ARMADA
>        'dpaa':    NXP DPAA
> @@ -219,6 +220,9 @@ you may use various combinations of
> implementer/part number::
>        '0xaf':    thunderx2t99
>        '0xb2':    octeontx2
> 
> +   Supported part_numbers for 0x48:
> +      '0xd01':    kunpeng920
> +
>     Supported part_numbers for 0x50:
>        '0x0':     emag
> 
> --
> 2.7.4

Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>


^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH V2 4/4] config/arm: add kunpeng930 meson cross compile target
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 4/4] config/arm: add kunpeng930 " Lijun Ou
@ 2021-03-25  7:49     ` Ruifeng Wang
  2021-03-26 12:46     ` Jerin Jacob
  1 sibling, 0 replies; 45+ messages in thread
From: Ruifeng Wang @ 2021-03-25  7:49 UTC (permalink / raw)
  To: Lijun Ou, thomas, ferruh.yigit; +Cc: dev, linuxarm, nd

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
> Sent: Wednesday, March 10, 2021 9:36 AM
> To: thomas@monjalon.net; ferruh.yigit@intel.com
> Cc: dev@dpdk.org; linuxarm@openeuler.org
> Subject: [dpdk-dev] [PATCH V2 4/4] config/arm: add kunpeng930 meson
> cross compile target
> 
> Here add arm64 cross compile support for Hisilicon kunpeng930.
> 
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
>  config/arm/arm64_kunpeng930_linux_gcc               | 19
> +++++++++++++++++++
>  doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst |  1 +
>  2 files changed, 20 insertions(+)
>  create mode 100644 config/arm/arm64_kunpeng930_linux_gcc
> 
> diff --git a/config/arm/arm64_kunpeng930_linux_gcc
> b/config/arm/arm64_kunpeng930_linux_gcc
> new file mode 100644
> index 0000000..464e44a
> --- /dev/null
> +++ b/config/arm/arm64_kunpeng930_linux_gcc
> @@ -0,0 +1,19 @@
> +[binaries]
> +c = 'aarch64-linux-gnu-gcc'
> +cpp = 'aarch64-linux-gnu-cpp'
> +ar = 'aarch64-linux-gnu-gcc-ar'
> +strip = 'aarch64-linux-gnu-strip'
> +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> +pcap-config = ''
> +
> +[host_machine]
> +system = 'linux'
> +cpu_family = 'aarch64'
> +cpu = 'armv8-a'
> +endian = 'little'
> +
> +[properties]
> +implementer_id = '0x48'
> +part_number = '0xd02'
> +max_lcores = 256
> +max_numa_nodes = 4
> diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> index afe4f8e..1a54436 100644
> --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> @@ -222,6 +222,7 @@ you may use various combinations of
> implementer/part number::
> 
>     Supported part_numbers for 0x48:
>        '0xd01':    kunpeng920
> +      '0xd02':    kunpeng930
> 
>     Supported part_numbers for 0x50:
>        '0x0':     emag
> --
> 2.7.4

Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
  2021-03-25  7:45             ` Ruifeng Wang
@ 2021-03-25  7:56               ` oulijun
  2021-03-25  8:10                 ` Ruifeng Wang
  0 siblings, 1 reply; 45+ messages in thread
From: oulijun @ 2021-03-25  7:56 UTC (permalink / raw)
  To: Ruifeng Wang, thomas, ferruh.yigit; +Cc: dev, linuxarm, nd



在 2021/3/25 15:45, Ruifeng Wang 写道:
>> -----Original Message-----
>> From: oulijun <oulijun@huawei.com>
>> Sent: Thursday, March 25, 2021 3:22 PM
>> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net;
>> ferruh.yigit@intel.com
>> Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com>
>> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
>> kunpeng920 implementer
>>
>>
>>
>> 在 2021/3/23 23:40, Ruifeng Wang 写道:
>>>> -----Original Message-----
>>>> From: oulijun <oulijun@huawei.com>
>>>> Sent: Tuesday, March 23, 2021 9:52 PM
>>>> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net;
>>>> ferruh.yigit@intel.com
>>>> Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com>
>>>> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
>>>> kunpeng920 implementer
>>>>
>>>>
>>>>
>>>>      2021/3/23 16:07, Ruifeng Wang д  :
>>>>>> -----Original Message-----
>>>>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
>>>>>> Sent: Wednesday, March 10, 2021 9:36 AM
>>>>>> To: thomas@monjalon.net; ferruh.yigit@intel.com
>>>>>> Cc: dev@dpdk.org; linuxarm@openeuler.org
>>>>>> Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
>>>>>> kunpeng920 implementer
>>>>>>
>>>>>> Here addes Kunpeng920 config back which was deleted.
> 
> There was no Kunpeng920 specific config before change 91c730fd4e09.
> It would fall back to generic build because the behavior was to do generic build for unknown implementor / part number.
> 
What should we do with this patch? This is because we cannot compile on 
the Kunpeng 920 server without adding generic build.
>>>>>>
>>>>>> Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous
>>>>>> variables")
>>>>>>
>>>>>> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
>>>>>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>>>>>> ---
>>>>>> V1->V2:
>>>>>> - rewrite patch title.
>>>>>> - split the patch into two.
>>>>>> ---
>>>>>>     config/arm/meson.build | 20 ++++++++++++++++++++
>>>>>>     1 file changed, 20 insertions(+)
>>>>>>
>>>>>> diff --git a/config/arm/meson.build b/config/arm/meson.build index
>>>>>> 00bc461..3826900 100644
>>>>>> --- a/config/arm/meson.build
>>>>>> +++ b/config/arm/meson.build
>>>>>> @@ -133,6 +133,25 @@ implementer_cavium = {
>>>>>>     	}
>>>>>>     }
>>>>>>
>>>>>> +implementer_hisilicon = {
>>>>>> +	'description': 'Hisilicon',
>>>>>> +	'flags': [
>>>>>> +		['RTE_USE_C11_MEM_MODEL', true],
>>>>>> +		['RTE_CACHE_LINE_SIZE', 128],
>>>>>
>>>>> Just want to double check.
>>>>> One Kunpeng920 box I can access have cache line size 64B.
>>>>>
>>>> I have a question, which level does RTE_CACHE_LINE_SIZE refer to? For
>>>> kunpeng920, L1/L2 cache size is 64B  L3 is 128B
>>>
>>> Got it.
>>> I think RTE_CACHE_LINE_SIZE is not defined for a certain level of cache.
>>> Data can be prefetched into any level of cache by using different APIs.
>>>
>> So our current configuration should be fine.
> 
> Agree.
> 
>>>>> Thanks.
>>>>>> +		['RTE_MAX_NUMA_NODES', 4]
>>>>>> +	],
>>>>>> +	'part_number_config': {
>>>>>> +		'0xd01': {
>>>>>> +			'machine_args': ['-march=armv8.2-a+crypto',
>>>>>> +					 '-mtune=tsv110'],
>>>>>> +			'flag': [['RTE_MACHINE', '"kunpeng920"'],
>>>>>> +				 ['RTE_MAX_LCORE', 128],
>>>>>> +				 ['RTE_ARM_FEATURE_ATOMICS', true]
>>>>>> +			]
>>>>>> +		}
>>>>>> +	}
>>>>>> +}
>>>>>> +
>>>>>>     implementer_ampere = {
>>>>>>     	'description': 'Ampere Computing',
>>>>>>     	'flags': [
>>>>>> @@ -190,6 +209,7 @@ implementers = {
>>>>>>     	'generic': implementer_generic,
>>>>>>     	'0x41': implementer_arm,
>>>>>>     	'0x43': implementer_cavium,
>>>>>> +	'0x48': implementer_hisilicon,
>>>>>>     	'0x50': implementer_ampere,
>>>>>>     	'0x51': implementer_qualcomm,
>>>>>>     	'0x56': implementer_marvell,
>>>>>> --
>>>>>> 2.7.4
>>>>>
>>>>> .
>>>>>

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
  2021-03-25  7:56               ` oulijun
@ 2021-03-25  8:10                 ` Ruifeng Wang
  0 siblings, 0 replies; 45+ messages in thread
From: Ruifeng Wang @ 2021-03-25  8:10 UTC (permalink / raw)
  To: oulijun, thomas, ferruh.yigit; +Cc: dev, linuxarm, nd, nd

> -----Original Message-----
> From: oulijun <oulijun@huawei.com>
> Sent: Thursday, March 25, 2021 3:56 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net;
> ferruh.yigit@intel.com
> Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com>
> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
> kunpeng920 implementer
> 
> 
> 
> 在 2021/3/25 15:45, Ruifeng Wang 写道:
> >> -----Original Message-----
> >> From: oulijun <oulijun@huawei.com>
> >> Sent: Thursday, March 25, 2021 3:22 PM
> >> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net;
> >> ferruh.yigit@intel.com
> >> Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com>
> >> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
> >> kunpeng920 implementer
> >>
> >>
> >>
> >> 在 2021/3/23 23:40, Ruifeng Wang 写道:
> >>>> -----Original Message-----
> >>>> From: oulijun <oulijun@huawei.com>
> >>>> Sent: Tuesday, March 23, 2021 9:52 PM
> >>>> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net;
> >>>> ferruh.yigit@intel.com
> >>>> Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com>
> >>>> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
> >>>> kunpeng920 implementer
> >>>>
> >>>>
> >>>>
> >>>>      2021/3/23 16:07, Ruifeng Wang д  :
> >>>>>> -----Original Message-----
> >>>>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
> >>>>>> Sent: Wednesday, March 10, 2021 9:36 AM
> >>>>>> To: thomas@monjalon.net; ferruh.yigit@intel.com
> >>>>>> Cc: dev@dpdk.org; linuxarm@openeuler.org
> >>>>>> Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
> >>>>>> kunpeng920 implementer
> >>>>>>
> >>>>>> Here addes Kunpeng920 config back which was deleted.
> >
> > There was no Kunpeng920 specific config before change 91c730fd4e09.
> > It would fall back to generic build because the behavior was to do generic
> build for unknown implementor / part number.
> >
> What should we do with this patch? This is because we cannot compile on
> the Kunpeng 920 server without adding generic build.

I see the need to add config for Kunpeng 920.
IMO, the commit message can be refined. 

With commit message update,
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> >>>>>>
> >>>>>> Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous
> >>>>>> variables")
> >>>>>>
> >>>>>> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> >>>>>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> >>>>>> ---
> >>>>>> V1->V2:
> >>>>>> - rewrite patch title.
> >>>>>> - split the patch into two.
> >>>>>> ---
> >>>>>>     config/arm/meson.build | 20 ++++++++++++++++++++
> >>>>>>     1 file changed, 20 insertions(+)
> >>>>>>
> >>>>>> diff --git a/config/arm/meson.build b/config/arm/meson.build
> >>>>>> index
> >>>>>> 00bc461..3826900 100644
> >>>>>> --- a/config/arm/meson.build
> >>>>>> +++ b/config/arm/meson.build
> >>>>>> @@ -133,6 +133,25 @@ implementer_cavium = {
> >>>>>>     	}
> >>>>>>     }
> >>>>>>
> >>>>>> +implementer_hisilicon = {
> >>>>>> +	'description': 'Hisilicon',
> >>>>>> +	'flags': [
> >>>>>> +		['RTE_USE_C11_MEM_MODEL', true],
> >>>>>> +		['RTE_CACHE_LINE_SIZE', 128],
> >>>>>
> >>>>> Just want to double check.
> >>>>> One Kunpeng920 box I can access have cache line size 64B.
> >>>>>
> >>>> I have a question, which level does RTE_CACHE_LINE_SIZE refer to?
> >>>> For kunpeng920, L1/L2 cache size is 64B  L3 is 128B
> >>>
> >>> Got it.
> >>> I think RTE_CACHE_LINE_SIZE is not defined for a certain level of cache.
> >>> Data can be prefetched into any level of cache by using different APIs.
> >>>
> >> So our current configuration should be fine.
> >
> > Agree.
> >
> >>>>> Thanks.
> >>>>>> +		['RTE_MAX_NUMA_NODES', 4]
> >>>>>> +	],
> >>>>>> +	'part_number_config': {
> >>>>>> +		'0xd01': {
> >>>>>> +			'machine_args': ['-march=armv8.2-a+crypto',
> >>>>>> +					 '-mtune=tsv110'],
> >>>>>> +			'flag': [['RTE_MACHINE', '"kunpeng920"'],
> >>>>>> +				 ['RTE_MAX_LCORE', 128],
> >>>>>> +				 ['RTE_ARM_FEATURE_ATOMICS',
> true]
> >>>>>> +			]
> >>>>>> +		}
> >>>>>> +	}
> >>>>>> +}
> >>>>>> +
> >>>>>>     implementer_ampere = {
> >>>>>>     	'description': 'Ampere Computing',
> >>>>>>     	'flags': [
> >>>>>> @@ -190,6 +209,7 @@ implementers = {
> >>>>>>     	'generic': implementer_generic,
> >>>>>>     	'0x41': implementer_arm,
> >>>>>>     	'0x43': implementer_cavium,
> >>>>>> +	'0x48': implementer_hisilicon,
> >>>>>>     	'0x50': implementer_ampere,
> >>>>>>     	'0x51': implementer_qualcomm,
> >>>>>>     	'0x56': implementer_marvell,
> >>>>>> --
> >>>>>> 2.7.4
> >>>>>
> >>>>> .
> >>>>>

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [Linuxarm] [PATCH V2 0/4] add Hisilicon kunpeng CPU support
       [not found]     ` <6796692.TXxtQ3U2Ta@thomas>
@ 2021-03-25 13:26       ` oulijun
  2021-03-25 14:40         ` Thomas Monjalon
  0 siblings, 1 reply; 45+ messages in thread
From: oulijun @ 2021-03-25 13:26 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: linuxarm, Ferruh Yigit, dev



在 2021/3/25 20:19, Thomas Monjalon 写道:
> 25/03/2021 12:17, oulijun:
>> Ruifeng has reviewed-by. Does anyone else have any comments? Is it
>> necessary to send the V2?
> 
> v2 for what? There is a change?
> 
No. no change.
> 
>> 在 2021/3/25 17:07, Thomas Monjalon 写道:
>>> 25/03/2021 09:54, oulijun:
>>>> Hi, Thomas&&Ferruh
>>>>
>>>> Do I need to send a patchset?
>>>
>>> ???
>>> What do you mean?
>>>
>>>> 在 2021/3/10 9:35, Lijun Ou 写道:
>>>>> This series add meson build for Hisilicon kunpeng CPU.
>>>>>
>>>>> Lijun Ou (4):
>>>>>      config/arm: add Hisilicon kunpeng920 implementer
>>>>>      config/arm: add Hisilicon kunpeng930 implementer
>>>>>      config/arm: add kunpeng920 meson cross compile target
>>>>>      config/arm: add kunpeng930 meson cross compile target
>>>
>>>
>>>
>>> .
>>>
>>
> 
> 
> 
> 
> 
> .
> 

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [Linuxarm] [PATCH V2 0/4] add Hisilicon kunpeng CPU support
  2021-03-25 13:26       ` [dpdk-dev] [Linuxarm] [PATCH V2 0/4] add Hisilicon kunpeng CPU support oulijun
@ 2021-03-25 14:40         ` Thomas Monjalon
  2021-03-26  0:41           ` oulijun
  0 siblings, 1 reply; 45+ messages in thread
From: Thomas Monjalon @ 2021-03-25 14:40 UTC (permalink / raw)
  To: oulijun; +Cc: linuxarm, Ferruh Yigit, dev

25/03/2021 14:26, oulijun:
> 在 2021/3/25 20:19, Thomas Monjalon 写道:
> > 25/03/2021 12:17, oulijun:
> >> Ruifeng has reviewed-by. Does anyone else have any comments? Is it
> >> necessary to send the V2?
> > 
> > v2 for what? There is a change?
> > 
> No. no change.

So why are you asking to send a v2?


> >> 在 2021/3/25 17:07, Thomas Monjalon 写道:
> >>> 25/03/2021 09:54, oulijun:
> >>>> Hi, Thomas&&Ferruh
> >>>>
> >>>> Do I need to send a patchset?
> >>>
> >>> ???
> >>> What do you mean?
> >>>
> >>>> 在 2021/3/10 9:35, Lijun Ou 写道:
> >>>>> This series add meson build for Hisilicon kunpeng CPU.
> >>>>>
> >>>>> Lijun Ou (4):
> >>>>>      config/arm: add Hisilicon kunpeng920 implementer
> >>>>>      config/arm: add Hisilicon kunpeng930 implementer
> >>>>>      config/arm: add kunpeng920 meson cross compile target
> >>>>>      config/arm: add kunpeng930 meson cross compile target




^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [Linuxarm] [PATCH V2 0/4] add Hisilicon kunpeng CPU support
  2021-03-25 14:40         ` Thomas Monjalon
@ 2021-03-26  0:41           ` oulijun
  2021-04-05 19:50             ` Honnappa Nagarahalli
  0 siblings, 1 reply; 45+ messages in thread
From: oulijun @ 2021-03-26  0:41 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: linuxarm, Ferruh Yigit, dev



在 2021/3/25 22:40, Thomas Monjalon 写道:
> 25/03/2021 14:26, oulijun:
>> 在 2021/3/25 20:19, Thomas Monjalon 写道:
>>> 25/03/2021 12:17, oulijun:
>>>> Ruifeng has reviewed-by. Does anyone else have any comments? Is it
>>>> necessary to send the V2?
>>>
>>> v2 for what? There is a change?
>>>
>> No. no change.
> 
> So why are you asking to send a v2?
> 
Sorry. My suggestion is to ask if you need to reset the patch based on 
the latest date. If not, wait for other's reviews and to incorporate the 
patch.
> 
>>>> 在 2021/3/25 17:07, Thomas Monjalon 写道:
>>>>> 25/03/2021 09:54, oulijun:
>>>>>> Hi, Thomas&&Ferruh
>>>>>>
>>>>>> Do I need to send a patchset?
>>>>>
>>>>> ???
>>>>> What do you mean?
>>>>>
>>>>>> 在 2021/3/10 9:35, Lijun Ou 写道:
>>>>>>> This series add meson build for Hisilicon kunpeng CPU.
>>>>>>>
>>>>>>> Lijun Ou (4):
>>>>>>>       config/arm: add Hisilicon kunpeng920 implementer
>>>>>>>       config/arm: add Hisilicon kunpeng930 implementer
>>>>>>>       config/arm: add kunpeng920 meson cross compile target
>>>>>>>       config/arm: add kunpeng930 meson cross compile target
> 
> 
> 
> .
> 

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer Lijun Ou
  2021-03-20  2:27     ` Min Hu (Connor)
  2021-03-23  8:07     ` Ruifeng Wang
@ 2021-03-26 12:40     ` Jerin Jacob
  2 siblings, 0 replies; 45+ messages in thread
From: Jerin Jacob @ 2021-03-26 12:40 UTC (permalink / raw)
  To: Lijun Ou; +Cc: Thomas Monjalon, Ferruh Yigit, dpdk-dev, linuxarm

On Wed, Mar 10, 2021 at 7:05 AM Lijun Ou <oulijun@huawei.com> wrote:
>
> Here addes Kunpeng920 config back which was deleted.

Please fix the commit message.

With commit message update:


Acked-by: Jerin Jacob <jerinj@marvell.com>


>
> Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")
>
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
> V1->V2:
> - rewrite patch title.
> - split the patch into two.
> ---
>  config/arm/meson.build | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 00bc461..3826900 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -133,6 +133,25 @@ implementer_cavium = {
>         }
>  }
>
> +implementer_hisilicon = {
> +       'description': 'Hisilicon',
> +       'flags': [
> +               ['RTE_USE_C11_MEM_MODEL', true],
> +               ['RTE_CACHE_LINE_SIZE', 128],
> +               ['RTE_MAX_NUMA_NODES', 4]
> +       ],
> +       'part_number_config': {
> +               '0xd01': {
> +                       'machine_args': ['-march=armv8.2-a+crypto',
> +                                        '-mtune=tsv110'],
> +                       'flag': [['RTE_MACHINE', '"kunpeng920"'],
> +                                ['RTE_MAX_LCORE', 128],
> +                                ['RTE_ARM_FEATURE_ATOMICS', true]
> +                       ]
> +               }
> +       }
> +}
> +
>  implementer_ampere = {
>         'description': 'Ampere Computing',
>         'flags': [
> @@ -190,6 +209,7 @@ implementers = {
>         'generic': implementer_generic,
>         '0x41': implementer_arm,
>         '0x43': implementer_cavium,
> +       '0x48': implementer_hisilicon,
>         '0x50': implementer_ampere,
>         '0x51': implementer_qualcomm,
>         '0x56': implementer_marvell,
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH V2 2/4] config/arm: add Hisilicon kunpeng930 implementer
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 2/4] config/arm: add Hisilicon kunpeng930 implementer Lijun Ou
@ 2021-03-26 12:42     ` Jerin Jacob
  0 siblings, 0 replies; 45+ messages in thread
From: Jerin Jacob @ 2021-03-26 12:42 UTC (permalink / raw)
  To: Lijun Ou; +Cc: Thomas Monjalon, Ferruh Yigit, dpdk-dev, linuxarm

On Wed, Mar 10, 2021 at 7:05 AM Lijun Ou <oulijun@huawei.com> wrote:
>
> Here add Hisilicon kunpeng930 config back which was deleted.

Please fix the commit message.

I think, 1/4 and 2/4 cab squashed.

With above change:

Acked-by: Jerin Jacob <jerinj@marvell.com>

>
> Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")
>
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
> -rewrite the patch title.
> -split the patch into two.
> ---
>  config/arm/meson.build | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 3826900..a3f42c3 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -148,6 +148,13 @@ implementer_hisilicon = {
>                                  ['RTE_MAX_LCORE', 128],
>                                  ['RTE_ARM_FEATURE_ATOMICS', true]
>                         ]
> +               },
> +               '0xd02': {
> +                       'machine_args': ['-march=armv8.2-a+crypto+sve'],
> +                       'flag': [['RTE_MACHINE', '"kunpeng930"'],
> +                                ['RTE_MAX_LCORE', 256],
> +                                ['RTE_ARM_FEATURE_ATOMICS', true]
> +                       ]
>                 }
>         }
>  }
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH V2 3/4] config/arm: add kunpeng920 meson cross compile target
  2021-03-25  7:48     ` Ruifeng Wang
@ 2021-03-26 12:45       ` Jerin Jacob
  0 siblings, 0 replies; 45+ messages in thread
From: Jerin Jacob @ 2021-03-26 12:45 UTC (permalink / raw)
  To: Ruifeng Wang; +Cc: Lijun Ou, thomas, ferruh.yigit, dev, linuxarm, nd

On Thu, Mar 25, 2021 at 1:18 PM Ruifeng Wang <Ruifeng.Wang@arm.com> wrote:
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
> > Sent: Wednesday, March 10, 2021 9:36 AM
> > To: thomas@monjalon.net; ferruh.yigit@intel.com
> > Cc: dev@dpdk.org; linuxarm@openeuler.org
> > Subject: [dpdk-dev] [PATCH V2 3/4] config/arm: add kunpeng920 meson
> > cross compile target

Suggested title: config/arm: add kunpeng920 cross target


> >
> > Here add arm64 cross compile support for Hisilicon kunpeng920.

Suggested change:

Add support for Hisilicon kunpeng920 cross target.

With the above change:
Acked-by: Jerin Jacob <jerinj@marvell.com>



> >
> > Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> > Signed-off-by: Lijun Ou <oulijun@huawei.com>
> > ---
> >  config/arm/arm64_kunpeng920_linux_gcc               | 19
> > +++++++++++++++++++
> >  doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst |  4 ++++
> >  2 files changed, 23 insertions(+)
> >  create mode 100644 config/arm/arm64_kunpeng920_linux_gcc
> >
> > diff --git a/config/arm/arm64_kunpeng920_linux_gcc
> > b/config/arm/arm64_kunpeng920_linux_gcc
> > new file mode 100644
> > index 0000000..3eeb2e9
> > --- /dev/null
> > +++ b/config/arm/arm64_kunpeng920_linux_gcc
> > @@ -0,0 +1,19 @@
> > +[binaries]
> > +c = 'aarch64-linux-gnu-gcc'
> > +cpp = 'aarch64-linux-gnu-cpp'
> > +ar = 'aarch64-linux-gnu-gcc-ar'
> > +strip = 'aarch64-linux-gnu-strip'
> > +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> > +pcap-config = ''
> > +
> > +[host_machine]
> > +system = 'linux'
> > +cpu_family = 'aarch64'
> > +cpu = 'armv8-a'
> > +endian = 'little'
> > +
> > +[properties]
> > +implementer_id = '0x48'
> > +part_number = '0xd01'
> > +max_lcores = 128
> > +max_numa_nodes = 4
> > diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> > b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> > index faaf24b..afe4f8e 100644
> > --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> > +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> > @@ -197,6 +197,7 @@ you may use various combinations of
> > implementer/part number::
> >        'generic': Generic armv8
> >        '0x41':    Arm
> >        '0x43':    Cavium
> > +      '0x48':    Hisilicon
> >        '0x50':    Ampere Computing
> >        '0x56':    Marvell ARMADA
> >        'dpaa':    NXP DPAA
> > @@ -219,6 +220,9 @@ you may use various combinations of
> > implementer/part number::
> >        '0xaf':    thunderx2t99
> >        '0xb2':    octeontx2
> >
> > +   Supported part_numbers for 0x48:
> > +      '0xd01':    kunpeng920
> > +
> >     Supported part_numbers for 0x50:
> >        '0x0':     emag
> >
> > --
> > 2.7.4
>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [PATCH V2 4/4] config/arm: add kunpeng930 meson cross compile target
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 4/4] config/arm: add kunpeng930 " Lijun Ou
  2021-03-25  7:49     ` Ruifeng Wang
@ 2021-03-26 12:46     ` Jerin Jacob
  1 sibling, 0 replies; 45+ messages in thread
From: Jerin Jacob @ 2021-03-26 12:46 UTC (permalink / raw)
  To: Lijun Ou; +Cc: Thomas Monjalon, Ferruh Yigit, dpdk-dev, linuxarm

On Wed, Mar 10, 2021 at 7:05 AM Lijun Ou <oulijun@huawei.com> wrote:
>
> Here add arm64 cross compile support for Hisilicon kunpeng930.
>
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>

Similar comments to 3/4 patch.
With change:

Acked-by: Jerin Jacob <jerinj@marvell.com>


> ---
>  config/arm/arm64_kunpeng930_linux_gcc               | 19 +++++++++++++++++++
>  doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst |  1 +
>  2 files changed, 20 insertions(+)
>  create mode 100644 config/arm/arm64_kunpeng930_linux_gcc
>
> diff --git a/config/arm/arm64_kunpeng930_linux_gcc b/config/arm/arm64_kunpeng930_linux_gcc
> new file mode 100644
> index 0000000..464e44a
> --- /dev/null
> +++ b/config/arm/arm64_kunpeng930_linux_gcc
> @@ -0,0 +1,19 @@
> +[binaries]
> +c = 'aarch64-linux-gnu-gcc'
> +cpp = 'aarch64-linux-gnu-cpp'
> +ar = 'aarch64-linux-gnu-gcc-ar'
> +strip = 'aarch64-linux-gnu-strip'
> +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> +pcap-config = ''
> +
> +[host_machine]
> +system = 'linux'
> +cpu_family = 'aarch64'
> +cpu = 'armv8-a'
> +endian = 'little'
> +
> +[properties]
> +implementer_id = '0x48'
> +part_number = '0xd02'
> +max_lcores = 256
> +max_numa_nodes = 4
> diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> index afe4f8e..1a54436 100644
> --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> @@ -222,6 +222,7 @@ you may use various combinations of implementer/part number::
>
>     Supported part_numbers for 0x48:
>        '0xd01':    kunpeng920
> +      '0xd02':    kunpeng930
>
>     Supported part_numbers for 0x50:
>        '0x0':     emag
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 45+ messages in thread

* [dpdk-dev] [PATCH V3 0/3] add Hisilicon kunpeng CPU support
  2021-03-10  1:35 ` [dpdk-dev] [PATCH V2 0/4] add Hisilicon kunpeng CPU support Lijun Ou
                     ` (3 preceding siblings ...)
  2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 4/4] config/arm: add kunpeng930 " Lijun Ou
@ 2021-03-27  1:27   ` Lijun Ou
  2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 1/3] config/arm: add Hisilicon kunpeng implementer Lijun Ou
                       ` (2 more replies)
  4 siblings, 3 replies; 45+ messages in thread
From: Lijun Ou @ 2021-03-27  1:27 UTC (permalink / raw)
  To: thomas, ferruh.yigit; +Cc: dev, linuxarm

This series add meson build for Hisilicon kunpeng CPU.

v2->v3:
1. merge [1/4] and [2/4] patch into one
2. rewrite some titles
3. rewrite commit logs for [2/3] [3/3]
4. add Acked-by and Reviewed-by

v1->v2:
1. split [1/2] into two.

Lijun Ou (3):
  config/arm: add Hisilicon kunpeng implementer
  config/arm: add kunpeng920 cross target
  config/arm: add kunpeng930 cross target

 config/arm/arm64_kunpeng920_linux_gcc              | 19 +++++++++++++++
 config/arm/arm64_kunpeng930_linux_gcc              | 19 +++++++++++++++
 config/arm/meson.build                             | 27 ++++++++++++++++++++++
 .../linux_gsg/cross_build_dpdk_for_arm64.rst       |  5 ++++
 4 files changed, 70 insertions(+)
 create mode 100644 config/arm/arm64_kunpeng920_linux_gcc
 create mode 100644 config/arm/arm64_kunpeng930_linux_gcc

-- 
2.7.4


^ permalink raw reply	[flat|nested] 45+ messages in thread

* [dpdk-dev] [PATCH V3 1/3] config/arm: add Hisilicon kunpeng implementer
  2021-03-27  1:27   ` [dpdk-dev] [PATCH V3 0/3] add Hisilicon kunpeng CPU support Lijun Ou
@ 2021-03-27  1:27     ` Lijun Ou
  2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 2/3] config/arm: add kunpeng920 cross target Lijun Ou
  2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 3/3] config/arm: add kunpeng930 " Lijun Ou
  2 siblings, 0 replies; 45+ messages in thread
From: Lijun Ou @ 2021-03-27  1:27 UTC (permalink / raw)
  To: thomas, ferruh.yigit; +Cc: dev, linuxarm

Here adds configs for Kunpeng server.

Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")

Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
V2->V3:
- refined the commit
- merge [1/4] and [2/4] into one.

V1->V2:
- rewrite patch title.
- split the patch into two.
---
 config/arm/meson.build | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 00bc461..a3f42c3 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -133,6 +133,32 @@ implementer_cavium = {
 	}
 }
 
+implementer_hisilicon = {
+	'description': 'Hisilicon',
+	'flags': [
+		['RTE_USE_C11_MEM_MODEL', true],
+		['RTE_CACHE_LINE_SIZE', 128],
+		['RTE_MAX_NUMA_NODES', 4]
+	],
+	'part_number_config': {
+		'0xd01': {
+			'machine_args': ['-march=armv8.2-a+crypto',
+					 '-mtune=tsv110'],
+			'flag': [['RTE_MACHINE', '"kunpeng920"'],
+				 ['RTE_MAX_LCORE', 128],
+				 ['RTE_ARM_FEATURE_ATOMICS', true]
+			]
+		},
+		'0xd02': {
+			'machine_args': ['-march=armv8.2-a+crypto+sve'],
+			'flag': [['RTE_MACHINE', '"kunpeng930"'],
+				 ['RTE_MAX_LCORE', 256],
+				 ['RTE_ARM_FEATURE_ATOMICS', true]
+			]
+		}
+	}
+}
+
 implementer_ampere = {
 	'description': 'Ampere Computing',
 	'flags': [
@@ -190,6 +216,7 @@ implementers = {
 	'generic': implementer_generic,
 	'0x41': implementer_arm,
 	'0x43': implementer_cavium,
+	'0x48': implementer_hisilicon,
 	'0x50': implementer_ampere,
 	'0x51': implementer_qualcomm,
 	'0x56': implementer_marvell,
-- 
2.7.4


^ permalink raw reply	[flat|nested] 45+ messages in thread

* [dpdk-dev] [PATCH V3 2/3] config/arm: add kunpeng920 cross target
  2021-03-27  1:27   ` [dpdk-dev] [PATCH V3 0/3] add Hisilicon kunpeng CPU support Lijun Ou
  2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 1/3] config/arm: add Hisilicon kunpeng implementer Lijun Ou
@ 2021-03-27  1:27     ` Lijun Ou
  2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 3/3] config/arm: add kunpeng930 " Lijun Ou
  2 siblings, 0 replies; 45+ messages in thread
From: Lijun Ou @ 2021-03-27  1:27 UTC (permalink / raw)
  To: thomas, ferruh.yigit; +Cc: dev, linuxarm

Add support for Hisilicon kunpeng920 cross target.

Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
V2->V3:
- rewrite title
- rewrite commit log
- add Acked-by and Reviewed-by
---
 config/arm/arm64_kunpeng920_linux_gcc               | 19 +++++++++++++++++++
 doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst |  4 ++++
 2 files changed, 23 insertions(+)
 create mode 100644 config/arm/arm64_kunpeng920_linux_gcc

diff --git a/config/arm/arm64_kunpeng920_linux_gcc b/config/arm/arm64_kunpeng920_linux_gcc
new file mode 100644
index 0000000..3eeb2e9
--- /dev/null
+++ b/config/arm/arm64_kunpeng920_linux_gcc
@@ -0,0 +1,19 @@
+[binaries]
+c = 'aarch64-linux-gnu-gcc'
+cpp = 'aarch64-linux-gnu-cpp'
+ar = 'aarch64-linux-gnu-gcc-ar'
+strip = 'aarch64-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+implementer_id = '0x48'
+part_number = '0xd01'
+max_lcores = 128
+max_numa_nodes = 4
diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
index faaf24b..afe4f8e 100644
--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
@@ -197,6 +197,7 @@ you may use various combinations of implementer/part number::
       'generic': Generic armv8
       '0x41':    Arm
       '0x43':    Cavium
+      '0x48':    Hisilicon
       '0x50':    Ampere Computing
       '0x56':    Marvell ARMADA
       'dpaa':    NXP DPAA
@@ -219,6 +220,9 @@ you may use various combinations of implementer/part number::
       '0xaf':    thunderx2t99
       '0xb2':    octeontx2
 
+   Supported part_numbers for 0x48:
+      '0xd01':    kunpeng920
+
    Supported part_numbers for 0x50:
       '0x0':     emag
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 45+ messages in thread

* [dpdk-dev] [PATCH V3 3/3] config/arm: add kunpeng930 cross target
  2021-03-27  1:27   ` [dpdk-dev] [PATCH V3 0/3] add Hisilicon kunpeng CPU support Lijun Ou
  2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 1/3] config/arm: add Hisilicon kunpeng implementer Lijun Ou
  2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 2/3] config/arm: add kunpeng920 cross target Lijun Ou
@ 2021-03-27  1:27     ` Lijun Ou
  2 siblings, 0 replies; 45+ messages in thread
From: Lijun Ou @ 2021-03-27  1:27 UTC (permalink / raw)
  To: thomas, ferruh.yigit; +Cc: dev, linuxarm

Add support for Hisilicon kunpeng930 cross target.

Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
V2->V3:
- rewrite title
- rewrite commit log
- add Acked-by and Reviewed-by
---
 config/arm/arm64_kunpeng930_linux_gcc               | 19 +++++++++++++++++++
 doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 config/arm/arm64_kunpeng930_linux_gcc

diff --git a/config/arm/arm64_kunpeng930_linux_gcc b/config/arm/arm64_kunpeng930_linux_gcc
new file mode 100644
index 0000000..464e44a
--- /dev/null
+++ b/config/arm/arm64_kunpeng930_linux_gcc
@@ -0,0 +1,19 @@
+[binaries]
+c = 'aarch64-linux-gnu-gcc'
+cpp = 'aarch64-linux-gnu-cpp'
+ar = 'aarch64-linux-gnu-gcc-ar'
+strip = 'aarch64-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+implementer_id = '0x48'
+part_number = '0xd02'
+max_lcores = 256
+max_numa_nodes = 4
diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
index afe4f8e..1a54436 100644
--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
@@ -222,6 +222,7 @@ you may use various combinations of implementer/part number::
 
    Supported part_numbers for 0x48:
       '0xd01':    kunpeng920
+      '0xd02':    kunpeng930
 
    Supported part_numbers for 0x50:
       '0x0':     emag
-- 
2.7.4


^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [Linuxarm] [PATCH V2 0/4] add Hisilicon kunpeng CPU support
  2021-03-26  0:41           ` oulijun
@ 2021-04-05 19:50             ` Honnappa Nagarahalli
  2021-04-06  1:00               ` oulijun
  0 siblings, 1 reply; 45+ messages in thread
From: Honnappa Nagarahalli @ 2021-04-05 19:50 UTC (permalink / raw)
  To: oulijun, thomas; +Cc: linuxarm, Ferruh Yigit, dev, nd, Honnappa Nagarahalli, nd

<snip>

> 
> 在 2021/3/25 22:40, Thomas Monjalon 写道:
> > 25/03/2021 14:26, oulijun:
> >> 在 2021/3/25 20:19, Thomas Monjalon 写道:
> >>> 25/03/2021 12:17, oulijun:
> >>>> Ruifeng has reviewed-by. Does anyone else have any comments? Is it
> >>>> necessary to send the V2?
> >>>
> >>> v2 for what? There is a change?
> >>>
> >> No. no change.
> >
> > So why are you asking to send a v2?
> >
> Sorry. My suggestion is to ask if you need to reset the patch based on the
> latest date. If not, wait for other's reviews and to incorporate the patch.
> >
I suggest to rework this patch once [1] is merged.

[1] http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send-email-juraj.linkes@pantheon.tech/

> >>>> 在 2021/3/25 17:07, Thomas Monjalon 写道:
> >>>>> 25/03/2021 09:54, oulijun:
> >>>>>> Hi, Thomas&&Ferruh
> >>>>>>
> >>>>>> Do I need to send a patchset?
> >>>>>
> >>>>> ???
> >>>>> What do you mean?
> >>>>>
> >>>>>> 在 2021/3/10 9:35, Lijun Ou 写道:
> >>>>>>> This series add meson build for Hisilicon kunpeng CPU.
> >>>>>>>
> >>>>>>> Lijun Ou (4):
> >>>>>>>       config/arm: add Hisilicon kunpeng920 implementer
> >>>>>>>       config/arm: add Hisilicon kunpeng930 implementer
> >>>>>>>       config/arm: add kunpeng920 meson cross compile target
> >>>>>>>       config/arm: add kunpeng930 meson cross compile target
> >
> >
> >
> > .
> >

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [Linuxarm] [PATCH V2 0/4] add Hisilicon kunpeng CPU support
  2021-04-05 19:50             ` Honnappa Nagarahalli
@ 2021-04-06  1:00               ` oulijun
  2021-04-07  2:19                 ` Honnappa Nagarahalli
  0 siblings, 1 reply; 45+ messages in thread
From: oulijun @ 2021-04-06  1:00 UTC (permalink / raw)
  To: Honnappa Nagarahalli, thomas; +Cc: linuxarm, Ferruh Yigit, dev, nd



在 2021/4/6 3:50, Honnappa Nagarahalli 写道:
> <snip>
> 
>>
>> 在 2021/3/25 22:40, Thomas Monjalon 写道:
>>> 25/03/2021 14:26, oulijun:
>>>> 在 2021/3/25 20:19, Thomas Monjalon 写道:
>>>>> 25/03/2021 12:17, oulijun:
>>>>>> Ruifeng has reviewed-by. Does anyone else have any comments? Is it
>>>>>> necessary to send the V2?
>>>>>
>>>>> v2 for what? There is a change?
>>>>>
>>>> No. no change.
>>>
>>> So why are you asking to send a v2?
>>>
>> Sorry. My suggestion is to ask if you need to reset the patch based on the
>> latest date. If not, wait for other's reviews and to incorporate the patch.
>>>
> I suggest to rework this patch once [1] is merged.
> 
> [1] http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send-email-juraj.linkes@pantheon.tech/
> 
I checked it out, and this series has not been received, and I don't 
think it can be reworked based on it.
>>>>>> 在 2021/3/25 17:07, Thomas Monjalon 写道:
>>>>>>> 25/03/2021 09:54, oulijun:
>>>>>>>> Hi, Thomas&&Ferruh
>>>>>>>>
>>>>>>>> Do I need to send a patchset?
>>>>>>>
>>>>>>> ???
>>>>>>> What do you mean?
>>>>>>>
>>>>>>>> 在 2021/3/10 9:35, Lijun Ou 写道:
>>>>>>>>> This series add meson build for Hisilicon kunpeng CPU.
>>>>>>>>>
>>>>>>>>> Lijun Ou (4):
>>>>>>>>>        config/arm: add Hisilicon kunpeng920 implementer
>>>>>>>>>        config/arm: add Hisilicon kunpeng930 implementer
>>>>>>>>>        config/arm: add kunpeng920 meson cross compile target
>>>>>>>>>        config/arm: add kunpeng930 meson cross compile target
>>>
>>>
>>>
>>> .
>>>

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [Linuxarm] [PATCH V2 0/4] add Hisilicon kunpeng CPU support
  2021-04-06  1:00               ` oulijun
@ 2021-04-07  2:19                 ` Honnappa Nagarahalli
  2021-04-08  3:30                   ` oulijun
  0 siblings, 1 reply; 45+ messages in thread
From: Honnappa Nagarahalli @ 2021-04-07  2:19 UTC (permalink / raw)
  To: oulijun, thomas; +Cc: linuxarm, Ferruh Yigit, dev, nd, Honnappa Nagarahalli, nd

<snip>

> >>
> >> 在 2021/3/25 22:40, Thomas Monjalon 写道:
> >>> 25/03/2021 14:26, oulijun:
> >>>> 在 2021/3/25 20:19, Thomas Monjalon 写道:
> >>>>> 25/03/2021 12:17, oulijun:
> >>>>>> Ruifeng has reviewed-by. Does anyone else have any comments? Is
> >>>>>> it necessary to send the V2?
> >>>>>
> >>>>> v2 for what? There is a change?
> >>>>>
> >>>> No. no change.
> >>>
> >>> So why are you asking to send a v2?
> >>>
> >> Sorry. My suggestion is to ask if you need to reset the patch based
> >> on the latest date. If not, wait for other's reviews and to incorporate the
> patch.
> >>>
> > I suggest to rework this patch once [1] is merged.
> >
> > [1]
> > http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send
> > -email-juraj.linkes@pantheon.tech/
> >
> I checked it out, and this series has not been received, and I don't think it can
> be reworked based on it.
It would be good to review the series, test it on your platform and provide any comments you might have. It will help make progress on the series.

> >>>>>> 在 2021/3/25 17:07, Thomas Monjalon 写道:
> >>>>>>> 25/03/2021 09:54, oulijun:
> >>>>>>>> Hi, Thomas&&Ferruh
> >>>>>>>>
> >>>>>>>> Do I need to send a patchset?
> >>>>>>>
> >>>>>>> ???
> >>>>>>> What do you mean?
> >>>>>>>
> >>>>>>>> 在 2021/3/10 9:35, Lijun Ou 写道:
> >>>>>>>>> This series add meson build for Hisilicon kunpeng CPU.
> >>>>>>>>>
> >>>>>>>>> Lijun Ou (4):
> >>>>>>>>>        config/arm: add Hisilicon kunpeng920 implementer
> >>>>>>>>>        config/arm: add Hisilicon kunpeng930 implementer
> >>>>>>>>>        config/arm: add kunpeng920 meson cross compile target
> >>>>>>>>>        config/arm: add kunpeng930 meson cross compile target
> >>>
> >>>
> >>>
> >>> .
> >>>

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [Linuxarm] [PATCH V2 0/4] add Hisilicon kunpeng CPU support
  2021-04-07  2:19                 ` Honnappa Nagarahalli
@ 2021-04-08  3:30                   ` oulijun
  2021-04-08  8:01                     ` Thomas Monjalon
  0 siblings, 1 reply; 45+ messages in thread
From: oulijun @ 2021-04-08  3:30 UTC (permalink / raw)
  To: Honnappa Nagarahalli, thomas; +Cc: linuxarm, Ferruh Yigit, dev, nd



在 2021/4/7 10:19, Honnappa Nagarahalli 写道:
> <snip>
> 
>>>>
>>>> 在 2021/3/25 22:40, Thomas Monjalon 写道:
>>>>> 25/03/2021 14:26, oulijun:
>>>>>> 在 2021/3/25 20:19, Thomas Monjalon 写道:
>>>>>>> 25/03/2021 12:17, oulijun:
>>>>>>>> Ruifeng has reviewed-by. Does anyone else have any comments? Is
>>>>>>>> it necessary to send the V2?
>>>>>>>
>>>>>>> v2 for what? There is a change?
>>>>>>>
>>>>>> No. no change.
>>>>>
>>>>> So why are you asking to send a v2?
>>>>>
>>>> Sorry. My suggestion is to ask if you need to reset the patch based
>>>> on the latest date. If not, wait for other's reviews and to incorporate the
>> patch.
>>>>>
>>> I suggest to rework this patch once [1] is merged.
>>>
>>> [1]
>>> http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send
>>> -email-juraj.linkes@pantheon.tech/
>>>
>> I checked it out, and this series has not been received, and I don't think it can
>> be reworked based on it.
> It would be good to review the series, test it on your platform and provide any comments you might have. It will help make progress on the series.
> 
Hi, Thomas && Ferruh Yigit
   What's your opinion?

Thanks
>>>>>>>> 在 2021/3/25 17:07, Thomas Monjalon 写道:
>>>>>>>>> 25/03/2021 09:54, oulijun:
>>>>>>>>>> Hi, Thomas&&Ferruh
>>>>>>>>>>
>>>>>>>>>> Do I need to send a patchset?
>>>>>>>>>
>>>>>>>>> ???
>>>>>>>>> What do you mean?
>>>>>>>>>
>>>>>>>>>> 在 2021/3/10 9:35, Lijun Ou 写道:
>>>>>>>>>>> This series add meson build for Hisilicon kunpeng CPU.
>>>>>>>>>>>
>>>>>>>>>>> Lijun Ou (4):
>>>>>>>>>>>         config/arm: add Hisilicon kunpeng920 implementer
>>>>>>>>>>>         config/arm: add Hisilicon kunpeng930 implementer
>>>>>>>>>>>         config/arm: add kunpeng920 meson cross compile target
>>>>>>>>>>>         config/arm: add kunpeng930 meson cross compile target
>>>>>
>>>>>
>>>>>
>>>>> .
>>>>>

^ permalink raw reply	[flat|nested] 45+ messages in thread

* Re: [dpdk-dev] [Linuxarm] [PATCH V2 0/4] add Hisilicon kunpeng CPU support
  2021-04-08  3:30                   ` oulijun
@ 2021-04-08  8:01                     ` Thomas Monjalon
  0 siblings, 0 replies; 45+ messages in thread
From: Thomas Monjalon @ 2021-04-08  8:01 UTC (permalink / raw)
  To: oulijun; +Cc: Honnappa Nagarahalli, linuxarm, Ferruh Yigit, dev, nd

08/04/2021 05:30, oulijun:
> 在 2021/4/7 10:19, Honnappa Nagarahalli 写道:
> >>>> 在 2021/3/25 22:40, Thomas Monjalon 写道:
> >>>>> 25/03/2021 14:26, oulijun:
> >>>>>> 在 2021/3/25 20:19, Thomas Monjalon 写道:
> >>>>>>> 25/03/2021 12:17, oulijun:
> >>>>>>>> Ruifeng has reviewed-by. Does anyone else have any comments? Is
> >>>>>>>> it necessary to send the V2?
> >>>>>>>
> >>>>>>> v2 for what? There is a change?
> >>>>>>>
> >>>>>> No. no change.
> >>>>>
> >>>>> So why are you asking to send a v2?
> >>>>>
> >>>> Sorry. My suggestion is to ask if you need to reset the patch based
> >>>> on the latest date. If not, wait for other's reviews and to incorporate the
> >> patch.
> >>>>>
> >>> I suggest to rework this patch once [1] is merged.
> >>>
> >>> [1]
> >>> http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send
> >>> -email-juraj.linkes@pantheon.tech/
> >>>
> >> I checked it out, and this series has not been received, and I don't think it can
> >> be reworked based on it.
> > It would be good to review the series, test it on your platform and provide any comments you might have. It will help make progress on the series.
> > 
> Hi, Thomas && Ferruh Yigit
>    What's your opinion?

Help in review is always good.
Please review what you can.




^ permalink raw reply	[flat|nested] 45+ messages in thread

end of thread, other threads:[~2021-04-08  8:01 UTC | newest]

Thread overview: 45+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 12:46 [dpdk-dev] [PATCH 0/2] meson build fixes for hns3 Lijun Ou
2021-02-03 12:46 ` [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build Lijun Ou
2021-02-10  9:41   ` Thomas Monjalon
2021-02-24  1:34     ` oulijun
2021-02-24  7:41       ` Thomas Monjalon
2021-02-24  9:17         ` oulijun
2021-02-24 10:24           ` Thomas Monjalon
2021-02-24 11:55         ` Juraj Linkeš
2021-02-24 12:09           ` Thomas Monjalon
2021-03-01 10:46             ` Juraj Linkeš
2021-03-05  1:36               ` oulijun
2021-03-22  1:01                 ` Min Hu (Connor)
2021-02-03 12:46 ` [dpdk-dev] [PATCH 2/2] config/arm: fix Hisilicon kunpeng930 Soc build Lijun Ou
2021-03-05  1:38 ` [dpdk-dev] [PATCH 0/2] meson build fixes for hns3 oulijun
2021-03-10  1:35 ` [dpdk-dev] [PATCH V2 0/4] add Hisilicon kunpeng CPU support Lijun Ou
2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer Lijun Ou
2021-03-20  2:27     ` Min Hu (Connor)
2021-03-23  8:07     ` Ruifeng Wang
2021-03-23 13:51       ` oulijun
2021-03-23 15:40         ` Ruifeng Wang
2021-03-25  7:21           ` oulijun
2021-03-25  7:45             ` Ruifeng Wang
2021-03-25  7:56               ` oulijun
2021-03-25  8:10                 ` Ruifeng Wang
2021-03-26 12:40     ` Jerin Jacob
2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 2/4] config/arm: add Hisilicon kunpeng930 implementer Lijun Ou
2021-03-26 12:42     ` Jerin Jacob
2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 3/4] config/arm: add kunpeng920 meson cross compile target Lijun Ou
2021-03-25  7:48     ` Ruifeng Wang
2021-03-26 12:45       ` Jerin Jacob
2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 4/4] config/arm: add kunpeng930 " Lijun Ou
2021-03-25  7:49     ` Ruifeng Wang
2021-03-26 12:46     ` Jerin Jacob
2021-03-27  1:27   ` [dpdk-dev] [PATCH V3 0/3] add Hisilicon kunpeng CPU support Lijun Ou
2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 1/3] config/arm: add Hisilicon kunpeng implementer Lijun Ou
2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 2/3] config/arm: add kunpeng920 cross target Lijun Ou
2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 3/3] config/arm: add kunpeng930 " Lijun Ou
     [not found] ` <6032863.io6GlxzLMq@thomas>
     [not found]   ` <f0e55cbc-3b61-8858-a5e7-aeee9dc613c2@huawei.com>
     [not found]     ` <6796692.TXxtQ3U2Ta@thomas>
2021-03-25 13:26       ` [dpdk-dev] [Linuxarm] [PATCH V2 0/4] add Hisilicon kunpeng CPU support oulijun
2021-03-25 14:40         ` Thomas Monjalon
2021-03-26  0:41           ` oulijun
2021-04-05 19:50             ` Honnappa Nagarahalli
2021-04-06  1:00               ` oulijun
2021-04-07  2:19                 ` Honnappa Nagarahalli
2021-04-08  3:30                   ` oulijun
2021-04-08  8:01                     ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git