From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59B23A04FF; Thu, 24 Mar 2022 12:17:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03B58410FC; Thu, 24 Mar 2022 12:17:09 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 796FB40141 for ; Thu, 24 Mar 2022 12:17:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648120626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qG43AEkabzpxPxar6sjvIui7u4pk6l7C3DbuUAxl7w8=; b=YPBgcqCF9T8A1TB0I/SrgMmo4HQqo1jIzKUrwyTib9tvjDu5KQkDtcipXSbuLr7o91j7FZ fiZwjqY9SD21Jkv8MCiQcFkxCNXQFHFAWkI6muQSYBJOROAB6r7PlZezKRgQ+UjUt1PTkM fIa8MDTe7B7IFg+Cyn8S5dP/5nHQ9Os= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-RaPrIcLhPUimXN3I21BqRg-1; Thu, 24 Mar 2022 07:17:00 -0400 X-MC-Unique: RaPrIcLhPUimXN3I21BqRg-1 Received: by mail-wm1-f69.google.com with SMTP id o19-20020a05600c379300b0038c7117460dso1466845wmr.6 for ; Thu, 24 Mar 2022 04:17:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from:to :cc:references:content-language:subject:in-reply-to :content-transfer-encoding; bh=qG43AEkabzpxPxar6sjvIui7u4pk6l7C3DbuUAxl7w8=; b=PIvpotlOEktITKknTRYJlFOtbk02IGK7lqcESIbiej/0kmeVD/rs9fMEWeiR/XvHFL 435+BzBqKI7z3+Ll2DPjj4hg3IkIirxJdbCto+0Qv6cMmhwsacRQTv/E16TTlWPMYL/o 50BFpfY0G/uriydq4phQyJWirMvKD06xW42nKyKPEsgMJBc5ZncISGxlbh6oX9E2S1+N zfNBTwFhGB3lE8ApbIHrqYjjPbiUJVHYvEmBbxvzcNqWVWSLSM6XeJyVuJMveDMdr9Zz 1P5ufDnCbvTUqKwu5juhAXorvaFgNFaCrjLiHVyqYAwKbG+LZ0GSeS3C7iJFSSawgog6 qRFA== X-Gm-Message-State: AOAM530mjWDZZ1JrhWP20gNiXHUqjAMvutnCbRivmbuKT87aBsWz9uBr vR8ICXUPf4esgzCN77z3ljb0jpQRodGdtIcliHst3r/lSOsFMyLWFO8Etxc53h0bSNgmIQWYbDQ /kZU= X-Received: by 2002:a05:600c:378d:b0:38b:e12f:edde with SMTP id o13-20020a05600c378d00b0038be12feddemr4211966wmr.69.1648120619303; Thu, 24 Mar 2022 04:16:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxh8rtm7j6ZZfS6RFBnry/ZBZWn14jdiGWmviYE4UchuXj7kpuJnbHMTP3Ltz6NFmKdtPNcOQ== X-Received: by 2002:a05:600c:378d:b0:38b:e12f:edde with SMTP id o13-20020a05600c378d00b0038be12feddemr4211949wmr.69.1648120619144; Thu, 24 Mar 2022 04:16:59 -0700 (PDT) Received: from [192.168.0.36] ([78.17.178.139]) by smtp.gmail.com with ESMTPSA id z13-20020a5d440d000000b00203f2b010b1sm2395689wrq.44.2022.03.24.04.16.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Mar 2022 04:16:58 -0700 (PDT) Message-ID: <4d81601b-6aa5-3746-a888-7a290e071997@redhat.com> Date: Thu, 24 Mar 2022 11:16:57 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 From: Kevin Traynor To: "Zhang, Qi Z" , "Wu, Wenjun1" , "dev@dpdk.org" , "Yang, Qiming" Cc: "Van Haaren, Harry" , "Su, Simei" , Luca Boccassi , Christian Ehrhardt References: <20220222062612.335622-1-wenjun1.wu@intel.com> <20220228073607.2249410-1-wenjun1.wu@intel.com> <3da8efff430e43808657c353c748ea9d@intel.com> Subject: Re: [PATCH v4] net/ice: improve performance of RX timestamp offload In-Reply-To: <3da8efff430e43808657c353c748ea9d@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 24/03/2022 09:09, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Wu, Wenjun1 >> Sent: Monday, February 28, 2022 3:36 PM >> To: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming >> >> Cc: Van Haaren, Harry ; Su, Simei >> ; Wu, Wenjun1 >> Subject: [PATCH v4] net/ice: improve performance of RX timestamp offload >> >> Previously, each time a burst of packets is received, SW reads HW register >> and assembles it and the timestamp from descriptor together to get the >> complete 64 bits timestamp. >> >> This patch optimizes the algorithm. The SW only needs to check the >> monotonicity of the low 32bits timestamp to avoid crossing borders. >> Each time before SW receives a burst of packets, it should check the time >> difference between current time and last update time to avoid the low 32 >> bits timestamp cycling twice. >> >> Signed-off-by: Wenjun Wu > > Added cc stable > Hi Qi. The DPDK documentation has guidance about what should be backported to LTS [0] and distinguishes between fixes and performance improvements. Please try and stick with this when applying patches or let LTS maintainers know if there is a debatable case. thanks, Kevin. [0] http://doc.dpdk.org/guides-21.11/contributing/stable.html#what-changes-should-be-backported > Acked-by: Qi Zhang > > Applied to dpdk-next-net-intel. > > Thanks > Qi >