From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4FE1C1E34 for ; Tue, 19 Sep 2017 13:00:17 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 19 Sep 2017 04:00:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,418,1500966000"; d="scan'208";a="901777578" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 19 Sep 2017 04:00:06 -0700 To: Matan Azrad , Gaetan Rivet Cc: "dev@dpdk.org" , "john.mcnamara@intel.com" References: <1505403124-44297-1-git-send-email-matan@mellanox.com> From: Ferruh Yigit Message-ID: <4dd479dc-8d1e-7e6c-6100-7c71058d98b7@intel.com> Date: Tue, 19 Sep 2017 12:00:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] doc: update failsafe feature list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 11:00:17 -0000 On 9/19/2017 11:04 AM, Matan Azrad wrote: > > Hi Ferruh > >> -----Original Message----- >> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] >> Sent: Tuesday, September 19, 2017 12:27 PM >> To: Matan Azrad ; Gaetan Rivet >> >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] doc: update failsafe feature list >> >> On 9/14/2017 4:32 PM, Matan Azrad wrote: >>> Add supported failsafe features to feature list. >>> Remove stats per queue feature from failsafe feature list since >>> queue_stats_mapping_set dev op has not implemented yet. >>> >>> Signed-off-by: Matan Azrad >>> --- >>> doc/guides/nics/features/failsafe.ini | 15 ++++++++++++++- >>> 1 file changed, 14 insertions(+), 1 deletion(-) >>> >>> diff --git a/doc/guides/nics/features/failsafe.ini >>> b/doc/guides/nics/features/failsafe.ini >>> index a42e344..9f48455 100644 >>> --- a/doc/guides/nics/features/failsafe.ini >>> +++ b/doc/guides/nics/features/failsafe.ini >>> @@ -4,20 +4,33 @@ >>> ; Refer to default.ini for the full list of available PMD features. >>> ; >>> [Features] >>> +Speed capabilities = Y >>> Link status = Y >>> Link status event = Y >>> MTU update = Y >>> Jumbo frame = Y >>> +Scattered Rx = Y >>> +LRO = Y >>> +TSO = Y >>> Promiscuous mode = Y >>> Allmulticast mode = Y >>> Unicast MAC filter = Y >>> Multicast MAC filter = Y >>> VLAN filter = Y >>> +Ethertype filter = Y >>> +N-tuple filter = Y >>> +SYN filter = Y >>> +Tunnel filter = Y >>> +Flexible filter = Y >>> +Hash filter = Y >>> +Flow director = Y >>> Flow control = Y >>> Flow API = Y >>> +QinQ offload = Y >>> +L3 checksum offload = Y >>> +L4 checksum offload = Y >>> Packet type parsing = Y >>> Basic stats = Y >>> -Stats per queue = Y >>> ARMv7 = Y >>> ARMv8 = Y >>> Power8 = Y >> >> I am not sure if claiming support for these features is correct. >> Failsafe itself doesn't provide these features, but relies underlying hardware >> which we don't really know what they supports or not in this stage. >> > > Don't you think that almost all failsafe features rely underlying hardware or sub PMDs? You are right, perhaps we should remove all. This is helpful to show what device features are supported. For failsafe, is this information useful? > >> OK for dropping "Stats per queue" >> >>> >