From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FC17A054F; Tue, 2 Mar 2021 12:27:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBD9222A2A4; Tue, 2 Mar 2021 12:27:51 +0100 (CET) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mails.dpdk.org (Postfix) with ESMTP id 59CDB22A2A3 for ; Tue, 2 Mar 2021 12:27:51 +0100 (CET) Received: by mail-wm1-f49.google.com with SMTP id w203-20020a1c49d40000b029010c706d0642so928847wma.0 for ; Tue, 02 Mar 2021 03:27:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=c+5sBFVJ2qiXvyIxle0IWDDBB5oGDS7pL+Szo9X6rlk=; b=vJIPfSONCXx3hgEL+r1nAl8yV8RSyPWSWGyOaMnbCRbLmHrnvLDzdVMlUgZS7WusaS 6AgBqILE4MzEM4ktVTyw/vRpvfqXGMuTWJlU3WUu/Pl9RNZQwxD9RGTGa4Exafn931cJ lLIn5peh/jk3sJNGqJNadgar54o3gPzJVQpVIPhBGw7gAvMY6jr4FcxTXvUksnFWADgh KaLqoVGg/l9W8c0wJBfdQsKOn4BhvhbEg3BG4SxgOOhgmsnyh6z/SpJHbio41ZTt7xzW SP2jSaABM0lkSxOxOjwUAFnStOcJDn8QiDx3bNvhi4Rz+wWAWiwfrH9FW48uILrSpMDl T1jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=c+5sBFVJ2qiXvyIxle0IWDDBB5oGDS7pL+Szo9X6rlk=; b=JKZs0JlU5f9kzj9J+UztSx11A6uoU7JqdwpReNBCLKwVgyAVe3dEvh2TDpSnXg5SwY xmNPIRevJKmIfdDlzui14uFaGK4uTv5VKcVth3eWvcpqjjswHPrc5gSshomth8XNiaUt vpeAHm+8LvQdVtL5b4DZJq7i0E/qzl7Oz76Dlnemup+LGjKx+wGACQJlS22Bejiz4nxY b6olwn5fkBylhGqoCvHfSa7DcD3xzNRlZzvOzHAxq0u8I2EL4xrH/eYPagE/29GVZCly IhfqsvcIR73uSQnZlQf0sl0JHu2NPqabjHdjpKs3Fkow7ty7UIoEMMOLspfpdf2fCNKr EfPA== X-Gm-Message-State: AOAM533uQjOS0M/fGzQrdapldk/mIf2SFWqDsFjRNj+hNc/8HjCy98EI /4bNjCxlrojilDiBtpeUusz2YA== X-Google-Smtp-Source: ABdhPJy1IIWVQoFY9OK+4rpWGj6XfuAk4JJbkIezY8GN86e0mLZUNsQYkNLijLARR7LwDryMgkPJpQ== X-Received: by 2002:a05:600c:4fc6:: with SMTP id o6mr3533292wmq.157.1614684471140; Tue, 02 Mar 2021 03:27:51 -0800 (PST) Received: from [192.168.0.33] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id m2sm2214461wml.34.2021.03.02.03.27.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Mar 2021 03:27:50 -0800 (PST) From: Nick Connolly X-Google-Original-From: Nick Connolly To: Dmitry Kozlyuk Cc: Bruce Richardson , dev@dpdk.org, Tyler Retzlaff , Jerin Jacob , Sunil Kumar Kori References: <20210220232910.772-1-dmitry.kozliuk@gmail.com> <20210221012831.14643-1-dmitry.kozliuk@gmail.com> <20210221012831.14643-2-dmitry.kozliuk@gmail.com> <20210222114743.GA1235@bricha3-MOBL.ger.corp.intel.com> <64c1e6c5-ce80-b550-b8ea-ad2a6bfe7505@mayadata.io> <20210222142625.GA704@bricha3-MOBL.ger.corp.intel.com> <20210223015750.31516c2c@sovereign> <20210223094502.GB79@bricha3-MOBL.ger.corp.intel.com> <20210227232327.1ac69729@sovereign> <87502441-f319-2436-8cbc-c6529982b9cd@mayadata.io> <20210302032251.0cd592f3@sovereign> Message-ID: <4dd9415e-f598-750b-c50b-8ae91c593311@mayadata.io> Date: Tue, 2 Mar 2021 11:27:49 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210302032251.0cd592f3@sovereign> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v2 1/7] eal: add wrappers for POSIX string functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > >> DPDK supports a variety of platforms and toolsets and my experience with >> SPDK suggests that we'll end up with compiler specific ifdef's. > I'd argue they are inevitable. Consider POSIX close(): if it's missing, what > would be a correct fallback? It depends on the execution environment (OS). > String function fallbacks, of course, are easily implemented from scratch. Agreed. >> Public functions without rte_ prefix shall not be introduced at all. Agreed. Perhaps as a separate patch we should consider validation rules to enforce the requirements. Regards, Nick