From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 4/4] devtools: add autotest app to build script
Date: Tue, 4 Apr 2017 14:03:02 +0100 [thread overview]
Message-ID: <4e02b479-1ff0-0b20-da08-90373c8d2ca4@intel.com> (raw)
In-Reply-To: <2656152.ADfflcFtbm@xps13>
On 3/30/2017 9:42 PM, Thomas Monjalon wrote:
> For info, Ferruh did a similar patch:
> http://dpdk.org/patch/22443
> Ferruh, OK to keep Bruce one?
Sure, go for it, they both do same thing.
>
> 2017-03-30 16:33, Bruce Richardson:
>> On Thu, Mar 30, 2017 at 04:36:11PM +0200, Thomas Monjalon wrote:
>>> 2017-03-29 17:38, Bruce Richardson:
>>>> Since the test app is no longer being build by default as part of a build,
>>>> we need to update the testbuild script to take account of this.
>>> [...]
>>>> --- a/devtools/test-build.sh
>>>> +++ b/devtools/test-build.sh
>>>> @@ -229,6 +229,9 @@ for conf in $configs ; do
>>>> echo "================== Build $dir"
>>>> make -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
>>>> EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
>>>> + echo "================== Build tests for $dir"
>>>> + make test-build -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
>>>> + EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
>>>> ! $short || break
>>>> echo "================== Build examples for $dir"
>>>> export RTE_SDK=$(pwd)
>>>
>>> It should be added after the "short break".
>>>
>> You have no idea how many times in preparing the patchset I moved the
>> addition above the break, and then back below it, and above it again!
>> You pick what you think is best. :-)
>>
>>> The test-build target rebuild all.
>> It rebuilds the libs, but not the apps, which is why we can't just
>> use test-build target, or we will skip testpmd.
>>
>>> I think it should be standard apps like the examples
>>> and not re-link the libs before building.
>>> The other way is to merge it with the above command (default build).
>>
>> I tried merging the two into a single command, i.e. "make all
>> test-build" but that failed with parallel builds because the two jobs
>> try and build some things at the same time and interfere with each
>> other. [The kernel drivers seemed to be the main problem]
>>
>> /Bruce
>
>
next prev parent reply other threads:[~2017-04-04 13:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 14:04 [dpdk-dev] [PATCH 0/4] improve build coverage Bruce Richardson
2017-03-29 14:04 ` [dpdk-dev] [PATCH 1/4] examples: enable performance-thread in examples build Bruce Richardson
2017-03-29 14:04 ` [dpdk-dev] [PATCH 2/4] config: enable crypto scheduler PMD by default Bruce Richardson
2017-03-30 14:48 ` Zhang, Roy Fan
2017-03-29 14:04 ` [dpdk-dev] [PATCH 3/4] devtools: remove special case build for perf thread example Bruce Richardson
2017-03-29 14:04 ` [dpdk-dev] [PATCH 4/4] devtools: add autotest app to build script Bruce Richardson
2017-03-29 16:38 ` [dpdk-dev] [PATCH v2 0/4] improve build coverage Bruce Richardson
2017-03-29 16:38 ` [dpdk-dev] [PATCH v2 1/4] examples: enable performance-thread in examples build Bruce Richardson
2017-03-30 7:45 ` Declan Doherty
2017-03-29 16:38 ` [dpdk-dev] [PATCH v2 2/4] config: enable crypto scheduler PMD by default Bruce Richardson
2017-03-30 7:45 ` Declan Doherty
2017-03-29 16:38 ` [dpdk-dev] [PATCH v2 3/4] devtools: remove special case build for perf thread example Bruce Richardson
2017-03-30 7:46 ` Declan Doherty
2017-03-30 14:31 ` Thomas Monjalon
2017-03-30 15:30 ` Bruce Richardson
2017-03-30 20:38 ` Thomas Monjalon
2017-03-31 9:15 ` Bruce Richardson
2017-03-31 9:56 ` Thomas Monjalon
2017-03-29 16:38 ` [dpdk-dev] [PATCH v2 4/4] devtools: add autotest app to build script Bruce Richardson
2017-03-30 7:47 ` Declan Doherty
2017-03-30 14:36 ` Thomas Monjalon
2017-03-30 15:33 ` Bruce Richardson
2017-03-30 20:42 ` Thomas Monjalon
2017-04-04 13:03 ` Ferruh Yigit [this message]
2017-04-06 19:45 ` [dpdk-dev] [PATCH v2 0/4] improve build coverage Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e02b479-1ff0-0b20-da08-90373c8d2ca4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).