From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D06E9326C for ; Tue, 4 Apr 2017 15:03:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491310986; x=1522846986; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=Rtt13FLhdS6DsWFTW6szOzD9y60nFfwsrurSDHwWI2g=; b=tswwcchXXccNIN3kwW00wLCp5pOgWsN7WVJpf2NGr1j07SPa03f9OGdF CZg1ztsrNrrsI2yXP0HT23CrgCDTCg==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2017 06:03:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,275,1486454400"; d="scan'208";a="84480168" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 04 Apr 2017 06:03:03 -0700 To: Thomas Monjalon , Bruce Richardson References: <20170329140419.27149-1-bruce.richardson@intel.com> <1851186.Q5rVaVkRzi@xps13> <20170330153322.GB14552@bricha3-MOBL3.ger.corp.intel.com> <2656152.ADfflcFtbm@xps13> Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org From: Ferruh Yigit Message-ID: <4e02b479-1ff0-0b20-da08-90373c8d2ca4@intel.com> Date: Tue, 4 Apr 2017 14:03:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <2656152.ADfflcFtbm@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 4/4] devtools: add autotest app to build script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 13:03:06 -0000 On 3/30/2017 9:42 PM, Thomas Monjalon wrote: > For info, Ferruh did a similar patch: > http://dpdk.org/patch/22443 > Ferruh, OK to keep Bruce one? Sure, go for it, they both do same thing. > > 2017-03-30 16:33, Bruce Richardson: >> On Thu, Mar 30, 2017 at 04:36:11PM +0200, Thomas Monjalon wrote: >>> 2017-03-29 17:38, Bruce Richardson: >>>> Since the test app is no longer being build by default as part of a build, >>>> we need to update the testbuild script to take account of this. >>> [...] >>>> --- a/devtools/test-build.sh >>>> +++ b/devtools/test-build.sh >>>> @@ -229,6 +229,9 @@ for conf in $configs ; do >>>> echo "================== Build $dir" >>>> make -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \ >>>> EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir >>>> + echo "================== Build tests for $dir" >>>> + make test-build -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \ >>>> + EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir >>>> ! $short || break >>>> echo "================== Build examples for $dir" >>>> export RTE_SDK=$(pwd) >>> >>> It should be added after the "short break". >>> >> You have no idea how many times in preparing the patchset I moved the >> addition above the break, and then back below it, and above it again! >> You pick what you think is best. :-) >> >>> The test-build target rebuild all. >> It rebuilds the libs, but not the apps, which is why we can't just >> use test-build target, or we will skip testpmd. >> >>> I think it should be standard apps like the examples >>> and not re-link the libs before building. >>> The other way is to merge it with the above command (default build). >> >> I tried merging the two into a single command, i.e. "make all >> test-build" but that failed with parallel builds because the two jobs >> try and build some things at the same time and interfere with each >> other. [The kernel drivers seemed to be the main problem] >> >> /Bruce > >