From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D2B071B3F1 for ; Mon, 5 Feb 2018 18:09:58 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2018 09:09:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,465,1511856000"; d="scan'208";a="24986390" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by FMSMGA003.fm.intel.com with ESMTP; 05 Feb 2018 09:09:56 -0800 To: Rahul Lakkireddy , dev@dpdk.org Cc: kumaras@chelsio.com, surendra@chelsio.com, nirranjan@chelsio.com, indranil@chelsio.com References: <713e92d0143827f8af409763815cde15b9d40305.1517685185.git.rahul.lakkireddy@chelsio.com> From: Ferruh Yigit Message-ID: <4e2eda5f-4697-906e-0596-84502add0af6@intel.com> Date: Mon, 5 Feb 2018 17:09:55 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <713e92d0143827f8af409763815cde15b9d40305.1517685185.git.rahul.lakkireddy@chelsio.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/7] cxgbe: add support to update RSS hash configuration and key X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 17:09:59 -0000 On 2/4/2018 6:06 AM, Rahul Lakkireddy wrote: > From: Kumar Sanghvi > > Add firmware API for updating RSS hash configuration and key. Move > RSS hash configuration from cxgb4_write_rss() to a separate function > cxgbe_write_rss_conf(). > > Also, rename cxgb4_write_rss() to cxgbe_write_rss() for consistency. > > Original work by Surendra Mobiya > > Signed-off-by: Kumar Sanghvi > Signed-off-by: Rahul Lakkireddy > --- > doc/guides/nics/cxgbe.rst | 2 + > doc/guides/nics/features/cxgbe.ini | 1 + > doc/guides/rel_notes/release_18_02.rst | 3 ++ > drivers/net/cxgbe/base/adapter.h | 4 +- > drivers/net/cxgbe/base/common.h | 3 ++ > drivers/net/cxgbe/base/t4_hw.c | 73 +++++++++++++++++++++++++++ > drivers/net/cxgbe/base/t4_regs.h | 25 +++++++++ > drivers/net/cxgbe/base/t4fw_interface.h | 89 +++++++++++++++++++++++++++++++++ > drivers/net/cxgbe/cxgbe.h | 2 + > drivers/net/cxgbe/cxgbe_ethdev.c | 32 ++++++++++++ > drivers/net/cxgbe/cxgbe_main.c | 79 ++++++++++++++++++++++------- > 11 files changed, 295 insertions(+), 18 deletions(-) I tend to get driver patches even after integration deadline, mainly because of their limited scope. But since these are new features, submitted just before rc3, adding with questions in first patch, I am for postponing this patchset to next release and do more review, what do you think?