From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC2CDA04C7; Tue, 15 Sep 2020 12:09:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 448791BFC4; Tue, 15 Sep 2020 12:09:33 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 2801A1BF83 for <dev@dpdk.org>; Tue, 15 Sep 2020 12:09:30 +0200 (CEST) IronPort-SDR: 4pqGWgCM9bVaZGrpTaQUs0ggUclZhb9eGU5qOZAmOjTtpQCxpMpQuiM9RIg3Ocm+B6QbDxsawQ sFdWrANPzzyw== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="138737369" X-IronPort-AV: E=Sophos;i="5.76,429,1592895600"; d="scan'208";a="138737369" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 03:09:26 -0700 IronPort-SDR: RRrmQAZErli//6TEi11e1TM18fnrF7b8sYGZLO72YDQYbDV/hot88FkTwvJ5n7nYa1aI0dmQcc hbMtW1b5e5uQ== X-IronPort-AV: E=Sophos;i="5.76,429,1592895600"; d="scan'208";a="331122146" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.248.49]) ([10.213.248.49]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 03:09:26 -0700 To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org References: <20200911190701.29171-1-stephen@networkplumber.org> <20200914182002.6750-1-stephen@networkplumber.org> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <4e392751-a908-86ff-df4d-ea3eb705d4b5@intel.com> Date: Tue, 15 Sep 2020 11:09:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200914182002.6750-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 00/17] Replace terms master/slave X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 14-Sep-20 7:19 PM, Stephen Hemminger wrote: > As announced in 20.08 release notes, the terms for lcore role > will change in 20.11 release. > > This is a project wide patchset to terminolgy used for DPDK lcore. > The term "master" referring to lcore is replaced with "main" and > "slave" lcore is replaced with "worker" lcore. > > This is most visible in API for rte_get_master_lcore() which is > replaced with rte_get_main_lcore(). And the macros for iterating > over lcores are replaced as well. > > The first patch introduces a way to mark macro's as deprecated > as well. > > v2 > - fix more places found by Anatoly and grep > - add coding style update > - add memif changes > More missed places: doc/guides/linux_gsg/quick_start.rst 235,10: EAL: Master core 0 is ready (tid=1b2ad720) 297,10: EAL: Master core 0 is ready (tid=de25b700) doc/guides/sample_app_ug/performance_thread.rst 1220,27: main EAL thread after all slave threads have stopped and returned to the C drivers/bus/pci/pci_common_uio.c 54,27: /* fd is not needed in slave process, close it */ drivers/bus/vmbus/vmbus_common_uio.c 88,25: /* fd is not needed in slave process, close it */ drivers/event/dpaa2/dpaa2_eventdev_selftest.c 504,31: launch_workers_and_wait(int (*master_worker)(void *), 505,10: int (*slave_workers)(void *), uint32_t total_events, 540,12: /* skip master */ 1, 542,24: rte_eal_remote_launch(master_worker, ¶m[0], w_lcore); 551,25: rte_eal_remote_launch(slave_workers, ¶m[port], w_lcore); drivers/event/octeontx/ssovf_evdev_selftest.c 604,31: launch_workers_and_wait(int (*master_worker)(void *), 605,10: int (*slave_workers)(void *), uint32_t total_events, 640,12: /* skip master */ 1, 642,24: rte_eal_remote_launch(master_worker, ¶m[0], w_lcore); 651,25: rte_eal_remote_launch(slave_workers, ¶m[port], w_lcore); drivers/event/sw/sw_evdev_selftest.c 3111,12: /* skip master */ 1, drivers/net/softnic/rte_eth_softnic_internals.h 550,4: * Master thead: data plane thread context drivers/net/softnic/rte_eth_softnic_thread.c 21,4: * Master thread: data plane thread init 81,6: /* Master thread records */ 212,4: * Master thread & data plane threads: message passing 246,4: * Master thread 590,4: * Master thread & data plane threads: message passing 756,4: * Master thread lib/librte_eal/linux/eal_memory.c 1740,55: * --socket-mem, we allocate all of our memory on master core socket. lib/librte_kni/rte_kni.h 83,43: * This function is to be executed on the MASTER lcore only, after EAL -- Thanks, Anatoly