From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 332E9325F for ; Mon, 15 Jan 2018 11:20:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2018 02:20:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,363,1511856000"; d="scan'208";a="10336100" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by fmsmga008.fm.intel.com with ESMTP; 15 Jan 2018 02:20:33 -0800 To: Shahaf Shuler , "dev@dpdk.org" References: <89b45470-1868-0a1a-02a3-5c34ce1ac48e@intel.com> From: Ferruh Yigit Message-ID: <4e57e260-822f-a96a-1b1c-429e54b76d60@intel.com> Date: Mon, 15 Jan 2018 10:20:32 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert to new ethdev offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 10:20:35 -0000 On 1/14/2018 10:37 AM, Shahaf Shuler wrote: > Friday, January 12, 2018 3:31 PM, Ferruh Yigit: >> On 12/26/2017 9:23 AM, Shahaf Shuler wrote: >>> Ethdev offloads API has changed since: >>> >>> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit >>> cba7f53b717d ("ethdev: introduce Tx queue offloads API") >>> >>> This commit support the new API. >> >> This patch does three things: >> 1- Convert bit-field Rx Offload information to new bitwise "offloads" variable. >> 2- Use new queue specific offload configuration for Rx/Tx >> 3- Enable new mbuf fast free Tx offload >> >> >> 1 and 2 can be classified as "convert to new ethdev offloads", but I am not >> sure about 3. > > I think all of the 3 should be in a single patch. > The reason is that the convert patch should maintain the same offloads configuration needed for the application. Perhaps I am missing some details about "mbuf fast free" offload, can you please give more details about it, what does having or not having it mean? Currently no PMD seems implemented it. > Before the convert patch the examples were using the default configuration set by the PMD. In there the txq flags were set to ignore ref count and to declare all mbufs are from the same pool. > The fast free Tx offload was added in order to keep this old offloads configuration. > >> >> Wouldn't be better to enable new offloadings in a separate patch, other than >> convert one? And I don't know if we want to enable that specific offload for >> all samples. > > As you can see, not all the examples has the FAST_FREE offloads, only the entitled ones (i.e. single mempool and no ref count). > For example, ipv4_multicast doesn't set this offload flag. >