From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16F06A04B8; Tue, 5 May 2020 18:26:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A10921D66E; Tue, 5 May 2020 18:26:50 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by dpdk.org (Postfix) with ESMTP id C74AD1D653 for ; Tue, 5 May 2020 18:26:48 +0200 (CEST) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 045G9CxR012220; Tue, 5 May 2020 12:26:48 -0400 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com with ESMTP id 30s4r4936p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 05 May 2020 12:26:48 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 045GK8SN016784; Tue, 5 May 2020 16:26:47 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma03dal.us.ibm.com with ESMTP id 30s0g78prt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 05 May 2020 16:26:47 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 045GQjQL30605772 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 May 2020 16:26:45 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4BEB4C605F; Tue, 5 May 2020 16:26:46 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D7DD6C6055; Tue, 5 May 2020 16:26:45 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.163.53.177]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 5 May 2020 16:26:45 +0000 (GMT) To: "Burakov, Anatoly" , dev@dpdk.org References: <20200429232931.87233-1-drc@linux.vnet.ibm.com> <20200429232931.87233-3-drc@linux.vnet.ibm.com> <6cbb170a-3f13-47ba-e0ad-4a86cd6cb352@intel.com> <6763793c-265b-c5cf-228a-b2c177574c84@linux.vnet.ibm.com> <58df8aa5-e9b5-7f9a-2aee-fcb19b6dea04@intel.com> <782d6f04-f476-93d6-1a8f-2ed0b39dde10@linux.vnet.ibm.com> <8f83778f-fe74-6c69-e2d0-73b9a6e7ca79@intel.com> From: David Christensen Message-ID: <4e7fa5f1-e2c7-a2e0-72d8-293c1cbc607b@linux.vnet.ibm.com> Date: Tue, 5 May 2020 09:26:44 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <8f83778f-fe74-6c69-e2d0-73b9a6e7ca79@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-05-05_09:2020-05-04, 2020-05-05 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxlogscore=999 clxscore=1015 priorityscore=1501 malwarescore=0 impostorscore=0 bulkscore=0 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005050124 Subject: Re: [dpdk-dev] [PATCH 2/2] vfio: modify spapr iommu support to use static window sizing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >>>>> That's not even mentioning the fact >>>>> that the user may register external memory for DMA which may cause >>>>> the window to be of insufficient size to cover said external memory. Regarding external memory, I can think of two obvious options: 1) Skip window sizing altogether if external memory is detected and assume the user has set things up appropriately. 2) Add an EAL command line option --iova-len that would allow the external memory requirements to be considered it required. I'll work on a new patch with (2) along with the other changes discussed and resubmit. Thanks for the feedback. Dave