From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 20A081B2B9; Fri, 26 Jan 2018 19:09:04 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jan 2018 10:09:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,417,1511856000"; d="scan'208";a="22569704" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by orsmga003.jf.intel.com with ESMTP; 26 Jan 2018 10:09:01 -0800 To: Tomasz Duszynski , dev@dpdk.org Cc: mw@semihalf.com, dima@marvell.com, nsamsono@marvell.com, Jianbo.liu@linaro.org, stable@dpdk.org References: <1516953322-26378-1-git-send-email-tdu@semihalf.com> From: Ferruh Yigit Message-ID: <4ebf425c-839b-1032-7051-6d5feeed7d2c@intel.com> Date: Fri, 26 Jan 2018 18:09:01 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1516953322-26378-1-git-send-email-tdu@semihalf.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mrvl: fix mbuf to bpool lookup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 18:09:06 -0000 On 1/26/2018 7:55 AM, Tomasz Duszynski wrote: > From: Natalie Samsonov > > Since in DPDK 17.11 port type was changed from uint8_t to uint16_t > the MBUF_INVALID_PORT value became 0xffff but in mrvl_tx_pkt_burst() > when trying to lookup bpool using mbuf port, we check if the port > is invalid according to value 0xff. This causes segmentation fault. > > Solution: since the valid port value cannot exceed RTE_MAX_ETHPORTS > (size of bpool lookup table) any other values consider as invalid so > the packet should be returned to DPDK pool. > > Fixes: afb4d0d0bf91 ("net/mrvl: add Rx/Tx support") > Cc: stable@dpdk.org > > Signed-off-by: Natalie Samsonov Applied to dpdk-next-net/master, thanks.