From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6BB2459AF; Tue, 17 Sep 2024 18:43:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4BF4E42686; Tue, 17 Sep 2024 18:43:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1069740261 for ; Tue, 17 Sep 2024 18:43:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726591401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Q2zhawvML2xLDArAn+TQcoxB1okDVJ+9vrHjaHTAyFM=; b=H6tryq4WDIhj203W/e07hNJ2cgFVB4IcLC9VZDnTVStrd0qzFP7Etl66sz4W39EKIK1Is/ EovuGhL31lVgCvjevcYqjhk5n2pSIWUhCigRxIugli4Ovrd6V5/6mTaUm1DnpPMg9KVbO8 sFAGo1b/hofv1JaBw5Lxr/oIQwK98k8= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-466-2iYDIlD3Os--KOwS9GTUnA-1; Tue, 17 Sep 2024 12:43:20 -0400 X-MC-Unique: 2iYDIlD3Os--KOwS9GTUnA-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a8d0d87f204so713128466b.1 for ; Tue, 17 Sep 2024 09:43:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726591399; x=1727196199; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q2zhawvML2xLDArAn+TQcoxB1okDVJ+9vrHjaHTAyFM=; b=vURKu13I9Hlg2S0DyCS8s7hxNbYXAz2ow3HduhP8klzltPZLC0lOb6x3K5qqqCjQO2 xblk2opWJ9sXKdYit/xKRYjFsVY6pOiCJ7rwy0VR/U7KaX688tHM7r+uwjofksAQSGo7 +pBhoOIhLQE2msGAWgi+21HVgxikTCX4L7+ixkRoEdgOIiPFW1tGm4m65EDmx58ll55+ uspmb2eNdixgV6Ny0JKY/VKZWOTbtYDJnMnLzAab31rkvbidH9YQhAv23OfJaO+IEwau hM7Jz3AhQasA7p7asqql9IHBDtzQy5Se6gkM9SAfI2C+5Tl13lq1TbFTp1c5omS8Sixr rNXA== X-Gm-Message-State: AOJu0Yyf61e4I4Jz2Sb3xtyvJSjQWkHgOqAEJVRcVfjr0Q6IEhrZke0E j2pO67ZEsGyVjLYVkfChrSrybsKy0K0kkwBQz0M5oE9lvV5BfgocfaWGZ64eYDWAcB3Wo3U1ydf Wgd3UlPEU95K7rVI0P/LQub+kdfufg4zpbP3YsTJP X-Received: by 2002:a17:907:6e87:b0:a8d:3fb6:33df with SMTP id a640c23a62f3a-a902a41fbc3mr2071455866b.8.1726591399003; Tue, 17 Sep 2024 09:43:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElN0risIfW5JT+u6ZZL8VQdT4/RD9in6CTpwDuprZFkaFmuLl490urMcEEVto+YL5oIkoECg== X-Received: by 2002:a17:907:6e87:b0:a8d:3fb6:33df with SMTP id a640c23a62f3a-a902a41fbc3mr2071451566b.8.1726591398294; Tue, 17 Sep 2024 09:43:18 -0700 (PDT) Received: from [192.168.0.36] ([78.17.184.219]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a90613205b8sm464043266b.188.2024.09.17.09.43.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Sep 2024 09:43:17 -0700 (PDT) Message-ID: <4ebf99cf-3d0e-4561-bd2e-87871a53d243@redhat.com> Date: Tue, 17 Sep 2024 17:43:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: 21.11.8 patches review and test To: Ali Alnubani , "stable@dpdk.org" Cc: "dev@dpdk.org" , Abhishek Marathe , Hemant Agrawal , Ian Stokes , Jerin Jacob , John McNamara , Ju-Hyoung Lee , Luca Boccassi , Pei Zhang , Raslan Darawsheh , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "yanghliu@redhat.com" References: <20240905123816.3087619-1-ktraynor@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 17/09/2024 17:21, Ali Alnubani wrote: >> -----Original Message----- >> From: Kevin Traynor >> Sent: Tuesday, September 17, 2024 7:14 PM >> To: Ali Alnubani ; stable@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Hemant Agrawal ; Ian Stokes >> ; Jerin Jacob ; John McNamara >> ; Ju-Hyoung Lee ; Luca >> Boccassi ; Pei Zhang ; Raslan >> Darawsheh ; NBU-Contact-Thomas Monjalon (EXTERNAL) >> ; yanghliu@redhat.com >> Subject: Re: 21.11.8 patches review and test >> >> On 11/09/2024 14:10, Ali Alnubani wrote: >>>> -----Original Message----- >>>> From: Kevin Traynor >>>> Sent: Wednesday, September 11, 2024 3:20 PM >>>> To: Ali Alnubani ; stable@dpdk.org >>>> Cc: dev@dpdk.org; Abhishek Marathe ; >>>> Hemant Agrawal ; Ian Stokes >>>> ; Jerin Jacob ; John McNamara >>>> ; Ju-Hyoung Lee ; Luca >>>> Boccassi ; Pei Zhang ; Raslan >>>> Darawsheh ; NBU-Contact-Thomas Monjalon >>>> (EXTERNAL) ; yanghliu@redhat.com >>>> Subject: Re: 21.11.8 patches review and test >>>> >>>> On 10/09/2024 20:12, Ali Alnubani wrote: >>>>>> -----Original Message----- >>>>>> From: Kevin Traynor >>>>>> Sent: Friday, September 6, 2024 12:53 PM >>>>>> To: Ali Alnubani ; stable@dpdk.org >>>>>> Cc: dev@dpdk.org; Abhishek Marathe >>>> ; >>>>>> David Christensen ; Hemant Agrawal >>>>>> ; Ian Stokes ; Jerin >>>> Jacob >>>>>> ; John McNamara ; Ju- >>>>>> Hyoung Lee ; Luca Boccassi ; >>>> Pei >>>>>> Zhang ; Raslan Darawsheh ; >>>> NBU- >>>>>> Contact-Thomas Monjalon (EXTERNAL) ; >>>>>> yanghliu@redhat.com >>>>>> Subject: Re: 21.11.8 patches review and test >>>>>> >>>>>> On 05/09/2024 15:02, Kevin Traynor wrote: >>>>>>> On 05/09/2024 14:29, Ali Alnubani wrote: >>>>>>>>> -----Original Message----- >>>>>>>>> From: Kevin Traynor >>>>>>>>> Sent: Thursday, September 5, 2024 3:38 PM >>>>>>>>> To: stable@dpdk.org >>>>>>>>> Cc: dev@dpdk.org; Abhishek Marathe >>>> ; >>>>>> Ali >>>>>>>>> Alnubani ; David Christensen >>>>>> ; >>>>>>>>> Hemant Agrawal ; Ian Stokes >>>>>>>>> ; Jerin Jacob ; John >>>> McNamara >>>>>>>>> ; Ju-Hyoung Lee ; >>>>>> Kevin >>>>>>>>> Traynor ; Luca Boccassi ; >>>> Pei >>>>>> Zhang >>>>>>>>> ; Raslan Darawsheh ; >>>> NBU- >>>>>>>>> Contact-Thomas Monjalon (EXTERNAL) ; >>>>>>>>> yanghliu@redhat.com >>>>>>>>> Subject: 21.11.8 patches review and test >>>>>>>>> >>>>>>>>> Hi all, >>>>>>>>> >>>>>>>>> Here is a list of patches targeted for stable release 21.11.8. >>>>>>>>> >>>>>>>>> The planned date for the final release is 18th September. >>>>>>>>> >>>>>>>>> Please help with testing and validation of your use cases and report >>>>>>>>> any issues/results with reply-all to this mail. For the final release >>>>>>>>> the fixes and reported validations will be added to the release notes. >>>>>>>>> >>>>>>>>> A release candidate tarball can be found at: >>>>>>>>> >>>>>>>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.8-rc1 >>>>>>>>> >>>>>>>>> These patches are located at branch 21.11 of dpdk-stable repo: >>>>>>>>> https://dpdk.org/browse/dpdk-stable/ >>>>>>>>> >>>>>>>>> Thanks. >>>>>>>>> >>>>>>>>> Kevin >>>>>>>>> >>>>>>>>> --- >>>>>>>> >>>>>>>> Hi Kevin, >>>>>>>> >>>>>>>> I see this build failure in Debian 12 and Fedora 40: >>>>>>>> >>>>>>>> $ meson --werror --buildtype=debugoptimized build && ninja -C build >>>>>>>> [..] >>>>>>>> drivers/net/softnic/rte_eth_softnic_meter.c:916:25: error: 's' may be >>>> used >>>>>> uninitialized [-Werror=maybe-uninitialized] >>>>>>>> >>>>>>>> Will update with the rest of our functional testing later during the next >>>> couple >>>>>> of weeks. >>>>>>>> >>>>>>>> Regards, >>>>>>>> Ali >>>>>>> >>>>>>> ok, thanks. I will check it out. >>>>>> Hi Ali, >>>>>> >>>>>> It looks like a false positive, as the stats [0] are initialised in >>>>>> mtr_stats_convert() before they are used. The code is unchanged since >>>>>> the last release so probably it's compiler/distro change for this release. >>>>>> >>>>>> I've built with this meson command using latest gcc and clang on a F40 >>>>>> and not seeing this issue [1]. >>>>>> >>>>>> Are you using same compiler versions ? Any other details needed to >>>>>> reproduce ? >>>>>> >>>>>> thanks, >>>>>> Kevin. >>>>>> >>>>>> [0] >>>>>> https://git.dpdk.org/dpdk- >>>>>> stable/tree/drivers/net/softnic/rte_eth_softnic_meter.c?h=21.11#n906 >>>>>> >>>>>> [1] >>>>>> $ clang --version >>>>>> clang version 18.1.6 (Fedora 18.1.6-3.fc40) >>>>>> $ gcc --version >>>>>> gcc (GCC) 14.2.1 20240801 (Red Hat 14.2.1-1) >>>>>> >>>>>> commit 680818068d31764357075cde440232ce5ab8b786 (HEAD -> >>>> 21.11, tag: >>>>>> v21.11.8-rc1, origin/21.11) >>>>>> Author: Kevin Traynor >>>>>> Date: Thu Sep 5 10:34:16 2024 +0100 >>>>>> >>>>>> version: 21.11.8-rc1 >>>>>> >>>>>> e.g. >>>>>> $ meson --werror --buildtype=debugoptimized build-gcc >>>>>> ... >>>>>> $ ninja -C build-gcc >>>>>> ninja: Entering directory `build-gcc' >>>>>> [3071/3071] Linking target app/test/dpdk-test >>>>>> >>>>>> >>>>>> >>>>>>> Kevin. >>>>> >>>>> Hi Kevin, apologies for the late response, >>>>> >>>>> The build failure doesn't reproduce for me on some environments either. >>>>> I tried to compare the log of 2 builds (one that reproduced, and one that >>>> didn't), and the only difference I saw was related to AVX512 support. >>>>> >>>>> Build passed on an AMD EPYC 7713 system (3rd Gen EPYC, no AVX512 >>>> support): >>>>> [..] >>>>> Fetching value of define "__AVX512BW__" : (undefined) >>>>> Fetching value of define "__AVX512CD__" : (undefined) >>>>> Fetching value of define "__AVX512DQ__" : (undefined) >>>>> Fetching value of define "__AVX512F__" : (undefined) >>>>> Fetching value of define "__AVX512VL__" : (undefined) >>>>> [..] >>>>> >>>>> Build failed on an AMD EPYC 9654P system (4th Gen EPYC, has AVX512 >>>> support): >>>>> [..] >>>>> Fetching value of define "__AVX512BW__" : 1 >>>>> Fetching value of define "__AVX512CD__" : 1 >>>>> Fetching value of define "__AVX512DQ__" : 1 >>>>> Fetching value of define "__AVX512F__" : 1 >>>>> Fetching value of define "__AVX512VL__" : 1 >>>>> [..] >>>>> >>>>> The build failure doesn't reproduce for me on 22.11 and newer versions. >>>>> >>>> >>>> Yes, that function is not present in later versions. I don't have easy >>>> access to an AVX512 enabled system but it should be a simple fix. >>>> >>>> Would you be able to try with the below ? >>>> >>>> --- a/drivers/net/softnic/rte_eth_softnic_meter.c >>>> +++ b/drivers/net/softnic/rte_eth_softnic_meter.c >>>> @@ -904,5 +904,5 @@ pmd_mtr_stats_read(struct rte_eth_dev *dev, >>>> /* Stats format conversion. */ >>>> if (stats || stats_mask) { >>>> - struct rte_mtr_stats s; >>>> + struct rte_mtr_stats s = {0}; >>>> uint64_t s_mask = 0; >>>> >>> >>> Build passes with this change, thanks! >>> >> >> Hi Ali, >> >> Unfortunately gcc on RHEL/CentOS 7, doesn't like this with -Wextra, >> according to godbolt. I'm just going to fix with an explicit memset [0], >> so we don't go in circles with compiler versions/options. >> >> Regarding other validation, is there any update on status or ETA ? >> > > Hi Kevin, > > Apologies for the delay, it was due to PTO and recent holidays. > No new issues so far. I was planning on sending my report early tomorrow. > Great, thanks for the update. > Regards, > Ali