From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D84331CB70 for ; Thu, 5 Apr 2018 14:02:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2018 05:02:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,411,1517904000"; d="scan'208";a="214151244" Received: from tanjianf-mobl.ccr.corp.intel.com (HELO [10.255.27.107]) ([10.255.27.107]) by orsmga005.jf.intel.com with ESMTP; 05 Apr 2018 05:02:43 -0700 To: "Pattan, Reshma" , "dev@dpdk.org" References: <1520175844-55443-1-git-send-email-jianfeng.tan@intel.com> <1522854488-59678-1-git-send-email-jianfeng.tan@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A2C023A@irsmsx110.ger.corp.intel.com> From: "Tan, Jianfeng" Message-ID: <4edca215-ab68-0a98-6953-ad729731bba0@intel.com> Date: Thu, 5 Apr 2018 20:02:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2C023A@irsmsx110.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] pdump: change to use generic multi-process channel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 12:02:46 -0000 Sorry, it seems that I missed this email. On 4/5/2018 5:45 PM, Pattan, Reshma wrote: > Hi > >> Signed-off-by: Jianfeng Tan >> --- >> Note this patch needs this patch set: >> http://dpdk.org/dev/patchwork/patch/36814/ >> v2: >> - Update doc for deprecation of API, rte_pdump_set_socket_dir, >> and API change for rte_pdump_init. >> - Add notice for known incompatibility issue in doc. >> app/pdump/main.c | 6 +- >> doc/guides/rel_notes/deprecation.rst | 4 + >> doc/guides/rel_notes/release_18_05.rst | 7 + >> lib/librte_pdump/Makefile | 3 +- >> lib/librte_pdump/rte_pdump.c | 423 +++++---------------------------- >> lib/librte_pdump/rte_pdump.h | 1 + >> 6 files changed, 84 insertions(+), 360 deletions(-) >> diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c >> + >> > >> + >> + /* recv client requests */ >> + if (mp_msg->len_param != sizeof(*cli_req)) { >> + RTE_LOG(ERR, PDUMP, "failed to recv from client\n"); >> + resp->err_value = EINVAL; > resp->err_value = -EINVAL OK, this keeps consistent with other places in this file. > >> - /* save the socket in local configuration */ >> - pdump_socket_fd = socket_fd; >> + snprintf(mp_resp.name, RTE_MP_MAX_NAME_LEN, PDUMP_MP); >> + mp_resp.len_param = sizeof(*resp); >> + mp_resp.num_fds = 0; >> + if (rte_mp_reply(&mp_resp, peer) < 0) >> + RTE_LOG(ERR, PDUMP, "failed to send to client:%s, %s:%d\n", >> + strerror(rte_errno), __func__, __LINE__); >> > If failed to send the reply should'nt we return -1? Yes, will fix it. > >> return 0; >> } >> >> int >> -rte_pdump_set_socket_dir(const char *path, enum rte_pdump_socktype >> type) >> +rte_pdump_set_socket_dir(const char *path __rte_unused, >> + enum rte_pdump_socktype type __rte_unused) >> { > What about enum rte_pdump_socktype in header file? When to delete them? Will deprecate it. > > We need to update doxygen comments in header file for rte_pdump_init and rte_pdump_uninit()? What do you say. I'll try to find a flag for deprecating a param. If you know how to do that, please let me know. Thanks, Jianfeng > > Thanks, > Reshma