From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0087.outbound.protection.outlook.com [104.47.41.87]) by dpdk.org (Postfix) with ESMTP id F03F11B651 for ; Mon, 16 Oct 2017 13:30:30 +0200 (CEST) Received: from CY4PR03CA0099.namprd03.prod.outlook.com (10.171.242.168) by CY4PR03MB2695.namprd03.prod.outlook.com (10.173.43.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 16 Oct 2017 11:30:29 +0000 Received: from BY2FFO11FD044.protection.gbl (2a01:111:f400:7c0c::190) by CY4PR03CA0099.outlook.office365.com (2603:10b6:910:4d::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.77.21 via Frontend Transport; Mon, 16 Oct 2017 11:30:29 +0000 Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD044.mail.protection.outlook.com (10.1.14.229) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Mon, 16 Oct 2017 11:30:29 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9GBURTO028108; Mon, 16 Oct 2017 04:30:27 -0700 From: Shreyansh Jain To: Gaetan Rivet CC: References: <49446c2cba12cd5da276bfde8479aa97dcf0f653.1507796100.git.gaetan.rivet@6wind.com> <39e734ea-531c-6335-f1d5-22c75fe38f9e@nxp.com> Message-ID: <4f3a6e5e-65ea-4cef-1146-3b91943ec5c7@nxp.com> Date: Mon, 16 Oct 2017 17:12:37 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <39e734ea-531c-6335-f1d5-22c75fe38f9e@nxp.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131526270294612118; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(376002)(346002)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(377454003)(24454002)(199003)(189002)(36756003)(69596002)(31686004)(104016004)(97736004)(65826007)(5660300001)(316002)(498600001)(47776003)(65956001)(65806001)(58126008)(356003)(64126003)(83506001)(2906002)(2870700001)(305945005)(50466002)(6246003)(81166006)(8676002)(81156014)(6666003)(575784001)(86362001)(4326008)(6916009)(2950100002)(77096006)(93886005)(23676002)(106466001)(229853002)(53936002)(8936002)(105606002)(33646002)(50986999)(68736007)(31696002)(189998001)(54356999)(76176999); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2695; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD044; 1:P3HcmWLU3L90tmBGUc2CHHnJjx9/tCNzyaJmftxg/brsyieATUdGA9Czh7TVRd9XqP9CZq1uU2rNAs1DaDrCCN3nZY5l0Y3cdmVNIPAOZD2q8sOkLe0/9iDXTDJnfQVA X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 95728cd1-ab48-47ef-cd8e-08d514894dee X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CY4PR03MB2695; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2695; 3:JqWJkITKGHO3lYjHQ3PSNs46yPCo2AtPblKaob+WUsIQKDRrW/SyXx2f01BFl2bT3xGp0LDXGPQjg2WPSbf4qCVr0pwZ568lNeGjm1lrqzemcPcPnr0YZGEFph5zEcJ5KmnxNt7zMsu1TnQ6XoOY2YH7RUiANesoKSG1s3C+FwwLM6zYWt0OdN+5SCJP/8FMPFi6R9w82R0ZdwgM52WrcYPDFDraF4zxMbxepvULzPGncVcdAL4sjiHknb6ZTe8lpF0KRY0DG8ChNxBRC1z+k6Lp3bLsqxMeQnrWXcrsoqZow/AcWQC1KIdjorCyBQWErm9Hh2abNEjw5Vy1kiKpJzi3mapYz6RAFWtorVhtSeI=; 25:tH+oDC1v1H4cVd8R1m9vxNdrWd8aOLpAaJ9mkEyHJ4wnlnxu+L2x+ukHob7n26AXNbie4RRNa2DKC8squI0D3m0TTBZkJpKSu3fydDLsKHt0RJiTWkHlcX6A5tIF5oNd0WQU0o3CksbO9GsLD8A2/INyw9Ld43X97TU7kraJZiRxw6swuOiTiPTJh90yXyvflrkKq+6+oTljzwkBvQdFL7fdR5FovYdNjLYQhvHkpJZmlyp3y13nb04P+btXb5b9CPIHtgGpMS3ERPojBwPtDWKRD7CksvE6swBmaaHI0sw9vKkM8z3R1PSizto0x1XI5QDH92a4JRZ0UvwZTcPORA== X-MS-TrafficTypeDiagnostic: CY4PR03MB2695: X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2695; 31:MyKPi7DbMdhyeBA+yzLn98/wW4Ox0Pj3Aw+nMEazMVy25F9g3pmRs8O64E0gjMa0AI2OOQm7cO8Ul3tq+E0/k1l9Rjng/wwqb8uvxND6452lFBM5PH+iKq1wq2oL17d8mvDhR38cQfuJLLA0+e/7mSnjinRzcSYUnZXX1i1+LP/A7b56JZQW6f3tBn9iyQqKxMOIUoENDcgrtbCZPXtMgaQ47IKynvb/n5CzoBNFKBA=; 4:4XXzTJSesEX0xvrorILbWiR0gLXWAIwjQ3RjWz/J45VyQ2d8Sbl1fb8G/gni2bp7+Uw5t0Vk/IdjM9udcXpyMs0Y3LHbNdXjqME+6M/VNSnCBFBAcnnShgFMsKw7rpAOVxgooakfBi+XYTv2vjaY7nXqhSObAtaTvgt4MqMQ4wdIIYlrMU6Ath8NTK26CkTZR/fuByF2NpR9Z6XYS9ubvqhqVrrES6H+Ty1Rz7W5vWTLtq3ZO8B6D4EZc3hwPDx2 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123561025)(20161123556025)(20161123559100)(20161123563025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR03MB2695; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR03MB2695; X-Forefront-PRVS: 0462918D61 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjAzTUIyNjk1OzIzOm9lb1JCZDl1RjZ5OFNtOHQvK05SRlF3UWkx?= =?utf-8?B?cmwrSDk5TllsSWx5MUVBekNlUTRlU05yRCs0clRBaTNqMFFTcDR3S0hwT0pF?= =?utf-8?B?THFiT2svR2RLVkJ4OXhHRUxxaGJaWjdRZkZZK2NSMzJCclkvdzBZcE1vRjAy?= =?utf-8?B?bkZERHp1a1RBdDB5SEkwdnRjOXdnSlpOQjZWdjYvMmFRYW1YVWV1ZnNvWVg0?= =?utf-8?B?b05mczhHY1VCNUo0M1pyRVNuUmpLTHNHVEh4UW40WkRFMHBsNzE1VFhPU2JS?= =?utf-8?B?Q0pub3NvMHUwOFZvbVpwVi9zSVQ4RmZpMUY5SHQvMXdjM3lObEVyN0hia2Nz?= =?utf-8?B?S0ZMcjc3TGorTDk5S0RLaituc0V0YkJOTVlEWUE0cGZyVXJlVnBKa0dUOCtM?= =?utf-8?B?bitPYkpkaXR3ZFJyek1DVEc1T3YvRGVwaHNKemp6SllQWStHN1FYSERTaHU4?= =?utf-8?B?bUhsK29KNEZFYmFFamh0Smp1NENzOUZiczlJUklNV0d1Y1M0R3hLbEhLaEx5?= =?utf-8?B?YllGZEhrNlhVOGNNVWh6UXRpNEsvT0l4UkJtMmc1TzJDdFBKa1ozWkxycHJ5?= =?utf-8?B?MTRZYWYyZUF6aFI5bUM5Y0U2U2poOGFjVlRiT2l3SFI3K2IyMkNhOFRSckhz?= =?utf-8?B?MkJMazZITExONHlwOTZvM0ZocExrNWVPdXhNc2I4MFk1c2hwdktrcDNpUCtZ?= =?utf-8?B?TmNZRXMyZzBuWEFoZDJCZWJSTnRWVWdPZ3ZWeHBadmhacXJqMUJ2VHNrNTdr?= =?utf-8?B?bVo0QzVhdHB1aElhb2VwMHM0NG5zTGxFRXRVVjJRV3JzUjI3L01FUnJkSXNa?= =?utf-8?B?b013TGV3TlV2U3l1dXNGRDIvakQvd1pGVTFPcVFYbXJFSnYvN25hZWlSdmFJ?= =?utf-8?B?MTRTaUNKNkd4T3hJZ0J1K3dGVGNzN1ZydFc4SEFBclQ3Uys4eC9wK1hNenln?= =?utf-8?B?UDVXMGVpa2pGWjRNUk1TV1BWTUJmRzhGZitPWlJQdlZsUmNiSW56cUpFY2VJ?= =?utf-8?B?Z2ZveGd6NkFyb21jOHZLT081ODQvMklFMXA2M0JUSDVrdTFIUFNWVGRaampI?= =?utf-8?B?dDRhQ2JrS3lWTmpZUFRkUy9QWFFqMXI3dGRvQnJXem03YjUvY3lsd0MraFhv?= =?utf-8?B?dVA0TjBNYzFpREo2QXl0RUNUUUxrUVYzV2JnRHlNMDkxUHZqcDFhMnhiTmtO?= =?utf-8?B?MzM2dVVBQU1oeFo0UmhiaXpNRkdlamFDU3l5VFg4Y1MrZWhPUHBVSCszdmVR?= =?utf-8?B?WjhuM3B4MjV1ZFNJQUlXNnl5YWJUTi9HcTVPR1pvY082UlZaV1VJRWZjMVVp?= =?utf-8?B?cVd3aEFPLy96ZGpKa1NhRTlzZS95bU1IVnplSVNyU09YZXZ3dEpVKzJGcHUv?= =?utf-8?B?cGw3a2VKSDZTVWdMVUxOVmdreEovd29vLzhtc2Y3bnROUzdncHd3VWoyWUpP?= =?utf-8?B?MzVzbFpRcHIvWmNsV0xneHA5dDB4elZpY3VYVERKanZvc2NtdTR4NmFpb0Vr?= =?utf-8?B?b2xsMm5TVXFvc29ROUczRndoOGV5RDF2Z3lXUzl2bERBRmR4R0wzSzBCbHJw?= =?utf-8?B?NFFQUXkwQmlQVGxZOUMrVnpDSHlJOGxYS0VXT3BpMVp4Tm9SVmhrejczWG55?= =?utf-8?B?WXRSbTlMVlFtMEsrWUxjY1llOS9sTVc1bldhZWNUYS9aSXFHc0dyZUhBNXlH?= =?utf-8?B?MnlScXAvNUNTWGxJRFdhdElrT20vSzVhSjIzZFdma1JuaVh3SndSYW9qVEpz?= =?utf-8?B?MFFFNkJwTHo4UEVwY2RUZUJjeG5TNGdDZVhza1BQTzl5MHRrZmJtTDhMV003?= =?utf-8?B?bVlzWWpZUzJVV1pIelZSakN5UXRmQVZBNk9WWDl5cU9LRCtyMk9wbjNiMlRa?= =?utf-8?Q?Iq4R4easKv4=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2695; 6:9rjrbuQ/WG9rG3T1FLUHKBL0P3do0mkxgrGl8iVUnIvBT9WFz05ItOpDp+UVmdRvLq20Iu2Axg8a7EFVWacIZXjZ3nhVuZKNDeYY6l6uwA76ay3gAeDbXhB+2EoXof/DyqEuclwWrTE6hnfLLKzANHze3qlMtl1W7qbl16UspOJW5CkVOPELPoRZei7BqxJRC59XnCXL20f7N1GFpyUziv7vxUvUihnQqUy10kxzSyq7s+bQboRX5Jhs2n0jjduFFVx7yoJ+vjEHIi0JQju08bnDtv0ZW/CiZ+/qAfd35XkQtwEc+ONN//x35thegDvSWvpAxPjx6vn4tB/VPwkP/w==; 5:1XBUIHvnVAloRIU0ou5PHvDoxX3CGAVJtTl5xRM85VAybKjAvBVV/HyGFDZbxMen2Aou3EmzKl2q3jQeXjPj45qhoqQJ5V9VxGzvGLokFTeyZTXhG0BMGqHftF2SZ9wVt0aDIbR7NxbsBbhlYeE6O4UqRtEDd7IGS0qBvVxEr2M=; 24:YfNh5qsEUfbwiHm7c8kDeahZ/5iL2H1AbHb6p30jaMnHpU2FH7ZbVEHI0nu+RVo5b2b+iH31bMnkX0BBDc5WwzDYOaBcuAcU0fS4S++vEvI=; 7:Updm2SonJxCY/6qwPp9x8p6l6kJqfJ81Cu3sGhobA4jtCXNWo0RWUutcNO1h29FlnWPAFfaNTPBnEI2hAl2hwvdKxY5E4wzppZ/pL89p5A7mJplrOX6EqaxT8FdeFOQjSjvhQp4GZw+UgPOsQhFY8UJWmjKaaXwhWNJg7YULwrriod++WLrbQFUwn4J4xZyET3ByJUZXjd1OVFRF6jFcOg24fATWASf7S9oaOs686Jw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 11:30:29.2272 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2695 Subject: Re: [dpdk-dev] [PATCH v2 11/18] devargs: simplify implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 11:30:31 -0000 Hello Gaetan, Please ignore this email (reason inline) On Monday 16 October 2017 05:09 PM, Shreyansh Jain wrote: > Hello Gaetan, > > On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote: >> Re-use existing code, remove incorrect comments. >> >> Signed-off-by: Gaetan Rivet >> --- >>   lib/librte_eal/common/eal_common_devargs.c | 8 +++----- >>   1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/lib/librte_eal/common/eal_common_devargs.c >> b/lib/librte_eal/common/eal_common_devargs.c >> index 49cc3b8..1d87cd9 100644 >> --- a/lib/librte_eal/common/eal_common_devargs.c >> +++ b/lib/librte_eal/common/eal_common_devargs.c >> @@ -153,21 +153,19 @@ rte_eal_devargs_insert(struct rte_devargs *da) >>       return 0; >>   } > > While trying to work on this patch, I noticed that the complete series > (including "Move PCI away from EAL") is not cleanly applicable on > current master (17.11 RC1). I thought it would be some tiny issues. > > But there are some issues which I couldn't pass, Like... > >> -/* store a whitelist parameter for later parsing */ >>   int > > In the this function > >> -rte_eal_devargs_add(const char *devargs_str) >> +rte_eal_devargs_add(const char *dev) >>   { >>       struct rte_devargs *devargs = NULL; >> -    const char *dev = devargs_str; >> -    /* use calloc instead of rte_zmalloc as it's called early at init */ >>       devargs = calloc(1, sizeof(*devargs)); >>       if (devargs == NULL) >>           goto fail; >>       if (rte_eal_devargs_parse(devargs, "%s", dev)) >>           goto fail; > > These lines don't exist in your patch > > --- > 59c2ba6c 172)   if (bus->conf.probe_mode == RTE_BUS_PROBE_UNDEFINED) { > b631f3b0 173)           if (devargs->policy == RTE_DEV_WHITELISTED) > 59c2ba6c 174)                   bus->conf.probe_mode = > RTE_BUS_PROBE_WHITELIST; > b631f3b0 175)           else if (devargs->policy == RTE_DEV_BLACKLISTED) > 59c2ba6c 176)                   bus->conf.probe_mode = > RTE_BUS_PROBE_BLACKLIST; > 02823c1d 177)   } > bf6dea0e 178)   TAILQ_INSERT_TAIL(&devargs_list, devargs, next); > bf6dea0e 179)   return 0; > 0215a4c6 180) > --- > (Some introduced by the move PCI series, but others like b631f3b0 are > very old ~17.08) > > >> -    TAILQ_INSERT_TAIL(&devargs_list, devargs, next); >> +    if (rte_eal_devargs_insert(devargs)) >> +        goto fail; > > And hence, I don't know whether you intend to insert the above line > after or before checking PROBE. > >>       return 0; >>   fail: >> > > Maybe I am doing something wrong here - any ideas? Can you send an > updated/rebased version on current master HEAD? Just after sending this, I noticed that I had not applied the "Bus control framework" patch set which the "devargs..." cover letter talks about. I will try with that and confirm if there is still any issue. > > - > Shreyansh >