From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 43BCCA00C3;
	Sat,  2 Jul 2022 10:22:56 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D87BE40E03;
	Sat,  2 Jul 2022 10:22:55 +0200 (CEST)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
 by mails.dpdk.org (Postfix) with ESMTP id 04DFB40A83
 for <dev@dpdk.org>; Sat,  2 Jul 2022 10:22:54 +0200 (CEST)
Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.53])
 by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LZlRL74Ksz9ssQ;
 Sat,  2 Jul 2022 16:22:06 +0800 (CST)
Received: from [10.67.103.235] (10.67.103.235) by
 kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.24; Sat, 2 Jul 2022 16:22:50 +0800
Subject: Re: [PATCH v4] app/procinfo: add device private info dump
To: Thomas Monjalon <thomas@monjalon.net>, "Min Hu (Connor)"
 <humin29@huawei.com>
References: <20220602062216.25372-1-humin29@huawei.com>
 <20220606143932.12772-1-liudongdong3@huawei.com> <5278982.anssfa2V6d@thomas>
CC: <dev@dpdk.org>, <stephen@networkplumber.org>, <ferruh.yigit@amd.com>,
 <reshma.pattan@intel.com>, <mtahhan@redhat.com>, Maryam Tahhan
 <maryam.tahhan@intel.com>
From: Dongdong Liu <liudongdong3@huawei.com>
Message-ID: <4f5162cb-eadb-06da-2f92-45e49f982d26@huawei.com>
Date: Sat, 2 Jul 2022 16:22:49 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <5278982.anssfa2V6d@thomas>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.103.235]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 kwepemi500017.china.huawei.com (7.221.188.110)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Thomas

On 2022/6/26 23:50, Thomas Monjalon wrote:
> 06/06/2022 16:39, Dongdong Liu:
>> From: "Min Hu (Connor)" <humin29@huawei.com>
>>
>> This patch adds support for dump the device private info from a running
>> application. It can help developers locate the problem.
>>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
>> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
>
> Applied, thanks.
>
> [...]
>>  /**< Enable show port. */
>>  static uint32_t enable_shw_port;
>> +/**< Enable show port private info. */
>> +static uint32_t enable_shw_port_priv;
>
> That's very strange this file is using some (wrong) doxygen syntax.
> I'll fix this one when applying.
Many thanks for fixing it.
> A cleanup may be needed for other comments in the file.
Will do.

Thanks,
Dongdong
>
>>  /**< Enable show tm. */
>>  static uint32_t enable_shw_tm;
>>  /**< Enable show crypto. */
>
>
>
> .
>