From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE692A0032; Thu, 12 May 2022 09:21:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE89240E64; Thu, 12 May 2022 09:21:15 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id BDAD14014F for ; Thu, 12 May 2022 09:21:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652340073; x=1683876073; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0uHP7+39PRXSJVMa+VPpJAg9DkvB29scNSHGBFGdhks=; b=aHQ1fhq4gFY12OaTyLeSjMLvf1YPo3A2Nry1nZ+hK17becVE4JlYMSyQ nC5rJ4l6b3iZlj2NZOXcGP8LfQerhJ/7zcAAyO5EaZVk7ywDn1t1KFf2y 67JT/Qe7VBkPET3Ik7xKZq8IgNi/j+8ftQRHVTb9n0XcNg9Ru/E4Rfyau VgUUIwChB8rqLiKoqjybqVt3r/6KxByi7v1CK46JS+Qq87Dv3M1Q9zkYR F0Gd8R8pGAY0b4RowsFNqwaMHlx5KGbyhR+kjI030d8XWsuMN7vTV9MS2 GcTyaE07Ufybr5vLWeqnjmlFGCIVXILqMkaOE0BvWWjII6FXW6KwSkgIi Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10344"; a="332957629" X-IronPort-AV: E=Sophos;i="5.91,219,1647327600"; d="scan'208";a="332957629" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2022 00:21:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,219,1647327600"; d="scan'208";a="520843464" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 12 May 2022 00:21:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 12 May 2022 00:21:04 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 12 May 2022 00:21:04 -0700 Received: from fmsmsx612.amr.corp.intel.com ([10.18.126.92]) by fmsmsx612.amr.corp.intel.com ([10.18.126.92]) with mapi id 15.01.2308.027; Thu, 12 May 2022 00:21:03 -0700 From: "Zhang, Qi Z" To: Thomas Monjalon CC: "Wu, Wenjun1" , "dev@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH v1] net/iavf: fix resource leak issue Thread-Topic: [PATCH v1] net/iavf: fix resource leak issue Thread-Index: AQHYZAuwVaVdh/pZMk2oX19VCKhiva0ZkVRQgACpV4D//5UiAIAA1mAA//+8rICAAOgKgP//jahA Date: Thu, 12 May 2022 07:21:03 +0000 Message-ID: <4f57fe1f407d4cec8d506fdf3339d645@intel.com> References: <20220510005425.1648591-1-wenjun1.wu@intel.com> <4349564.Wku2Vz74k6@thomas> <2f3663f9e4bf4c4d9c3993cabe57bcc5@intel.com> <1891945.fIoEIV5pvu@thomas> In-Reply-To: <1891945.fIoEIV5pvu@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, May 12, 2022 3:07 PM > To: Zhang, Qi Z > Cc: Wu, Wenjun1 ; dev@dpdk.org; Wu, Jingjing > ; Xing, Beilei > Subject: Re: [PATCH v1] net/iavf: fix resource leak issue >=20 > 12/05/2022 02:20, Zhang, Qi Z: > > > > > -----Original Message----- > > > From: Thomas Monjalon > > > Sent: Thursday, May 12, 2022 5:17 AM > > > To: Wu, Wenjun1 ; Zhang, Qi Z > > > > > > Cc: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > > > > > Subject: Re: [PATCH v1] net/iavf: fix resource leak issue > > > > > > 11/05/2022 17:31, Zhang, Qi Z: > > > > From: Thomas Monjalon > > > > > 11/05/2022 13:46, Zhang, Qi Z: > > > > > > From: Wu, Wenjun1 > > > > > > > > > > > > > > This patch fixes resource leak issue reported by coverity. > > > > > > > > > > > > > > Coverity issue: 378017 > > > > > > > Fixes: b14e8a57b9fe ("net/iavf: support quanta size > > > > > > > configuration") > > > > > > > > > > > > > > Signed-off-by: Wenjun Wu > > > > > > > > > > > > Acked-by: Qi Zhang > > > > > > > > > > > > Applied to dpdk-next-net-intel. > > > > > > > > > > In the title, the word "issue" is useless. > > > > > It would be more interesting to precise where is the leak. > > > > > > > > > > > > > Added below into commit log in dpdk-next-net-intel. > > > > > > > > kvlist should be freed before return an error due to invalid quanta= size. > > > > > > It does not explain what is the scenario. What is the impacted featur= e? > > > > I think the scenario has been explained as > > > > "kvlist should be freed before return an error due to invalid quanta si= ze" > > the impact has been mentioned as "resource leak" I guess this is how > > Coverity describe the issue >=20 > No, it does not say how to reproduce (the scenario). > We have no idea where it is in the code. set an invalid quanta size from devargs will reproduce the issue >=20 >=20