From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A524A0C4C; Tue, 5 Oct 2021 16:43:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08B5A41344; Tue, 5 Oct 2021 16:43:20 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 32F024133E for ; Tue, 5 Oct 2021 16:43:17 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="289266073" X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="289266073" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 07:42:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="589382588" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 05 Oct 2021 07:42:54 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 5 Oct 2021 07:42:54 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 5 Oct 2021 07:42:54 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 5 Oct 2021 07:42:54 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 5 Oct 2021 07:42:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X7g7Q+Mt566a9Wf6norx23o6yTPBKgvRuPuyYuDBxuoQwfB8askUSsqIzkxBCnbWMI2RrRJjb7PLafVL1q+qPXkyH7rlG65F6nM7QkYGE5yzCi7/JpaeRUEXdF+Q+/998+kN2kJZSPOugWRkrmCSvQzKM3f4LzTrcdFbzRni6+pnXxnfRfUQanGYrf/1MBRRBmNC9v7E9DPycsQyNgm6tyNRq3GrnbYR7cnR7ZPePyPgh7ZCEoYaD/lXhc0f5j23HVDNkGsQdZ8Ygw9HpdTqfCF9N57ZDHsoe5Txd0C2kQtmkiQDZZxy1M5/Hsyaxc7aCfuVelGrjOY5F6qvG+OB0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u/Ky8+NQvhUowseDnnnF1nVPVLWPlhDFslxsX3862JQ=; b=X7z4GzfXx0h5TNvfxVwX9z7NgYrYgBrEXdLIVb91OfL3OWx2ZOdkvM93A7B91kKgkw8SAdxUXB4Jbb3efT3EMMkYBwHRP3BCJfkmHNYcx04Pso7+JfvKk4mbd+E8eFNMhd9jXkXT2LjeJ8T8e0ZJF/h2ffRxRfo81h4HOaoGd0uldgv4Zt9OufgMhbaWAOfo9OQKydc0Q8tcMIFMZ/5KkvBnkes1mBe0WylimXq+VuEh9X1M6TH5CILLIJeVRQlmGtx7jxjaKNHaRV5OzuOhL4wfPMw0fXaFG+5Xd7+bxg29U61mYgRe8UF/1Q2pegoWLOW8VHvIsTlMjxdrrCaBkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u/Ky8+NQvhUowseDnnnF1nVPVLWPlhDFslxsX3862JQ=; b=H3IFIUhGXwikfYm9fqrTClLgB2eCJ8Lbg/dDV33g3EnZp5c57GJCUaAIyGWLU52MixYILzky4/h7RNwxGMGoskDsnUVweq2OI7v+4OMyY5cJNr32UWgjRtN57/iSHBNhm691CBPdSxFiiRActBQqjW8EnVh3j2mrQfcZ+4zIgYw= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 5 Oct 2021 14:42:53 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021 14:42:53 +0000 Message-ID: <4f695186-87ca-fe49-db72-b91b5fb9041a@intel.com> Date: Tue, 5 Oct 2021 15:42:46 +0100 Content-Language: en-US To: Ori Kam , Jie Wang , "dev@dpdk.org" , "andrew.rybchenko@oktetlabs.ru" CC: NBU-Contact-Thomas Monjalon , "xiaoyun.li@intel.com" , "jingjing.wu@intel.com" , "beilei.xing@intel.com" , "wenjun1.wu@intel.com" , "stevex.yang@intel.com" References: <20210924151705.287571-1-jie1x.wang@intel.com> <20210924151705.287571-4-jie1x.wang@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR1001CA0047.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::33) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR1001CA0047.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16 via Frontend Transport; Tue, 5 Oct 2021 14:42:51 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 255c8a81-ebd7-4278-94c3-08d9880e697e X-MS-TrafficTypeDiagnostic: PH0PR11MB4885: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bi69F5uPPxn7e2aBqGm6172K3BN1Ta2/BtfQAlp88jl6lqs+oOrOhHRKxjCWlpOyRWAP7FwTpZybt5AGLqF2+CUdwhvwwlLYfJeeVZSdNoTz5GbprYyQtceuA3Ddg8Z0pYb9gDwAUkFzHf16cIZB7v1RM03Qagk+cddPmwL6VflXI4UysRlls7U1z/mQ/w9ctx+o8vkMyhOumCz5xXE5KG9qjIF4kKi2fb7CD6llVJKUNiJ+KzxKvzQxjBV61WYnsgVbccgQh7z7m9cZb8kayjO1SakFaQbHDStjMXp1uKv3JQq8+OGoxuPTAFJettJtyW7vPuRkcDmzYG7HLAZEcSbREu7kPeqBchMTvLqcJYUJoXDEV97BzN+H2EYW9jhgmN+gnsZiOwsWsslmqdIu2GbvIZuKubGxLqlYeUaKuTvfDLOaNRtSRvk04sAiNg8qI8cPS4BI663M00GENzGP6LAHVNeGpNS5SkDRfI0byeroJUzP4efQpS1vOAnbXQSycwE4OQOBpkqntW2Kg84w95TGm6w3pIegKRDqjSo2O+0vBFafL1JSFbZSJPC09mgnlOfrRiCckrSO818C+BA7Lsuv1YRPO+hM4GDKYc6XdTs/TH9Mo6ETKy8EqYM62zxmJHvK1r7cR/IQt5KkFd5VBiFqeRVQZcuobG0xGN8uZF4rME5nr6tmvaDuJ+udxjyAW1k9ayNXcaHAotavuLcF4A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6486002)(44832011)(956004)(8676002)(316002)(31696002)(6666004)(86362001)(36756003)(83380400001)(508600001)(53546011)(54906003)(110136005)(66556008)(66476007)(26005)(8936002)(66946007)(2906002)(5660300002)(38100700002)(107886003)(4326008)(186003)(2616005)(31686004)(16576012)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1VoNDFMVlhveWdKV1BpUk5yc3RkckNsUTgyY2dQT052M2dSY3AvNUYreXFo?= =?utf-8?B?aFVZemx1Z051UWlDTFZMNFdpQmYydUk5S1BPa2pqdG1HMlN2Z1lZanBwSXUr?= =?utf-8?B?SHUzWHRMWDlmcHB4UDF3eDFibkZvb09RT0NucVQrL250KzdoOGdzRnlBcjZs?= =?utf-8?B?WDJRY3JhajNCU1J2elFGUVYxNUZtRmdMV3BDS1pWS01Gb1ZadFdhVnNlaFY0?= =?utf-8?B?VTZPV2RqVnZpVk1aQkVpRkh6aGJhbFBxcGJKb0M0Mk55cTBNU2FwaDhERDlI?= =?utf-8?B?VHJMOW96WGdlNmtWWkJweU5YcDZsNW53T0l4bnF0V2dSKzliSk5aOGxXQStn?= =?utf-8?B?YlNMWGF0MU1YN0lBRDdHdkl3a05sTGpqbXlSRmV6RGFPWFVqUGVTVmx6cmds?= =?utf-8?B?VkFIeGVkNHErMURFTUY4TmJYWjBxSDRVQlUvZDhEZXhia0JBM25hRWR3Nm0w?= =?utf-8?B?S3QvMTY5dTI5N2lrVlZZMU5LcjI1MjVRZ1pCZHlIdCtKbExFNWs3dzJjYzBS?= =?utf-8?B?VnNvL25WY0tXemNacVhNZXVlSzRzbzRJdHlidjNaM2xraWxPcTBFaVhyZ2R2?= =?utf-8?B?LzB2Y0FoenNGbjFQVk01NXBTeEV6QUZHbGMxelV3MVAyUXM0L1NHRFRQQnhu?= =?utf-8?B?d0Z0djN0ellKWEVLSHVReTVHS2I3bnN1RnQrVGNLcCt1Q3hCTTMzR1lSeG5p?= =?utf-8?B?aVVmNnJOdlJCUndHNEhXUS9oNytzaVNxcXNsWWFsVFNva1ljam0yaTJuR1Q3?= =?utf-8?B?OTJrMzErZkVETzdhZXFVY3ZzUldQZVFFTXZnWklUaDYzNXg0YlVNdzhFUU05?= =?utf-8?B?MlY3VnJoM1p0MnY5RUVqS0tLRVZYaWZUNTFWZmVCQUlIVFNST1BQeVF4ZTlS?= =?utf-8?B?c2NCR3docDcwYUVmbEJjcVJXRTNLSlR2djVBaThKY0daVDR0UWNOdHhmSkdY?= =?utf-8?B?dDlRVC9aMkp1ay9jYWpTWEU0M2tONURESno4NWsxYjVJQWVOT1djR1NIcGt5?= =?utf-8?B?L3dXZFdORWJaSlg0RXFSWW0yZkN1Z1F3SnZsZmpEenpPQk1zbkc2dENkY1RC?= =?utf-8?B?MSt4R1J2bm4zTndCVVhxNHpIVU1KTGMwVXlLKzVpa0JaeHRFV3BGNTFrRTJR?= =?utf-8?B?bXNUSWt3SlZlN1pJMjNuK2JvbXdEcG45MW8vVGJ0S29vSEFpWDRSUS95TGdJ?= =?utf-8?B?WlBQcHRWVGc0UXV6Y0c4WFRkSGphaFE4emtTdFE5b0h2NCtiZWJ5TmtyTXRL?= =?utf-8?B?U3Q5N1pERUxQWktGejc5djZhZ2MxaktNS1hnMTlDWmNOS1c3NkVKVW91dTVY?= =?utf-8?B?ZHlGbkwyeVNSaGF6dCtRdGVQQ1VObGhrR3VHYnBzN0ErVmVLd2tzQnU5RDdk?= =?utf-8?B?Ulg4R280WnoxZUpEVlFpeDVianVwaXdkdGRCS0tUYkQ5SG90SmRNZHBZWVVs?= =?utf-8?B?UTRTRVBXMm9BbmRvZzBHQlc4dHJjNzd2WFQvdVZFd05SOXloSXMrK21XVmU1?= =?utf-8?B?blFwU05teUNUVlhSazB3UzdmV09ERXcwb0pKK2RoekltdGpVUjJNQ3BQZTdR?= =?utf-8?B?ZFQ2ZHZYc3VReHNqZW9sbjRRR3kwSlhuWE9HSVU5SWFiS1NoeXgvWkVnTDJN?= =?utf-8?B?Yi9qMkhVQVljWTQ1MWk1RDY4cFViNno0VGhxMzN3T2JDMlJLbUpXTzdiWE8y?= =?utf-8?B?OFZkNjNqNllpTVJ6TDhtU0N1NDJ1Y1orN0dEVk92QUpZaUtLVzJnZXMrakZH?= =?utf-8?Q?bMXX+a/cX5UWgOuEC7WzRiOrhdXYknPUnajnT31?= X-MS-Exchange-CrossTenant-Network-Message-Id: 255c8a81-ebd7-4278-94c3-08d9880e697e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 14:42:53.2858 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EOruph236rKxoI6fracKoE3jr982EtTvpiZwQL+UDkhsohQeJQQOMuGXfN/4UGw3h8JnQQInSIapcSefrIMDJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4885 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 3/4] ethdev: support PPPoL2TPv2oUDP RSS Hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/30/2021 3:38 PM, Ori Kam wrote: > Hi Jie, > > You are missing updating the rte_flow.rst and release notes: > > Please see more comments below. > > Thanks, > Ori > >> -----Original Message----- >> From: dev On Behalf Of Jie Wang >> Sent: Friday, September 24, 2021 6:17 PM >> Subject: [dpdk-dev] [PATCH 3/4] ethdev: support PPPoL2TPv2oUDP RSS >> Hash >> >> Add flow pattern items, RSS offload types and header formats of L2TPv2 and >> PPP. >> >> Signed-off-by: Wenjun Wu >> Signed-off-by: Jie Wang >> --- >> lib/ethdev/rte_flow.c | 2 + >> lib/ethdev/rte_flow.h | 99 >> +++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 101 insertions(+) >> >> diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index >> 8cb7a069c8..307fbc3abe 100644 >> --- a/lib/ethdev/rte_flow.c >> +++ b/lib/ethdev/rte_flow.c >> @@ -98,6 +98,8 @@ static const struct rte_flow_desc_data >> rte_flow_desc_item[] = { >> MK_FLOW_ITEM(PFCP, sizeof(struct rte_flow_item_pfcp)), >> MK_FLOW_ITEM(ECPRI, sizeof(struct rte_flow_item_ecpri)), >> MK_FLOW_ITEM(GENEVE_OPT, sizeof(struct >> rte_flow_item_geneve_opt)), >> + MK_FLOW_ITEM(L2TPV2, sizeof(struct rte_flow_item_l2tpv2)), >> + MK_FLOW_ITEM(PPP, sizeof(struct rte_flow_item_ppp)), >> MK_FLOW_ITEM(INTEGRITY, sizeof(struct rte_flow_item_integrity)), >> MK_FLOW_ITEM(CONNTRACK, sizeof(uint32_t)), }; diff --git >> a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index >> 70f455d47d..93205b7d1e 100644 >> --- a/lib/ethdev/rte_flow.h >> +++ b/lib/ethdev/rte_flow.h >> @@ -554,6 +554,20 @@ enum rte_flow_item_type { >> */ >> RTE_FLOW_ITEM_TYPE_GENEVE_OPT, >> >> + /** >> + * Matches L2TPV2 Header. >> + * >> + * See struct rte_flow_item_l2tpv2. >> + */ >> + RTE_FLOW_ITEM_TYPE_L2TPV2, >> + >> + /** >> + * Matches PPP Header. >> + * >> + * See struct rte_flow_item_ppp. >> + */ >> + RTE_FLOW_ITEM_TYPE_PPP, >> + > > Why did you push the new items here and not in the end? > >> /** >> * [META] >> * >> @@ -1799,6 +1813,91 @@ static const struct rte_flow_item_conntrack >> rte_flow_item_conntrack_mask = { }; #endif >> >> +/** >> + * @warning >> + * @b EXPERIMENTAL: this structure may change without prior notice >> + * RTE_FLOW_ITEM_TYPE_L2TPV2 >> + * >> + * Matches L2TPv2 Header >> + */ >> +RTE_STD_C11 >> +struct rte_flow_item_l2tpv2 { >> + rte_be16_t flags_version; /**< flag(12) version(2). version must be >> 2 */ >> + union{ >> + struct{ >> + rte_be16_t length; /**< length(16) */ >> + rte_be16_t tunnel_id; /**< tunnel id(16) */ >> + rte_be16_t session_id; /**< session id(16) */ >> + rte_be32_t ns_nr; /**< Ns(16) + Nr(16) */ > > Why not split those fields? > Hi Ori, As far as I remember the decision was to define protocol headers separately and use them as first element in the flow_item struct, this enables casting the flow_item to protocol. And Andrew did some cleanups in the past related to this. Can't we use the same logic for this case?