From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEED6A0C47; Wed, 27 Oct 2021 16:58:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5292411B8; Wed, 27 Oct 2021 16:58:30 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id DD686411B5 for ; Wed, 27 Oct 2021 16:58:28 +0200 (CEST) Received: from [192.168.1.71] (unknown [188.170.75.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 70AEE7F66F; Wed, 27 Oct 2021 17:58:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 70AEE7F66F DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1635346708; bh=4NKaWpw/0Cb7KBam1HFky/4rnvLWSwaIOT46ypClTkA=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=gIbjVlx96MUleXKSSRqvpW+G7nQ5wCRw6i2gYH+bI3TJwaV3coJHcr2VpJXND5S1A dT/R3DuSOPPHsZA0dKb3VizhCMG0LyGwpJoiqrHtA0tpCvbKJ2c8oJNF2ejVoPPPjT c16+Rl4lFmckpqypgth4RC4yNOL7vaUHZbAj3LCU= To: Maxime Coquelin , dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com, david.marchand@redhat.com, ferruh.yigit@intel.com, michaelba@nvidia.com, viacheslavo@nvidia.com, xiaoyun.li@intel.com Cc: nelio.laranjeiro@6wind.com, yvugenfi@redhat.com, ybendito@redhat.com References: <20211027142213.556166-1-maxime.coquelin@redhat.com> <20211027142213.556166-2-maxime.coquelin@redhat.com> From: Andrew Rybchenko Message-ID: <4f94bc77-2f84-3fb6-514a-905912c14674@oktetlabs.ru> Date: Wed, 27 Oct 2021 17:58:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211027142213.556166-2-maxime.coquelin@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 1/5] net/virtio: add initial RSS support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/27/21 5:22 PM, Maxime Coquelin wrote: > Provide the capability to update the hash key, hash types > and RETA table on the fly (without needing to stop/start > the device). However, the key length and the number of RETA > entries are fixed to 40B and 128 entries respectively. This > is done in order to simplify the design, but may be > revisited later as the Virtio spec provides this > flexibility. > > Note that only VIRTIO_NET_F_RSS support is implemented, > VIRTIO_NET_F_HASH_REPORT, which would enable reporting the > packet RSS hash calculated by the device into mbuf.rss, is > not yet supported. > > Regarding the default RSS configuration, it has been > chosen to use the default Intel ixgbe key as default key, > and default RETA is a simple modulo between the hash and > the number of Rx queues. > > Signed-off-by: Maxime Coquelin Reviewed-by: Andrew Rybchenko