From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC16EA0524; Fri, 7 May 2021 17:00:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 414A54013F; Fri, 7 May 2021 17:00:03 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id BFE8E40040 for ; Fri, 7 May 2021 17:00:00 +0200 (CEST) IronPort-SDR: IFJO1tRwKafoqroCXo3fOmEPWbalwxTF+8EG7xc4bA94hJjwUOp8G/cJelEcf3PpwTlk3JFHgz Pto8wwAxPcHA== X-IronPort-AV: E=McAfee;i="6200,9189,9977"; a="262681777" X-IronPort-AV: E=Sophos;i="5.82,280,1613462400"; d="scan'208";a="262681777" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2021 07:59:52 -0700 IronPort-SDR: Kin3sCgcPOLKydbW16zTQORTdR5JIU9l48ReMmW9t7wd6uhE3EbqqQnnErDcqdtrE7hcV+MnyT UrR+5UKWJCaQ== X-IronPort-AV: E=Sophos;i="5.82,281,1613462400"; d="scan'208";a="431378092" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.210.230]) ([10.213.210.230]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2021 07:59:50 -0700 To: Michal Krawczyk , dev@dpdk.org Cc: ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com, upstream@semihalf.com References: <20210505073348.6394-1-mk@semihalf.com> <20210506142526.28245-1-mk@semihalf.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <4fae6792-f42f-1160-9af9-a3b055565ea0@intel.com> Date: Fri, 7 May 2021 15:59:46 +0100 MIME-Version: 1.0 In-Reply-To: <20210506142526.28245-1-mk@semihalf.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 00/22] net/ena: update ENA PMD to v2.3.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/6/2021 3:25 PM, Michal Krawczyk wrote: > Hi, > > this version updates the driver to version 2.3.0, which fixes multiple > bugs, contains part of the work on making the ENA PMD fully MP aware, and > also updates HAL to the latest version. > > More detailed list of changes: > * memcpy mapping to the dpdk-optimized version. > * ena_com (HAL) update to the latest version. > * Bug fixes for the large LLQ headers and devargs parsing. > * Mbuf RSS hash presence indication. > * Bug fix for the default ring size. > * Various fixes for the SMP mode. > > v3: > * Fix build of the PMD with the debug flags enabled. > * Fix typo in the commit log of the version upgrade patch. > > v2: > * Fix nested declaration of the rte_memcpy on arm64 architecture. > > Amit Bernstein (1): > net/ena/base: adjust changes to lastest ena-com > > Igor Chauskin (2): > net/ena: switch memcpy to dpdk-optimized version > net/ena: fix parsing of large_llq_hdr argument > > Michal Krawczyk (12): > net/ena/base: unify arg names for the functions > net/ena/base: add dev arg to the logging macros > net/ena/base: typos, style and comments improvements > net/ena/base: fix issues from the static code scan > net/ena/base: destroy multiple "wait events" > net/ena/base: remove indir table from ENA feat ctx > net/ena/base: remove mutable RSS from the host info > net/ena/base: update generation date and commit > net/ena/base: use rte_prefetch0_write > net/ena: terminate devargs allowed keys with NULL > net/ena: indicate Rx RSS hash presence > net/ena: update version to v2.3.0 > > Stanislaw Kardach (7): > net/ena: remove endian swap functions > net/ena: handle spurious wakeups in ENA_WAIT_EVENT > net/ena: support SMP for mz alloc counter > net/ena: move default RSS key to shared mem > net/ena: make ethdev references smp safe > net/ena: disable dev_ops not supported in SMP > net/ena: report default ring size > Hi Michal, There are some checkpatch and check-git-log.sh [1] warnings, can you please check them? You can see checkpatch warnings from patchwork: https://patches.dpdk.org/project/dpdk/list/?series=16861 The ones with yellow marker in the warning column. Additionally I am getting following checkpatch warning, that is not seen in CI: ### net/ena/base: add dev arg to the logging macros WARNING:UNNECESSARY_MODIFIER: Integer promotion: Using 'h' in '%hu' is unnecessary #331: FILE: drivers/net/ena/base/ena_com.c:861: + ena_trc_err(ena_dev, "Reading reg failed for timeout. expected: req id[%hu] offset[%hu] actual: req id[%hu] offset[%hu]\n", mmio_read->seq_num, offset, read_resp->req_id, @@ -854,7 +868,7 @@ static u32 ena_com_reg_bar_read32(struct ena_com_dev *ena_dev, u16 offset) [1] ./devtools/check-git-log.sh -22