From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 209652B8C
 for <dev@dpdk.org>; Tue, 27 Sep 2016 19:03:53 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP; 27 Sep 2016 10:03:53 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,405,1470726000"; d="scan'208";a="766489040"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.76])
 ([10.237.221.76])
 by FMSMGA003.fm.intel.com with ESMTP; 27 Sep 2016 10:03:52 -0700
To: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, dev@dpdk.org
References: <cover.1473840791.git.nelio.laranjeiro@6wind.com>
 <30739c1ee245c3e3ee9a1122ca08285d718eb9b8.1474987853.git.nelio.laranjeiro@6wind.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <4fbbd27b-9610-4772-5cba-5ce896b4eebf@intel.com>
Date: Tue, 27 Sep 2016 18:03:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <30739c1ee245c3e3ee9a1122ca08285d718eb9b8.1474987853.git.nelio.laranjeiro@6wind.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: return RSS hash result in mbuf
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Sep 2016 17:03:54 -0000

On 9/27/2016 3:53 PM, Nelio Laranjeiro wrote:
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

<...>

> @@ -1286,12 +1291,13 @@ mlx5_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)
>  		&(*rxq->cqes)[rxq->cq_ci & cqe_cnt].cqe64;
>  	unsigned int i = 0;
>  	unsigned int rq_ci = rxq->rq_ci << sges_n;
> -	int len;
>  
>  	while (pkts_n) {
>  		unsigned int idx = rq_ci & wqe_cnt;
>  		volatile struct mlx5_wqe_data_seg *wqe = &(*rxq->wqes)[idx];
>  		struct rte_mbuf *rep = (*rxq->elts)[idx];
> +		int len;

clang generates following warning, -it is quite detailed compiler message:

.../drivers/net/mlx5/mlx5_rxtx.c:1327:7: error: variable 'len' is used
uninitialized whenever 'if' condition is false
[-Werror,-Wsometimes-uninitialized]
                if (!pkt) {
                    ^~~~
.../drivers/net/mlx5/mlx5_rxtx.c:1384:7: note: uninitialized use occurs here
                if (len > DATA_LEN(seg)) {
                    ^~~
.../drivers/net/mlx5/mlx5_rxtx.c:1327:3: note: remove the 'if' if its
condition is always true
                if (!pkt) {
                ^~~~~~~~~~
.../drivers/net/mlx5/mlx5_rxtx.c:1299:10: note: initialize the variable
'len' to silence this warning
                int len;
                       ^
                        = 0