From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 46DD91B342 for ; Tue, 7 Nov 2017 12:04:41 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4121C6A7C3; Tue, 7 Nov 2017 11:04:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4121C6A7C3 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=maxime.coquelin@redhat.com Received: from [10.36.112.35] (ovpn-112-35.ams2.redhat.com [10.36.112.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 485A25C88A; Tue, 7 Nov 2017 11:04:37 +0000 (UTC) To: "Kavanagh, Mark B" , "dev@dpdk.org" , "yliu@fridaylinux.org" , "thomas@monjalon.net" , "ktraynor@redhat.com" References: <20171103175735.24603-1-maxime.coquelin@redhat.com> <20171106203812.18428-1-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <4fc9b3ec-836f-5a1c-1002-78e197161120@redhat.com> Date: Tue, 7 Nov 2017 12:04:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 07 Nov 2017 11:04:40 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 0/3] vhost: disable iommu support by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2017 11:04:41 -0000 Hi Mark, On 11/07/2017 11:56 AM, Kavanagh, Mark B wrote: >> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] >> Sent: Monday, November 6, 2017 8:38 PM >> To: dev@dpdk.org; yliu@fridaylinux.org; Kavanagh, Mark B >> ; thomas@monjalon.net; ktraynor@redhat.com >> Cc: Maxime Coquelin >> Subject: [PATCH v2 0/3] vhost: disable iommu support by default >> >> This series disables IOMMU feature by default, and introduce >> a new flag passed at vhost device registration time to enable >> it explicitly. >> >> When disabled, patch 1 also disables reply-ack protocol feature >> to avoid Qemu v2.7.0-v2.9.0 reply-ack bug with multiqueue. >> >> Last patch adds a Vhost PMD "iommu-support" parameter to enable >> the IOMMU feature. > > Hi Maxime, > > I'm happy to confirm that this patchset resolves the vhost user mutltiq issue for OvS-DPDK, with QEMU v2.7.1. Thanks for the testing. > Additionally, all of the individual patches look good - thanks for all of your efforts on this! Great. Now, what is required on OVS side is the introduction of a new vhost port option to enable IOMMU support, so that management layer has a way to enable it when VM has an iommu placed in front of the virtio device. Note that OVS can set the flag even if no IOMMU is present, as Virtio feature negotiation will manage this. > Tested-by: Mark Kavanagh > Acked-by: Mark Kavanagh Thanks, Maxime > Cheers, > Mark > >> >> Maxime Coquelin (3): >> vhost: disable reply-ack protocol feature if iommu feature disabled >> vhost: add flag to enable iommu support >> net: vhost: add iommu-support parameter to enable IOMMU feature >> >> doc/guides/nics/vhost.rst | 5 +++++ >> doc/guides/prog_guide/vhost_lib.rst | 14 ++++++++++++++ >> doc/guides/rel_notes/release_17_11.rst | 3 ++- >> drivers/net/vhost/rte_eth_vhost.c | 13 +++++++++++++ >> lib/librte_vhost/rte_vhost.h | 1 + >> lib/librte_vhost/socket.c | 6 ++++++ >> lib/librte_vhost/vhost_user.c | 24 ++++++++++++++++++++++-- >> 7 files changed, 63 insertions(+), 3 deletions(-) >> >> -- >> 2.13.6 >