From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 20AB82B88 for ; Mon, 22 May 2017 11:39:06 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2017 02:39:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,377,1491289200"; d="scan'208";a="103864157" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by orsmga005.jf.intel.com with ESMTP; 22 May 2017 02:39:04 -0700 To: "Charles (Chas) Williams" , dev@dpdk.org Cc: linville@tuxdriver.com References: <1495044215-16915-1-git-send-email-ciwillia@brocade.com> <1495044215-16915-2-git-send-email-ciwillia@brocade.com> From: Ferruh Yigit Message-ID: <4fdc5000-66c1-ff96-6330-20a3cc92d900@intel.com> Date: Mon, 22 May 2017 10:39:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1495044215-16915-2-git-send-email-ciwillia@brocade.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/3] net/af_packet: add accessor for iface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2017 09:39:07 -0000 Hi Chas, On 5/17/2017 7:03 PM, Charles (Chas) Williams wrote: > Provide an accessor for the name of the underlying linux interface > used by the AF_PACKET-based interface. This patch provides a PMD specific API to get PMD internal data (internals->if_name). I think we should avoid PMD specific APIs if possible. internals->if_name is provided by application, as devargs to af_packet (iface=..), so app already knows port_id -> if_name mapping. OR With rte_eth_dev_info_get() af_packet returns the if_index for underlying interface, it is possible to use if_indextoname() to get ifname. Because above methods exists to get if_name, I think this API is not necessary. > > Signed-off-by: Charles (Chas) Williams <...>