From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DB92A0579; Thu, 8 Apr 2021 17:41:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02557141112; Thu, 8 Apr 2021 17:41:41 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id CC3864068B; Thu, 8 Apr 2021 17:41:38 +0200 (CEST) IronPort-SDR: mMN4PeTB99GPChSStNECTNVNl+ob86zxkvUI/UHXhQx++z0IbIs1QW5+VMmm65n2YzGNVg1mKK HxFG+fFCJ7rg== X-IronPort-AV: E=McAfee;i="6000,8403,9948"; a="213979595" X-IronPort-AV: E=Sophos;i="5.82,206,1613462400"; d="scan'208";a="213979595" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 08:41:37 -0700 IronPort-SDR: Pze2J9WOvdEphHaKi1ha/SanKloc/cERoWu3WzNbiyMITToox/9R5EYuzfypeZVbujnJHLJ5Yb D70hnlJVs/BQ== X-IronPort-AV: E=Sophos;i="5.82,206,1613462400"; d="scan'208";a="380298730" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.203.5]) ([10.213.203.5]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 08:41:36 -0700 To: dapengx.yu@intel.com, xiaoyun.li@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, stable@dpdk.org References: <20210401082844.401918-1-dapengx.yu@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <500b55c4-6ec5-1466-8ddf-60728e9cefcb@intel.com> Date: Thu, 8 Apr 2021 16:41:31 +0100 MIME-Version: 1.0 In-Reply-To: <20210401082844.401918-1-dapengx.yu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/1/2021 9:28 AM, dapengx.yu@intel.com wrote: > From: Dapeng Yu > > Configure per queue rx offloading and per queue tx offloading command > shouldn't trigger the rte_eth_dev_configure() to reconfigure device. > > The patch sets the queue reconfiguration flag only, and does not set the > device reconfiguration flag. Therefore after port is restarted, > rte_eth_dev_configure() will not be called again. > Just to clarify the impact, was calling 'rte_eth_dev_configure()' causing any problem, is this fixing any issue? Or is this patch an optimization to eliminate an unnecessary call? > Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") > Cc: stable@dpdk.org > > Signed-off-by: Dapeng Yu > --- > app/test-pmd/cmdline.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 14110eb2e..b49e9f52b 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -15626,7 +15626,7 @@ cmd_config_per_queue_rx_offload_parsed(void *parsed_result, > else > port->rx_conf[queue_id].offloads &= ~single_offload; > > - cmd_reconfig_device_queue(port_id, 1, 1); > + cmd_reconfig_device_queue(port_id, 0, 1); > } > > cmdline_parse_inst_t cmd_config_per_queue_rx_offload = { > @@ -16044,7 +16044,7 @@ cmd_config_per_queue_tx_offload_parsed(void *parsed_result, > else > port->tx_conf[queue_id].offloads &= ~single_offload; > > - cmd_reconfig_device_queue(port_id, 1, 1); > + cmd_reconfig_device_queue(port_id, 0, 1); > } > > cmdline_parse_inst_t cmd_config_per_queue_tx_offload = { >