From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0059.outbound.protection.outlook.com [104.47.38.59]) by dpdk.org (Postfix) with ESMTP id 8062D1DBF for ; Tue, 19 Dec 2017 13:59:44 +0100 (CET) Received: from CY1PR03CA0010.namprd03.prod.outlook.com (10.174.128.20) by BN3PR03MB2355.namprd03.prod.outlook.com (10.166.74.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Tue, 19 Dec 2017 12:59:43 +0000 Received: from BN1AFFO11FD018.protection.gbl (2a01:111:f400:7c10::133) by CY1PR03CA0010.outlook.office365.com (2603:10b6:600::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.323.15 via Frontend Transport; Tue, 19 Dec 2017 12:59:42 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD018.mail.protection.outlook.com (10.58.52.78) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.302.6 via Frontend Transport; Tue, 19 Dec 2017 12:59:30 +0000 Received: from [10.232.133.65] ([10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id vBJCxe1g019221; Tue, 19 Dec 2017 05:59:40 -0700 To: Akhil Goyal , References: <20171213135659.32648-1-akhil.goyal@nxp.com> <20171213135659.32648-4-akhil.goyal@nxp.com> CC: , From: Hemant Agrawal Message-ID: <5011d837-5a2f-ce33-16ba-052d20194bad@nxp.com> Date: Tue, 19 Dec 2017 18:29:39 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20171213135659.32648-4-akhil.goyal@nxp.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131581619707832376; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(336005)(346002)(376002)(396003)(39380400002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(24454002)(199004)(189003)(53936002)(36756003)(229853002)(77096006)(23746002)(31686004)(5660300001)(2906002)(53546011)(104016004)(65826007)(65956001)(6246003)(59450400001)(65806001)(50466002)(64126003)(498600001)(230700001)(47776003)(76176011)(356003)(31696002)(97736004)(67846002)(8656006)(81166006)(58126008)(4326008)(305945005)(83506002)(86362001)(2950100002)(8936002)(68736007)(85426001)(110136005)(81156014)(54906003)(105606002)(8676002)(106466001)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB2355; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD018; 1:u/UvDk193Gannh3E0NJzoHN1LpwEUt8mN5wfYB0bOJSKiNydciMaF6pMRPB12OzfmtBLUcyzmKjuyg4XzwOKmYrOzT2VTYkbBizHLq9j3xZzLpBBGC9u1zkmwkPmL3Ee X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ade1a2a3-8bf1-495d-e838-08d546e0581e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4628075)(201703131517081)(2017052603307); SRVR:BN3PR03MB2355; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2355; 3:9fXugeUnJv5WtgewiqDnSdPS/QjD0cbHxwmkZ1E/lFUxS8BKkOIqQBid8I4zniZZHtQQrD5AKMHf3740+s7IdTsFYz4nh9r9Xv6I8RyAfahca/1iAmEkobzxSbVZWpT+S8laVTXZHERj32PWK21lQCSF3bqiLoaLkUHVzcQB8VFA7Q7XtYBrMYXe4ffEq+vc0UzFcsx2/fVqWxmXSw/u8ABB03r2OxUJezmk2QNm4i0Y3y2s77YiIWFgLkhIBYKt15XphKWjN0oJMDvmoRtEgo0WR2hqXjLGFNQ+lwZGZwVYmGnAyKH6uGdK/zHpmYXF3J5HRV8Q2TPNP3XR/G8CI5/jluTNUMl+WxrT6Wu72co=; 25:Bhfqb36anhBeXs1N4mYdSDxXZKLiRMhMSKlg2Sx8nJzEqYLVQYwPcLaSg8Hwbn/H4QbBt3cmMDsIVf1xPNkUA4PhUtxyImHKX8YPCzE1cV1SNbRL/qEkZ2iJvvDoovX7gFMKcm1vuZC/5zmSwf72d8/aegH+vYgDs40Q6rLe5cvT/v1GijtaQIDOpRo1XU0YY2QvjOdmzFF+YdEX9mUjflFZQqeTi1sMnidBxdlPgYyJp9X+/9CXQg08EJq8rqQbnQWhRdPant5oPEOztT6ktPTGocuqXWb/ejdnAuwZB3l9VtSTH9FZa+nxV8oNDy6oXi3qMaqLbNt6iHHAk6vlJha6Q2Ubb3iZV28BpsQHnJQ= X-MS-TrafficTypeDiagnostic: BN3PR03MB2355: X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2355; 31:aVTa7bm3zPIVpvo1ptsiBy3bdK4HouUEbnrUPy8BXqIof2Ks894K+tnUoPKRpxcUsxQvUkp9YnIlQebsaMSxKVzXAlQTX4qlA7VBQWJoff1KMJ1AgDrCPPupsyNHnWnXFs4EqQ67wDnMlSP+YKbdtZBcv9ZqRFZzMulswr3+nq0yVDLa62h7Yx4DVuiviRxyYF9FAVYrrDohHW032jgzc8xwk++YhWYa7wis0qZdIvU=; 4:DXlvicdUJjeU/16u8N44Ggiq/qhP4FsvxDOgxrhBoOeu3QAj7Vu/DuboDnrNhDgHr+Sng/5Idysn818+swIPBa7Gm7NW7IHyW7ExkuPhDhch7SQxHPJlN9qT/px2OeqpZ0Z9I0/y1WccZDqdNOQC2s+JFGsy49ZzSnIb/l34nZbRxjeLUwpHFIc5oT5TWxAJXHvyclrFAOqGOPCC2MOJP383YQGA/T9krzmy2uDEAbp6LRF56aRQyuN264UiBRHmxiclz0kWwHqB3sdEIfe70dZfXueT15RZEb6rlndN69ytlLozaJqPN+KvAaAE1o9k X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(3231023)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(20161123556025)(20161123559100)(20161123563025)(20161123565025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123561025)(201708071742011); SRVR:BN3PR03MB2355; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:BN3PR03MB2355; X-Forefront-PRVS: 052670E5A4 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN3PR03MB2355; 23:rQ1k5T31MpV5NUIYX/S1QfdpqQOH8YbbCwlrW?= =?Windows-1252?Q?f0iU9wps33KEJSDctcxzHbr8fNiX6TifohzXHNK0PxcFDOzdVhjQYbQW?= =?Windows-1252?Q?l/kMiZjc3tk+YkQPoxLcxvivZdVHejn6fI+DexewoZLs9MexukgnJ8+x?= =?Windows-1252?Q?ukE6ARLiGdqBzSEJgr2AGNuno9RmjZ9hzqU8xwqPsMxK2cl8AgTEOg6s?= =?Windows-1252?Q?ELi5KsCZI4iOTSHcnHKtbew1+mM2K4teeSppnMtFPMDaGLuvT2Qqq4Wo?= =?Windows-1252?Q?GZdO72GHDY2rWav6MbneQA9iWrFRVOAJf7L99cLc5GszvwaGYDbvFBmX?= =?Windows-1252?Q?mDLizmkbfTfB3GcpWEZIfV5f7nCQc8aiznhFc0uunq1nDXXmIWr6702w?= =?Windows-1252?Q?vLrt5+OjSbVM1AeG8cK+vOt9H4b/5jTHODb+PzPjJS5l44QmP7uMfI/6?= =?Windows-1252?Q?oAHchyYFCKa0h4RVwtLwWWtpxogo7gxxRojFXYtnH0xJruYP0tBzZhKN?= =?Windows-1252?Q?yKBD2wdFzQlszu6ihv0cNCB8UNv0HlVGuW21G7Ge5kC25DVcfnJrA+pi?= =?Windows-1252?Q?TZ2t28KIWyEJ/fC4gyxGrCo9A+85QfpeGQgB1i9kw5xT8gS2BZKYypJj?= =?Windows-1252?Q?1ZS7AH13wcaUjoDnDf9Qs6+0A5SH8wQd7UVFXs1Vu5XWtQYKQtbD5IR1?= =?Windows-1252?Q?3i5kh+25Lb9YNPiqwrcANTondqAhP4C/iAZ+HuhpbcCryjmBxBMHkyWl?= =?Windows-1252?Q?z2vm1FnZ92TWWgPaDsy9n8O5aqqC/owJ9RT65ltNtD3r7owlIqbt1b8d?= =?Windows-1252?Q?Ngdpufz1uWq4H8+oLgInIFigSlI68v8jZP77w8dr3pOgvULsIU86L8Hk?= =?Windows-1252?Q?xSf45ZnvCXoCZtCwiHK2yYml9T+xCxSDJueGMBaP7UXu6PPeD0AWxJhA?= =?Windows-1252?Q?CiMAWw9LpOkF+y5fVV26yqLv2AwbOTI/v/TkiVUdigrdolkKDtqXiBRj?= =?Windows-1252?Q?MvEeE0PYY7ETYO/X+iQr8QXvNOL3spjrWOmYQj/xEe0ys0UsyAFiuaRx?= =?Windows-1252?Q?TdbgOQn23cPgpzAFWpfzagOphGaMiVwQtJrIJcJslW1zCczEHnBwsjzD?= =?Windows-1252?Q?S49MsnjY1l6I0HVn2miuFeyfzPsLYA8sYBRs5wq86ModxuXgn3TN6bmh?= =?Windows-1252?Q?AN+BdKQKehK/0M3gO8Cq+qPP21mDlvttMLeKwFkeQEasQ8h66x6RCSGi?= =?Windows-1252?Q?Q+qjC/yi+VwmeR4locovoQyNKdKccYDE8OZFO0DoPyEDKW9uCFRYMgpv?= =?Windows-1252?Q?WSSGHzrhKlupM6lgrV9NpIQQQap8KNlYNyasYwlUUS0/v61MktbFFXz9?= =?Windows-1252?Q?IhYUYD5w8XM/wMhkKv6PnuZkFYghjvRdEYSselSzIm452crlFZgqyE?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2355; 6:1BIrwJF/kEOe1fnHbiVdbmHqtELrRW0/iHmPonyBmEHUP6YoJ/Cu5KLCppxUPffkLC0DAyG5tyGHWbU8EoWJ3DgdJbBGpjFHgYOydCvsGt5elHQ6sgM4+V3WzTcNv/QA1UDMqKmQHW1TpZCxe3vrPP4tfqBu5/KP0c39TFMZ2ilebVNjnZ3Bz8oGvyMyvjhcYpZNYDs92g+gtlXIIdGmgtRY8Iwjaqg097RZHDRfwbvUTVKnb/+adhFO4XPaAIA0E9E6oBF5NmPEtPhZ+TVQ2+mmRqlpjKS0ha7rML0pYYfvzEipQcD8Ue/BROdX8yTkUEQVbJZ66QQWZTLXXbAo830WYXwdRihZRhxN6B59jAA=; 5:JdXGzYt+EfDU6PnzooMmQTfyIS8+Hgwk75IHklWKZe7ETb+9x6nJEvrzFOHKuxiqCL/ulxdJ/pM6tloiZ3PqU64CqsU+yOK0D4JupvzDxvG1/cdyHZLfCUalfwguWMiHLNVYAE6Cg87/PbdrQKRIMWXPh3oo5/PST9KaSg8WULA=; 24:gyl0yWNh9ykWa+zmcUj/ubJMTKd4W+G1m6J92mCDrLz921ekWJ6XYKVrvRH85tpXSVAEFxU7KSYmDbEHPd9RMaUsGne82EQAs8Yl8Byi8f4=; 7:XeJcm4L815rEBEr+lju8v/FRARl0XbxkrV6F0qr1is8Yqg05/XVyBlihxLlLan/sZY9yB6md0tg/+LIHQRqlTWtHiOcW0+yo1+SkVsg6b6DXkYqr5gSh1vlk/gNIlaHN75uclW8Ip8HM7D4iCTvdFuQkOVRdGFpxOz0oeiGQYZ4djjd+3/0ldwt8uuB1UHmAevVsTr/efOJdTezkT1DCvOB8bwVU7SeEXcWFlBsTztgBcq/sz/LqW9dTg4HQQERt SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2017 12:59:30.6272 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ade1a2a3-8bf1-495d-e838-08d546e0581e X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2355 Subject: Re: [dpdk-dev] [PATCH 3/5] crypto/dpaa_sec: support ipsec protocol offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 12:59:44 -0000 On 12/13/2017 7:26 PM, Akhil Goyal wrote: > Signed-off-by: Akhil Goyal > --- > doc/guides/cryptodevs/features/dpaa_sec.ini | 1 + > drivers/crypto/dpaa_sec/dpaa_sec.c | 409 ++++++++++++++++++++++++++-- > drivers/crypto/dpaa_sec/dpaa_sec.h | 62 ++++- > 3 files changed, 449 insertions(+), 23 deletions(-) > .. > + if (ipsec_xform->direction == RTE_SECURITY_IPSEC_SA_DIR_EGRESS) { > + memset(&session->encap_pdb, 0, sizeof(struct ipsec_encap_pdb) + > + sizeof(session->ip4_hdr)); > + session->ip4_hdr.ip_v = IPVERSION; > + session->ip4_hdr.ip_hl = 5; > + session->ip4_hdr.ip_len = rte_cpu_to_be_16( > + sizeof(session->ip4_hdr)); > + session->ip4_hdr.ip_tos = ipsec_xform->tunnel.ipv4.dscp; > + session->ip4_hdr.ip_id = 0; > + session->ip4_hdr.ip_off = 0; > + session->ip4_hdr.ip_ttl = ipsec_xform->tunnel.ipv4.ttl; > + session->ip4_hdr.ip_p = (ipsec_xform->proto == > + RTE_SECURITY_IPSEC_SA_PROTO_ESP) ? 0x32 : 0x33; It will be better if you can use the standard values such as "IPPROTO_ESP" > + session->ip4_hdr.ip_sum = 0; > + session->ip4_hdr.ip_src = ipsec_xform->tunnel.ipv4.src_ip; > + session->ip4_hdr.ip_dst = ipsec_xform->tunnel.ipv4.dst_ip; > + session->ip4_hdr.ip_sum = calc_chksum((uint16_t *) > + (void *)&session->ip4_hdr, > + sizeof(struct ip)); Acked-by: Hemant Agrawal