From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C8774339F; Thu, 23 Nov 2023 01:12:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3C2B402BD; Thu, 23 Nov 2023 01:12:31 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 758BB40262 for ; Thu, 23 Nov 2023 01:12:30 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9AAB85C0160; Wed, 22 Nov 2023 19:12:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 22 Nov 2023 19:12:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1700698349; x=1700784749; bh=446FGRnA4k65JqBVFIMkFJZGJx/j+qnn3ym nEeFFmv4=; b=SGpQgKnb1RxEZ4cVXscOelTN6PeafGlCXZALvNTXZsINQbMQ6+H tecDvRq+469EOgkPbyxiRkNWSTqznGBPiJ4qsX1dazTtyVYADaMAiJQPyNxx/flU 5uf2F5Oxz5LAgUUEIq/dDQHmALfTKB04GhuJIgNeDOCn6wRqSuE3zKcok520iaCI j2H4/tMBrQTwy+07fmwHz1wyzQjrx8yENcw6MYlDFzIN7b0v9lil0LvUKgahcwR4 pZmWbgDj0JZ5NPBzwNC/YUe8qQc4Uigu7aSHLcMHU2WM20SSpdHjW7fAwGeJS1Z7 EZee/jefiKo21ID10sL44KSz/ILzgkj484g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700698349; x=1700784749; bh=446FGRnA4k65JqBVFIMkFJZGJx/j+qnn3ym nEeFFmv4=; b=aiPZ7J7v5jmY5fsipTM/eLoFTsN3ZV4yUgkKN7xmERhb14uxGuz C8z0RJ2Be7zBe8BWSowz5RBusn4571bwRfhrxjZ2Zghdi6dEQRTRjXbucLuD3scn zbAblMb3rKsDIO5kGsgUmPR+ZtQCKp1Bs2203y3LlXjSciuDpPp3a012PUdX/7ju 5waTBdL3WO9qoryn9G7Z+HlRYkRsP6wPnTvzD9CUempr4Nqtep4bVFZvUAWbH0bU oSmW8I0WcRiO+eturQoR+pYDBk2YWaPJTeBkfyWEmXxP0CVb0IKxQsq8Qtz3xm6Q XgUS1rTgGrMs64f42avDLI4sXwPpQoQnpNA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehvddgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Nov 2023 19:12:28 -0500 (EST) From: Thomas Monjalon To: "Richardson, Bruce" Cc: "dev@dpdk.org" , "Dooley, Brian" , "Ji, Kai" , "De Lara Guarch, Pablo" , "Power, Ciara" Subject: Re: [PATCH] common/qat: fix build errors with incompatible IPSec lib Date: Thu, 23 Nov 2023 01:12:25 +0100 Message-ID: <5020478.tdWV9SEqCh@thomas> In-Reply-To: References: <20231122164651.1320497-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > Since "find_library()" is used to find the libipsec_mb library, there is a chance > > that an incompatible library will be found e.g. when doing cross-builds. To fix > > this, we copy the logic from the crypto/ipsec_mb driver to actually do a link- > > check on the library before deciding it can be used. > > > > Fixes: ca0ba0e48129 ("crypto/qat: default to IPsec MB for computations") > > Cc: brian.dooley@intel.com > > > > Signed-off-by: Bruce Richardson > Acked-by: Ciara Power Applied, thanks.