From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04559A0556; Thu, 20 Feb 2020 16:37:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 768E01BF9F; Thu, 20 Feb 2020 16:37:23 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id A75D51BF98; Thu, 20 Feb 2020 16:37:22 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DE94621C08; Thu, 20 Feb 2020 10:37:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 20 Feb 2020 10:37:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=+C75v8n5dxkFbb1JyDaBJs5e1mWx/aEIUbHYFaNK+Do=; b=MPo5iyqgv9OD jOv5pnpzhJQzFjl09dFd8Y3QXU7WR3pgU9qKLR9avpAkr7YgvPLC/h4Moi0QJJDa VBCCx9RuT3ae5hXbH8bhTAJJL1SHo8bMzpvNacXOhs3cV7PIxs/7J8GA83y6W1gf 2YOicA1OIda2wg7hlyvGKZp370cOOcg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=+C75v8n5dxkFbb1JyDaBJs5e1mWx/aEIUbHYFaNK+ Do=; b=xx+0dG8bKNsqPe1REvhBn+qgjcpNbCDLG5ieqdgOXZcXtzQueu7NqvZ9B lkkNpOPcI4/LQm+/Ph5z7IRLzAc9FcdQLChaMp7TY3lh0CThpEbIpVwhewUPrhYp netsKv0Z7dJzB2+0zpOUPXxRePNzNlUjLUIItbkUQndKsExcTnsLrAGbEfZDp0yF SVzvDMplelAshLPov4EdS+xFmvvJYFt51+dEAIi0EnhpYSJgB6DYmHQDpGR5l3+3 j1kEwDLAjMbW1qKuOfiLItphBIc4Y7/HQ/aBYN+6WYBkYEfPu6YRaq+2CBt/jTff CM/5mWTPz/l3ffzMiePEzNRolD0pw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrkedvgdektdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6305030610E8; Thu, 20 Feb 2020 10:37:20 -0500 (EST) From: Thomas Monjalon To: Ye Xiaolong , taox.zhu@intel.com, Ferruh Yigit Cc: dev@dpdk.org, konstantin.ananyev@intel.com, wenzhuo.lu@intel.com, stable@dpdk.org Date: Thu, 20 Feb 2020 16:37:18 +0100 Message-ID: <5029938.usfYGdeWWP@xps> In-Reply-To: <2b14bca2-f69c-bd29-8e6c-65a174ed609e@intel.com> References: <1577328342-216505-1-git-send-email-taox.zhu@intel.com> <20200215154150.GI16933@intel.com> <2b14bca2-f69c-bd29-8e6c-65a174ed609e@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix blocking system events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/02/2020 14:01, Ferruh Yigit: > On 2/15/2020 3:41 PM, Ye Xiaolong wrote: > > On 01/15, taox.zhu@intel.com wrote: > >> From: Zhu Tao > >> > >> IXGBE link status task use rte alarm thread in old implementation. > > > > s/use/uses > > > >> Sometime ixgbe link status task takes up to 9 seconds. This will > >> severely affect the rte-alarm-thread-dependent a task in the > >> system, like interrupt or hotplug event. So replace with a > > > > s/a/an > > > >> independent thread which has the same thread affinity settings > >> as rte interrupt. > >> > >> Fixes: 0408f47b ("net/ixgbe: fix busy polling while fiber link update") > > > > Should be: > > > > Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update") > > > >> Cc: stable@dpdk.org > >> > > > > Applied to dpdk-next-net-intel with Konstantin's ack, Thanks. > > > > Shared build is failing because of missing pthread library, fixing while merging > to next-net: One more thing looks strange in this patch: ixgbe_dev_cannel_link_thread Should it be ixgbe_dev_cancel_link_thread ? Note: I looked at it because I am not sure multiplying the interrupt threads is a good idea. Basically the link status management is too long in this driver. Instead of fixing the root cause, you move the annoying workload somewhere else. But it is still there... Please could you work on a long term fix?