From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F716A0C4D; Mon, 4 Oct 2021 16:53:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E2C74124E; Mon, 4 Oct 2021 16:53:25 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 0273D41236 for ; Mon, 4 Oct 2021 16:53:22 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10126"; a="222900121" X-IronPort-AV: E=Sophos;i="5.85,346,1624345200"; d="scan'208";a="222900121" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2021 07:22:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,346,1624345200"; d="scan'208";a="523326768" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 04 Oct 2021 07:22:02 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 4 Oct 2021 07:22:02 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 4 Oct 2021 07:22:02 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 4 Oct 2021 07:22:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hd+wp8N+5nbpWnc1XVPLLE9P+lZvnPOBVg2axxdbZt6XBYcRS+9M4Xa1Cy4dkb4s/9ole4RMfJ99QRnB2Kd6RBc/SW8YBNfmtvgv0qO/ADRIYqsgvMQg5Dp+R5KAVS3qAyIifjcJsaixwAZ/+5Pbjxng/7ZeY9W6ZqzjRwlTg1kSTQHfp5E62P0kz0D96R1djh+rf74qHsGU8R1215E/ofQdAC14rUi8FNhALmg9X8XlFKyyh4cEzQUx0FFZqsYfBf7csPY6GusUkoqPpeUQJcg7Hu6Jkz3re3y8VPdxUtwApWGnq02lj9gbbI9zwPir2/ZdXNFx3b39c3HBH72YRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r4g7/5t8ufsAnetYsWM3ka095TyxfrVmWVWDka7aQ70=; b=oZ14ChWmzIq3c/sUYKTzUzDLrHnvcWScQZrskPWN1HV7/XL+0lUCAtgr1lEQe3S9PJnwjXGs2o+z8XvVvBA3JCYUpS42iw5Cx+e5udtUQ6lSTvVuJSpE5nM76+hy3ytKhw5o2zJBOvKc/2VKpWbeH7adF9C6mCquzsAQX5trIj0V6RUc1OOl9sc69iGlzx9V9MH9soq3sQpWeeBWq79CXjjfehK8mu/nl9H0qYUYdKCqFMggEMFdbiYy+YsUtUU6WmG0S+pV9F26SH7l3SgE0qaZzTxR9uhGPU2CzIAa8sJPfFulQhO/LKHo7nawZoyLgzi4wfYGlKT86GqAKDEvzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r4g7/5t8ufsAnetYsWM3ka095TyxfrVmWVWDka7aQ70=; b=dtAPi6J29+C66wzabSb7NAms7PQ/YpS+EM3ao0AHC01C/Vus4C+i6FEBLMFD1BgPZfzIAxf1yJ52hZaNnwG2ibpryOezG5XemEnw6s9/OOWEJC8GyzJ/Ys7wv5sQBMpnFbZr3Prbua4aCxgN0ES/s67NNbVmpQQAOn5+p1/bDtY= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) by MWHPR11MB2048.namprd11.prod.outlook.com (2603:10b6:300:27::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Mon, 4 Oct 2021 14:22:00 +0000 Received: from CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::7c6e:d458:33ed:e579]) by CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::7c6e:d458:33ed:e579%7]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 14:22:00 +0000 From: "Nicolau, Radu" To: "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "Doherty, Declan" , "Sinha, Abhijit" , "Zhang, Qi Z" , "Richardson, Bruce" , "Ananyev, Konstantin" References: <20210909142428.750634-1-radu.nicolau@intel.com> <20211001095130.3343083-1-radu.nicolau@intel.com> <20211001095130.3343083-7-radu.nicolau@intel.com> <78f20f9f-9bc2-a033-7342-9ccf2d43e2aa@intel.com> Message-ID: <50315c02-be0e-1411-4824-70503f0f0061@intel.com> Date: Mon, 4 Oct 2021 15:21:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: <78f20f9f-9bc2-a033-7342-9ccf2d43e2aa@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: DB6PR0202CA0027.eurprd02.prod.outlook.com (2603:10a6:4:a5::13) To CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) MIME-Version: 1.0 Received: from [192.168.1.12] (109.255.186.106) by DB6PR0202CA0027.eurprd02.prod.outlook.com (2603:10a6:4:a5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13 via Frontend Transport; Mon, 4 Oct 2021 14:21:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 77dd27d0-4e97-4188-49b2-08d987425413 X-MS-TrafficTypeDiagnostic: MWHPR11MB2048: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eycLShyVLd5obkfpQkp8fhD2wU0keHvaeBSTVhIYAeFaaCjcXI4exBWL0TcbLTHebdRkoj9nFtIYU6oTbPtN3yO0SCDbbxJhSC6WGmIj2P32fMW5tpblJITLnfFsEfXYshADeIfXbnkUV3N8QfXw1EDTbhqBsypUF9/frIeGhCQdw7O6/zs92jXKBHDTU+VTk3X0M5RX78o6Ii5mfGpAfqAhSS5gVZ0OiuLmPbepIm04IrRDw8CwlYnpm4cqjClepuG9dRuADPYhsMV8xrHN3AeD7vyzz72rO8tphmSVRN3IyA8txW9zt8NTdOD+E6KW05t41RvCm3cf6EjjrP4pbxMR86xmCsiux8h6EievpJjpRE/AoAp0TNBZ2FqDoj562VeoyahHXnqbkToU9J9zbEQK9xmTg290aQuWzDSe4/QhelHDNAROlw9gL41twpNK6mD5cXKYVkFUWhEUR5KKMNXLiAPfeSd1ndgFm+hjmSmlyaRUniE4f4Ye/QWVl20chSwfvkME3YNLZ6PYpL++FY/7SFFkRcUpN7sFJ3zeyaLxkEdIY3MLdDPw3BrSh9Q4rcPlxxJBHx5yUz2Bobc328OvahYJSmGHci7U9k+/YprFuG55+LSQfyos0XAR2IB6KIInqO8JmLtbUbkZKVfwgIqa1jp6o+V4295WvNT5poPF8kSX6akKT7dSET5dUNY+eVrKgzwHLC3EmKFUuGvPhDBjSnNkmi34gzdp7mSPBLW/7xfO9m5FlKa+ZqXjbYTc X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(31686004)(186003)(38100700002)(36756003)(5660300002)(110136005)(956004)(54906003)(8936002)(2616005)(6636002)(53546011)(86362001)(6486002)(55236004)(83380400001)(2906002)(6666004)(508600001)(66476007)(66556008)(66946007)(31696002)(4326008)(26005)(316002)(107886003)(16576012)(8676002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHFtdytxdUdEckkvTGZiUFQ3cXhLdFJIQmxPY1ZmWkQzS1VjeTBwTSt4RzdU?= =?utf-8?B?dE5aQ3VwYWY4dVBmenNLMVhxTDI4a3d3ZW01dWxrMjBGRmlWVk9qdVYxTEk0?= =?utf-8?B?YXB2M0tqQlg5YjJkK2t6TS83LzdlbGhtQmYwWnptdE5yRXFOK2R5NDMzY1hM?= =?utf-8?B?NFNIakx6Nm5LY2tGZU9hd3Y3S1VzR1VkMk1tVnRTdTFiTkpOd2krSXNlWXhU?= =?utf-8?B?eXk3d2o1YUpFb2JtSGpJOFduNkxSa210cEl2MFQ2N1VDenpoMVFqbzRGVHd4?= =?utf-8?B?MzdVQ3NBSmhleUl1djRLaWV1RXdGck05dXdsV3FrU3hyanVaV0lnY25qZTkz?= =?utf-8?B?WTdpUG5ONzlralBBTVZ6MGZLMXMxVVgwdWJDRlFONGNlbEUzRnZqYWhWeHJa?= =?utf-8?B?REt2RldrQUUxVUpxeHN3U0FCN3g4YnZUNkk3S09tQUxMM0M5eVpkRFBqY21T?= =?utf-8?B?cXVoSEdvbUZkaGVMWHErQjNLZU9kbE5EU1hjWXFoaHY1cEQwU1JEdmlCeElq?= =?utf-8?B?RU43R1FxVElNMUI4alpDdmtuQ1JHU1ROU0hCZm1IaTZWbmtMU2d0WFEvVGhV?= =?utf-8?B?bHVjWXpmWVRuNlJiZVpJOHg1MmFzbkt5QVFGeVdNR1RDQWwzR3VjY2pMYXQy?= =?utf-8?B?bUc0b2txVUQxZk9QRk1OWHBuN05OYXgyN3NkdkZZbThmelJ6VzEzdUR0M0ZH?= =?utf-8?B?V0Q5NFhYOVlUMnMya2Y5Vi9FTDNkeDBzYkZickpzblV0bnZKKzR4TDBnZ3lO?= =?utf-8?B?dFB0ZFh5MTA5WXlCQUFHYWljYkhaY2puYzJQZ0JabkYvR2F0UVBrY0NOVW84?= =?utf-8?B?ZGNld1BFS2g2dU4xV3RUNlpNdW1NNHc5VHBOc3IzVDBaYlZhR2RCTWZ6Nkh6?= =?utf-8?B?SDkxSWh2SE1uTDBaclhWVktXT0hRUXJLaDQwR2wwY2xlUFZHYTROUGc0a0Yw?= =?utf-8?B?a3VVWmpXdVRTNHhhVGlOMXdGZDBRNEhNTy96VU1UQVhJTzlVek4wMk85dFBE?= =?utf-8?B?VDBUWWRnckpreFU2dWI5RGptTzZRUHM2YkhINjljNWJuMzJuOTNoN25zamRr?= =?utf-8?B?aUNlR280dENQdlVncGNMR2pNS3JKQjJ6N1h5TTlHc3RzYXJjamhxeWNZeDdt?= =?utf-8?B?Q0Y3Z1hFUnZQZmFmR3pkOVkveWtONEF4N0ZMa1FVaTZmRU5uT2FQK3Nac3Fk?= =?utf-8?B?ZUZOYkw2ZldkQmZINldWSXQ4N2NSQWJuWHpVQVk2SkpJTVhzT21ZMUJ1MU1k?= =?utf-8?B?cW1qMDFvZzFOWFU0VjhsMDdjSDBIUVp3VlpjZFQ3aWhnQ1J1VnpuSGY2WWFD?= =?utf-8?B?ZDdJT0QzMlJBbElRYUFUME5UcVJFYlh1NVVPS3ZJVGFqWWhDVmRJbk5VMHl5?= =?utf-8?B?M3REc1BXUEV0a1MrekthTThLcGRhVnduUkR1L1JGRmtSZXhYRzkzZk9EZ1Y0?= =?utf-8?B?aTlsVzAzN1VEWVowT2Q0SnhIM3ovbEMzM1RrQ3pCTlNqWFZ1U3NKNjdMWnBl?= =?utf-8?B?YnFWWHlra2N3a2l1dnRGbnZqYU1qZzZiZC9CRnByUUtiRGdJc01NYWxZOVo3?= =?utf-8?B?OHpKRE1zajlpbS92Yy91bk5yRVVqM3Zscll1amU4RTFHN1RUQjEreis5TUZi?= =?utf-8?B?aHdjNThoOXNBaDM1MkczUWhEU1NLaFFmQ2VJOXpHQnlLUG03bnQxenFTc3gv?= =?utf-8?B?cU1ZZnprN2pTdTlCREt3bWdZRHVJNS81K0VUeVlWRnpCRmZOMUpOWUNYWDZK?= =?utf-8?Q?/+59S0XiFckJ7I2gxlTlK90/hTQnaHO4jx+7xwm?= X-MS-Exchange-CrossTenant-Network-Message-Id: 77dd27d0-4e97-4188-49b2-08d987425413 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 14:21:59.9878 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YSOCNDCG2xTgJCFKc4wotUTWeifxzPACiv+IQ+SJSffTEC+To3Vmm0zaIYQom16+iKiS4Aq/u61XQ3R3tvBshA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2048 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 6/6] net/iavf: add watchdog for VFLR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/4/2021 12:18 PM, Nicolau, Radu wrote: > > On 10/4/2021 3:15 AM, Wu, Jingjing wrote: >> >>> -----Original Message----- >>> From: Nicolau, Radu >>> Sent: Friday, October 1, 2021 5:52 PM >>> To: Wu, Jingjing ; Xing, Beilei >>> >>> Cc: dev@dpdk.org; Doherty, Declan ; Sinha, >>> Abhijit >>> ; Zhang, Qi Z ; >>> Richardson, Bruce >>> ; Ananyev, Konstantin >>> ; >>> Nicolau, Radu >>> Subject: [PATCH v4 6/6] net/iavf: add watchdog for VFLR >>> >>> Add watchdog to iAVF PMD which support monitoring the VFLR register. If >>> the device is not already in reset then if a VF reset in progress is >>> detected then notfiy user through callback and set into reset state. >>> If the device is already in reset then poll for completion of reset. >>> >>> Signed-off-by: Declan Doherty >>> Signed-off-by: Radu Nicolau >>> --- >>>   drivers/net/iavf/iavf.h        |  6 +++ >>>   drivers/net/iavf/iavf_ethdev.c | 97 >>> ++++++++++++++++++++++++++++++++++ >>>   2 files changed, 103 insertions(+) >>> >>> ... >>> >> Besides checking VFGEN_RSTAT, there is a process to handle >> VIRTCHNL_OP_EVENT  from PF. What is the change for? Any scenario >> which VIRTCHNL_OP_EVENT  doesn't cover? >> And how is the 500us been determined? > > Hi Jingjing, thanks for reviewing, I think this can be handled with > the VIRTCHNL_OP_EVENT  with no need for a watchdog alarm, I will > rework the patch. > Hi Jingjing I went over this with Declan, the reason it was added is that we can actually have a hardware initiated reset that may not trigger an event; and also the kernel driver is implementing a similar mechanism. The 500us seems indeed excessive I will update the patch to use a configurable value with the default of 5ms, as the kernel driver does.