From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id AFFB81C00 for ; Wed, 10 May 2017 17:18:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5D7AD2070C; Wed, 10 May 2017 11:18:06 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 10 May 2017 11:18:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=fujDx2Yk/N1J7dG KNEAggJczhHU6NYq3amyK/vEqWWM=; b=RhyTr+pGubExdnBCYLVlxIxgXQ6VPR/ +kdTDa2Vu9ln7Wi1d53xBx1GYxw3mVwU9H/0NjNhVnMQwqvl+dTQHoGYvt/cEmhU iJLs7LWODfwbUSNCxg9umbMpB3LH7ktE33h8XnUPN5owN0dj9LOdsGQ4IGifG/nO aqy5QKDkwGm0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=fujDx2Yk/N1J7dGKNEAggJczhHU6NYq3amyK/vEqWWM=; b=Rzk/BePd AiwcCifHMI2nXXzpwpO+3WsrZIGpz0vT6RGkGGMY2+IAbpIeefzZhIO1p3iP5ghj 0EXdZFMikEFh3Cpc8PhH8zLJNa1BI7G44EFTWsM3frYMqf73UkXXDJ0b7OWiVo/u g15jQFmT8Qta4F2vtBds1/H5tVeDuEDtmSZf/SbFeiy1HkVXdD7X1Pe4orE0Ocis G+499Lbq9XT/bm05Aq13E/vpOx98MzfM4cYTu+ByoRXHapm3ilGB/BGMu8SuDfi3 45j83rBIACE2emiFcLhHeS9dV7KJJuJFrjeImHwKCuNbpV5u4oizVr9lQYWOt7fu wfqUJGPjcUjZCw== X-ME-Sender: X-Sasl-enc: L55MmfJg3GTxyDveWbBFrcd35GOLzWJo88SUW3vtZSKp 1494429486 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1447124926; Wed, 10 May 2017 11:18:06 -0400 (EDT) From: Thomas Monjalon To: Wei Dai Cc: dev@dpdk.org, Laurent Hardy , "Roger B. Melton" , Ferruh Yigit , wenzhuo.lu@intel.com, konstantin.ananyev@intel.com Date: Wed, 10 May 2017 17:18:05 +0200 Message-ID: <5042107.JggcIGmKYW@xps> In-Reply-To: <59130895.90503@6wind.com> References: <1494399602-33955-1-git-send-email-wei.dai@intel.com> <8ad4912d-05d5-fdad-8bb5-a3e414c45738@cisco.com> <59130895.90503@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 15:18:07 -0000 10/05/2017 14:33, Laurent Hardy: > Hi Ferruh, Wei, Roger, > PSB > I also redo test plan provided through > http://dpdk.org/dev/patchwork/patch/20502/ > > Thanks & regards, > Laurent > > On 05/10/2017 02:20 PM, Roger B. Melton wrote: > > > > > > On 5/10/17 5:50 AM, Ferruh Yigit wrote: > >> On 5/10/2017 8:00 AM, Wei Dai wrote: > >>> hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not > >>> be called directly. It had better be replaced by calling > >>> ixgbe_get_media_type( ) to avoid crash. > >>> > >>> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated") > >>> Cc: stable@dpdk.org > >>> > >>> Signed-off-by: Wei Dai > Acked-by: Laurent Hardy Removing stable@dpdk.org as the bug was introduced in 17.05-rc3. Applied, thanks