From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3DB7A0C41; Tue, 3 Aug 2021 10:19:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F48C411A7; Tue, 3 Aug 2021 10:19:21 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 30AD040E32 for ; Tue, 3 Aug 2021 10:19:20 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C85B25C0116; Tue, 3 Aug 2021 04:19:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 03 Aug 2021 04:19:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= EDkbl4tdxHNQPXzVSoKxC379/0WxAqUNvZfiVv9RR6U=; b=Jhmd8/nGZc4ue4SW VCC/OojRFVceD4nBu7PU+VXo/oyCtCeKfrIZYLLAqvSGG4DOeSETGaA2EBpPMhHo JKdqqLtPIzbEyEqLsbjIvJhwHhBnVo8kCEk5/vhjjNZ2oHAEjpxMnGozAY0ePj8K l6b7qe+S/64a8P7BbMiaN6i8KH9AUHDxp243rv8I9ubH0meSuTH2j6luWsuWLWhS VcE3Lg81LLUK0451CvKyddgfKqUoO4oRDlpBlGHtplBxhTCY70l7l/pn9zFJvkRq XRxFYnsbEpZ8bm7kMxmmrrQQ6DqULTjaR5GClUXLXyQc5K/dWw8M5lh4QZpCdxFm tb8kAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=EDkbl4tdxHNQPXzVSoKxC379/0WxAqUNvZfiVv9RR 6U=; b=tUOKbyvnaktGsCJbJtNbMP3XFy8zVFTdWSHtVuMlBhiMabmRNiXevSmNG Vpwd2rb8fET5f1LlgtP2sQSGJjk54FquvijRIAWt4nKCE00g04DkCah4nnweIJXD aKu4cC8CDSQqtV4ZkFUsZHmo9rQOq1yPgwZGdqJgiMglonCtM5XYnxeasZmv+jo1 qgAbpzGkI01/n5dAgFYcZRoHKazuhFiJyoDmC45F9opjHhLbGy/D94ZLCiMxOJo4 aaHSvumIJmZweNw2vcNWdU2NYFLIlyWxXOlKsJJniH4klZCw8PAwt9KzjHoMrBsu 6PxBiTcqZJPtwgir4sgp2PwSrcYfA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrieegucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofho nhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrth htvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheetffdvkeef gedunecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Aug 2021 04:19:15 -0400 (EDT) From: Thomas Monjalon To: "Xia, Chenbo" Cc: "dev@dpdk.org" , "Yigit, Ferruh" , "dev@dpdk.org" , "mdr@ashroe.eu" , "david.marchand@redhat.com" , "Richardson, Bruce" , "andrew.rybchenko@oktetlabs.ru" , "Ananyev, Konstantin" Date: Tue, 03 Aug 2021 10:19:13 +0200 Message-ID: <5042457.bdkhJjDchz@thomas> In-Reply-To: References: <20210601084131.4277-1-chenbo.xia@intel.com> <2288461.sk2knC87vJ@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/08/2021 03:52, Xia, Chenbo: > Hi Thomas, > > From: Thomas Monjalon > > 27/07/2021 10:44, Bruce Richardson: > > > On Mon, Jul 26, 2021 at 05:56:17AM +0000, Xia, Chenbo wrote: > > > > From: Yigit, Ferruh > > > > > On 7/23/2021 8:39 AM, Xia, Chenbo wrote: > > > > > > From: dev On Behalf Of Chenbo Xia > > > > > >> +* pci: To reduce unnecessary ABIs exposed by DPDK bus driver, > > > > > "rte_bus_pci.h" > > > > > >> + will be made internal in 21.11 and macros/data > > structures/functions > > > > > defined > > > > > >> + in the header will not be considered as ABI anymore. This change > > is > > > > > >> inspired > > > > > >> + by the RFC > > > > > https://patchwork.dpdk.org/project/dpdk/list/?series=17176. > > > > > > > > > > > > I see there's some ABI improvement work on-going and I think it could > > be > > > > > part of > > > > > > the work. If it makes sense to you, I'd like some ACKs. > > > > > > > > > > > > > > > > Acked-by: Ferruh Yigit > > > > > > > > > > I am for reducing the public ABI as much as possible. How big will the > > > > > change > > > > > be? Is the 'rte_bus_pci.h' used other than './drivers/bus/pci/'? > > > > > > > > I don't see big change here. And I am not sure if I understand your second > > > > question. The rte_bus_pci.h will still be used by drivers (maybe remove > > the > > > > rte prefix and change the file name). > > > > > > > The file itself will still be exported in some cases, where the end-user > > > has their own drivers which need to be compiled, so I'd recommend keeping > > > the rte_ prefix. However, I think making all bus APIs internal-only to DPDK > > > is a good idea. > > > > I don't understand how it can exported _and_ internal. > > I think we can use the meson option 'enable_driver_sdk'. The first use case is in > lib ethdev for exporting internal APIs for out-of-tree drivers. For pci bus, I > think the use case is similar: users who want to build out-of-tree drivers can > set the option true to export pci header but the structs/functions are marked > internal. Make sense to you? I understand the intent. You are saying an out-of-tree driver is considered internal. Let's see how it works for real.