From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id A0CBE8E8E for ; Mon, 23 Nov 2015 11:43:04 +0100 (CET) Received: by wmvv187 with SMTP id v187so154037618wmv.1 for ; Mon, 23 Nov 2015 02:43:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=I5OsszUINU1etL50QHyoqMSjm9fwkUyU6p0UI8vo110=; b=M9bsibWHn7doMPf1INPmbiKbqGOimB9KVgtEL3ydPU0RhqiUdv4j561ND8ea6P2vuW M+sIO+dlzUHjd0gLVRd2jmtJQzHcT4+tMokndgQ2qUc/QYiEOC1QRlJud9YwmGobUNLo gkD7WubvqS0Gl6BJ0+nRyGNt2cZ29yR3BdcnCPWQEQ9GuCSUHNVD9f45Tgr7unH6S8J3 16BxTRkyYo1xQI4QZJ7qGdqgO+T+a604RvD4e2Gj5Hvf7/k46utNt8xq0VWpuhCednh6 zH0lm/6dybyQiJj9FbnnBdJQ9Sw64BDtw95Wb/Fr8YORin+e8jI75VdXdfK50eAJeYTH bGqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=I5OsszUINU1etL50QHyoqMSjm9fwkUyU6p0UI8vo110=; b=gZttn2ncN375np9jB3vglYf4pqsuQmJpBH8J6bOH6uMnlUfRCatTAJg2PDyIBRVTHx qn3vMQvFmBk3iEx8rRx+55T6/7YsJ0kR+La5NUgerk7joyxoQnIkYbEiiKLpQ/SbJcKV 1DzjJrRwrp8V53rWcurZLaFdHZ1Od5NvTqvuEmkT4rN19rfOWROtipRhsIowklWQGwmu 0RQi6kGwHbRAW0QxYbQgy9EWY9Tb/Ce7ZFxCY0WM23EtrLbBVzciwJeYXO1kHAVzeArs A4WwB5ZZqhHeFauvDpBeNvuPfXgySaHttYz/3qcsvjoH5RQ8LEnfwx/QU6MZNSKjyi5m exRg== X-Gm-Message-State: ALoCoQmGtqTvAhqRbgxyNZXbo6q6PEKbbZXui5GlDiAtiQDYbebl9ILRy99XhbCR/GgF2RmRdtSJ X-Received: by 10.28.224.7 with SMTP id x7mr14794825wmg.17.1448275384480; Mon, 23 Nov 2015 02:43:04 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id 186sm12580005wmv.9.2015.11.23.02.43.03 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 23 Nov 2015 02:43:03 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Mon, 23 Nov 2015 11:41:48 +0100 Message-ID: <5046573.RFcWRsU8GT@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <5652AC5A.4080005@redhat.com> References: <923ebe527219fa16ca91e74b416b978803056d70.1447829123.git.pmatilai@redhat.com> <5652AC5A.4080005@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal: fix plugindir processing to be filesystem agnostic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2015 10:43:04 -0000 Hi Panu, 2015-11-23 08:04, Panu Matilainen: > On 11/20/2015 06:38 PM, David Marchand wrote: > > It looks like you would skip the symbolic links while you were not before. > > Intended ? > > Intended. We want to accept symlinks in the driver directory, but the > actual drivers are always regular files. No we use symbolic links: http://dpdk.org/browse/dpdk/commit/mk/rte.lib.mk?id=133b75923 http://dpdk.org/browse/dpdk/tree/mk/rte.lib.mk#n170 On the same topic, you've added a check in 9f8eb1d9: + if (stat(solib->name, &sb) == -1) { + RTE_LOG(ERR, EAL, "Invalid plugin specified: %s: %s\n", + solib->name, strerror(errno)); It is a regression because we cannot anymore load a plugin from LD_LIBRARY_PATH without specifying its full path. It can be tested with scripts/test-null.sh. How do you suggest to fix it? Thanks