From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8F61A057B; Wed, 15 Apr 2020 15:40:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 954511D716; Wed, 15 Apr 2020 15:40:14 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id ACB1D1D715 for ; Wed, 15 Apr 2020 15:40:12 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 47CC75C01B2; Wed, 15 Apr 2020 09:40:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 15 Apr 2020 09:40:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=hknJKClR1pjQR443yS1geETE5sKbTiX/GFn0Mr5PvwE=; b=jNIhqxkOt8AI Q7wCoEziOuJ1k1oclq2ApFASyEpUoIazGMnb7Mt5SyOTwDeqL5iRcx+oS6MXJn+z 2wfOZjmo338sGOgB5AWV0TxcK2vPkace5KsCFeuOlxXKfzWG+1jyPZ/mSZ7aq9bR lgA/xG2YnBRjJsokeSSnehsp8XnBGuk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=hknJKClR1pjQR443yS1geETE5sKbTiX/GFn0Mr5Pv wE=; b=DvGDFryu3dr5z8i2hUAS+gFOJLCrV4rGED4WYOOSWsBwKWqLUZiThevaT nEj7bvY30DdcxKfyQ93v2wbB3grTDhcSsMI2QQkDKTMikd514pSgf78kReeGsz7O j3M5x21RnH7adwRDNrvlV1lCDHZx7m1yrTP3wOKTOqwGGNxo7m8zLj0pbxyPZGSX hqiYDrQtYw7oNT4CdKHcaGGK7vw7wMHjHp7CZQ4woj7YyqvOmfBTToAwPxlG4OQw e+lEPrX5Abgv+8XbUXZ6AAkaTvRxi7gaoBIgVIbHGnisKxaZQaiutg/WQPH2jwnI kZM3+wv+ghYci+FkFzVRGm8qKB1Yw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfeefgdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 836D33280060; Wed, 15 Apr 2020 09:40:10 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev , Bruce Richardson , Lukasz Wojciechowski , Aaron Conole , Ruifeng Wang , Gavin Hu Date: Wed, 15 Apr 2020 15:40:09 +0200 Message-ID: <5047802.fW5hKsROvD@thomas> In-Reply-To: References: <20200409180332.592074-1-thomas@monjalon.net> <20200415131954.2006010-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] test: remove meson dependency on /proc file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/04/2020 15:36, David Marchand: > On Wed, Apr 15, 2020 at 3:20 PM Thomas Monjalon wrote: > > --- /dev/null > > +++ b/app/test/has-hugepage.sh > > @@ -0,0 +1,9 @@ > > +#! /bin/sh > > +# SPDX-License-Identifier: BSD-3-Clause > > +# Copyright 2020 Mellanox Technologies, Ltd > > + > > +if [ "$(uname)" = "Linux" ] ; then > > + cat /proc/sys/vm/nr_hugepages || echo 0 > > +else > > + echo 0 > > +fi > > diff --git a/app/test/meson.build b/app/test/meson.build > > index 777c536ae0..04b59cffa4 100644 > > --- a/app/test/meson.build > > +++ b/app/test/meson.build > > @@ -396,15 +396,7 @@ dpdk_test = executable('dpdk-test', > > install_rpath: driver_install_path, > > install: true) > > > > -has_hugepage = true > > -if is_linux > > - check_hugepage = run_command('cat', > > - '/proc/sys/vm/nr_hugepages') > > - if (check_hugepage.returncode() != 0 or > > - check_hugepage.stdout().strip() == '0') > > - has_hugepage = false > > - endif > > -endif > > +has_hugepage = run_command('has-hugepage.sh').stdout().strip() != '0' > > This change will force no-huge mode on FreeBSD while before we were > running with hugepages. Indeed I propose to squash this change to maintain the old behaviour: +elif [ "$(uname)" = "FreeBSD" ] ; then + echo 1 # assume FreeBSD always has hugepages