From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 790504CA9 for ; Fri, 21 Dec 2018 01:47:21 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0C0CB2221C; Thu, 20 Dec 2018 19:47:21 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 20 Dec 2018 19:47:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=WNzssLSf6/kIcK+B/swbuKkjMi6sLQxGFAEq1t21ltA=; b=F4oJZyFqQ2zo iQmBGb+OakRXU4aWST5fWUcyEMRTaE+GHY0Ih3j4978aTCFhA5MXft2D6doCj+2M dQLD9HE4oDdbVjXCPIibbtTg+4ncN5iHRtOMsbdvEETrcanL0Ojwif3NNnw12RQL f+fEcubgWV1pWptEvCSraQTGmHkUZco= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=WNzssLSf6/kIcK+B/swbuKkjMi6sLQxGFAEq1t21l tA=; b=pdpMteyPdxjTXXJfP6WiUnRPqzW/JN6sg4yJg7PdnW6jXuYzMKB5FTa9D If/VGi4YxRgQzvUK1Nt9QTR7VVLWhaaRpMcb5pvUxbYgzKqMHqJPJp4Dnn0ItcXS wvFXXDjFGoIDCcQsSkdhGE38dUo1YS6zPiw7RCxb9BvkmOSjbCEBBeKOX/jSFPCo xujEkkg44I9VlektH6W6VD4MSJJmtGUrb7O0o54OenaOBwoCNdxF48+7DznBjbC9 dgTXKVqsBBBeOJAmYmgM5McYBbHH0wp/0R+W6M9odVruvvgofkKWw7iIJvmnDea8 4IcLmLamtiiXnY2rZo+M/3iXjpnzw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejgedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7CC2CE436E; Thu, 20 Dec 2018 19:47:19 -0500 (EST) From: Thomas Monjalon To: Honnappa Nagarahalli Cc: dev@dpdk.org, Bruce Richardson , pablo.de.lara.guarch@intel.com, yipeng1.wang@intel.com, gavin.hu@arm.com, nd@arm.com Date: Fri, 21 Dec 2018 01:47:18 +0100 Message-ID: <5048136.3VFI2TIjne@xps> In-Reply-To: <20181220135917.GA13596@bricha3-MOBL.ger.corp.intel.com> References: <20181122025156.42217-1-honnappa.nagarahalli@arm.com> <20181220135917.GA13596@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] hash: fix out-of-bound write while freeing key slot X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 00:47:21 -0000 20/12/2018 14:59, Bruce Richardson: > On Wed, Nov 21, 2018 at 08:51:56PM -0600, Honnappa Nagarahalli wrote: > > Add a debug check for out-of-bound write while freeing the key slot. > > > > Coverity issue: 325733 > > Fixes: e605a1d36ca7 ("hash: add lock-free r/w concurrency") > > Cc: honnappa.nagarahalli@arm.com > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Steve Capper > > Reviewed-by: Gavin Hu > > --- > > lib/librte_hash/rte_cuckoo_hash.c | 4 ++++ > > lib/librte_hash/rte_cuckoo_hash.h | 11 +++++++++++ > > 2 files changed, 15 insertions(+) > > > While I think enqueuing a free slot should ever fail, I don't see an issue > with having a check for that. > > Acked-by: Bruce Richardson Applied, thanks