From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 15ECC8054
 for <dev@dpdk.org>; Tue, 16 Dec 2014 19:49:16 +0100 (CET)
Received: by mail-wg0-f46.google.com with SMTP id x13so18198240wgg.5
 for <dev@dpdk.org>; Tue, 16 Dec 2014 10:49:15 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=0jv35FAwpB1PT0b586RgfUmvlkG8E3pcKSoNeUTM6Z0=;
 b=WCwKREtxGwcgLjwdFwtDP2pTxFd+iDQx5grodXtypGTNmSLLmMOXB5EB+vK9NkyZQe
 1UyjeezeFbUYaHlTMQ1Rt940yp8DjDzZJgrCZS2ikdexFmHcGxWtG/kGnZVYxdFwe0sy
 D3sTeHOLKaPN8L0lVXkSOgpf5jhjsd5oFa/UQrc3N0OFzx/9ad464pJgjR96IJx6AKoy
 LETV2Pv9901IVnsX4HL3/pbNSf/7MlINeZG1uO+8vJcrrfwrjPder43gtvyyjBqIc9DR
 3Wqn5oypboqOlsO8k3bve8rjPB1wuRfBE/kpT4YeTUzN33oVTCeuojajhdBTu1BX8EYG
 CtBQ==
X-Gm-Message-State: ALoCoQnP3z6rThPMcdH0pYthNxlaJ+/qFJ6E04gqoOVB9exlbk0DXx6cMw2ROxazCfPuFSSQjoAs
X-Received: by 10.194.85.83 with SMTP id f19mr66080990wjz.20.1418755755759;
 Tue, 16 Dec 2014 10:49:15 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id cs8sm17968960wib.1.2014.12.16.10.49.11
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 16 Dec 2014 10:49:11 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Date: Tue, 16 Dec 2014 19:48:46 +0100
Message-ID: <5049551.Sg4yn1HA6q@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <1414511329-3948-1-git-send-email-sergio.gonzalez.monroy@intel.com>
References: <1414078550-692-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <1414511329-3948-1-git-send-email-sergio.gonzalez.monroy@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: link combined shared lib using CC
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Dec 2014 18:49:16 -0000

2014-10-28 15:48, Sergio Gonzalez Monroy:
> If we set EXTRA_CFLAGS=-O0, build fails with following error:
> 
> /usr/bin/ld: test: hidden symbol `mknod' in /usr/lib64/libc_nonshared.a(mknod.oS) is referenced by DSO
> 
> Fix: link combined shared lib using CC if LINK_USING_CC is enabled.
> 
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> ---
>  mk/rte.lib.mk      |  1 -
>  mk/rte.sharelib.mk | 12 +++++++++++-
[...]
> --- a/mk/rte.lib.mk
> +++ b/mk/rte.lib.mk
> @@ -63,7 +63,6 @@ ifeq ($(LINK_USING_CC),1)
>  # Override the definition of LD here, since we're linking with CC
>  LD := $(CC)
>  LD_MULDEFS := $(call linkerprefix,-z$(comma)muldefs)
> -CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))
>  endif

Why are you removing this line?

> --- a/mk/rte.sharelib.mk
> +++ b/mk/rte.sharelib.mk
[...]