* [dpdk-dev] [PATCH 2/3] eal: update default log levels
2017-11-22 9:28 [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex Pavan Nikhilesh
@ 2017-11-22 9:28 ` Pavan Nikhilesh
2017-12-07 13:15 ` Olivier MATZ
2017-11-22 9:28 ` [dpdk-dev] [PATCH 3/3] logs: remove log level config option Pavan Nikhilesh
` (3 subsequent siblings)
4 siblings, 1 reply; 17+ messages in thread
From: Pavan Nikhilesh @ 2017-11-22 9:28 UTC (permalink / raw)
To: ferruh.yigit, olivier.matz, thomas; +Cc: dev, Pavan Nikhilesh
Use global default loglevel to DEBUG(8) and dynamic default loglevel
to INFO(7).
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
lib/librte_eal/common/eal_common_log.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
index fa9ac7247..3210cad7c 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -181,7 +181,7 @@ __rte_log_register(const char *name, int id)
return -ENOMEM;
rte_logs.dynamic_types[id].name = dup_name;
- rte_logs.dynamic_types[id].loglevel = RTE_LOG_DEBUG;
+ rte_logs.dynamic_types[id].loglevel = RTE_LOG_INFO;
return id;
}
@@ -257,11 +257,7 @@ rte_log_init(void)
{
uint32_t i;
-#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
- rte_log_set_global_level(RTE_LOG_INFO);
-#else
- rte_log_set_global_level(RTE_LOG_LEVEL);
-#endif
+ rte_log_set_global_level(RTE_LOG_DEBUG);
rte_logs.dynamic_types = calloc(RTE_LOGTYPE_FIRST_EXT_ID,
sizeof(struct rte_log_dynamic_type));
--
2.14.1
^ permalink raw reply [flat|nested] 17+ messages in thread* [dpdk-dev] [PATCH 3/3] logs: remove log level config option
2017-11-22 9:28 [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex Pavan Nikhilesh
2017-11-22 9:28 ` [dpdk-dev] [PATCH 2/3] eal: update default log levels Pavan Nikhilesh
@ 2017-11-22 9:28 ` Pavan Nikhilesh
2017-12-07 13:21 ` Olivier MATZ
2017-11-22 22:57 ` [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex Ferruh Yigit
` (2 subsequent siblings)
4 siblings, 1 reply; 17+ messages in thread
From: Pavan Nikhilesh @ 2017-11-22 9:28 UTC (permalink / raw)
To: ferruh.yigit, olivier.matz, thomas; +Cc: dev, Pavan Nikhilesh
Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
option for controlling datapath log level.
RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
control global and module specific log levels.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
config/common_base | 1 -
devtools/test-build.sh | 2 +-
doc/guides/faq/faq.rst | 3 ---
drivers/net/ena/base/ena_plat_dpdk.h | 2 +-
drivers/net/sfc/sfc_debug.h | 2 +-
examples/l3fwd-acl/main.c | 2 +-
test/test/test.h | 2 +-
7 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/config/common_base b/config/common_base
index e74febef4..e7af26cc8 100644
--- a/config/common_base
+++ b/config/common_base
@@ -94,7 +94,6 @@ CONFIG_RTE_MAX_MEMSEG=256
CONFIG_RTE_MAX_MEMZONE=2560
CONFIG_RTE_MAX_TAILQ=32
CONFIG_RTE_ENABLE_ASSERT=n
-CONFIG_RTE_LOG_LEVEL=RTE_LOG_INFO
CONFIG_RTE_LOG_DP_LEVEL=RTE_LOG_INFO
CONFIG_RTE_LOG_HISTORY=256
CONFIG_RTE_BACKTRACE=y
diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 092d3a7f3..7e9e1e187 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -157,7 +157,7 @@ config () # <directory> <target> <options>
! echo $3 | grep -q '+shared' || \
sed -ri 's,(SHARED_LIB=)n,\1y,' $1/.config
! echo $3 | grep -q '+debug' || ( \
- sed -ri 's,(RTE_LOG_LEVEL=).*,\1RTE_LOG_DEBUG,' $1/.config
+ sed -ri 's,(RTE_LOG_DP_LEVEL=).*,\1RTE_LOG_DEBUG,' $1/.config
sed -ri 's,(_DEBUG.*=)n,\1y,' $1/.config
sed -ri 's,(_STAT.*=)n,\1y,' $1/.config
sed -ri 's,(TEST_PMD_RECORD_.*=)n,\1y,' $1/.config )
diff --git a/doc/guides/faq/faq.rst b/doc/guides/faq/faq.rst
index dac805099..55dcfe9c2 100644
--- a/doc/guides/faq/faq.rst
+++ b/doc/guides/faq/faq.rst
@@ -103,9 +103,6 @@ Yes, the option ``--log-level=`` accepts one of these numbers:
#define RTE_LOG_INFO 7U /* Informational. */
#define RTE_LOG_DEBUG 8U /* Debug-level messages. */
-It is also possible to change the default level at compile time
-with ``CONFIG_RTE_LOG_LEVEL``.
-
How can I tune my network application to achieve lower latency?
---------------------------------------------------------------
diff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h
index accecf518..8cba319eb 100644
--- a/drivers/net/ena/base/ena_plat_dpdk.h
+++ b/drivers/net/ena/base/ena_plat_dpdk.h
@@ -96,7 +96,7 @@ typedef uint64_t dma_addr_t;
#define ENA_GET_SYSTEM_USECS() \
(rte_get_timer_cycles() * US_PER_S / rte_get_timer_hz())
-#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
#define ENA_ASSERT(cond, format, arg...) \
do { \
if (unlikely(!(cond))) { \
diff --git a/drivers/net/sfc/sfc_debug.h b/drivers/net/sfc/sfc_debug.h
index 92eba9c38..3f9ccf1e6 100644
--- a/drivers/net/sfc/sfc_debug.h
+++ b/drivers/net/sfc/sfc_debug.h
@@ -35,7 +35,7 @@
#include <rte_debug.h>
#ifdef RTE_LIBRTE_SFC_EFX_DEBUG
-/* Avoid dependency from RTE_LOG_LEVEL to be able to enable debug check
+/* Avoid dependency from RTE_LOG_DP_LEVEL to be able to enable debug check
* in the driver only.
*/
#define SFC_ASSERT(exp) RTE_VERIFY(exp)
diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
index e50b1a1a8..eb78decdd 100644
--- a/examples/l3fwd-acl/main.c
+++ b/examples/l3fwd-acl/main.c
@@ -68,7 +68,7 @@
#include <rte_string_fns.h>
#include <rte_acl.h>
-#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
#define L3FWDACL_DEBUG
#endif
#define DO_RFC_1812_CHECKS
diff --git a/test/test/test.h b/test/test/test.h
index 08ffe949c..8fdb3045e 100644
--- a/test/test/test.h
+++ b/test/test/test.h
@@ -204,7 +204,7 @@ struct unit_test_case {
#define TEST_CASES_END() { NULL, NULL, NULL, NULL, 0 }
-#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
#define TEST_HEXDUMP(file, title, buf, len) rte_hexdump(file, title, buf, len)
#else
#define TEST_HEXDUMP(file, title, buf, len) do {} while (0)
--
2.14.1
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [dpdk-dev] [PATCH 3/3] logs: remove log level config option
2017-11-22 9:28 ` [dpdk-dev] [PATCH 3/3] logs: remove log level config option Pavan Nikhilesh
@ 2017-12-07 13:21 ` Olivier MATZ
2017-12-07 14:07 ` Pavan Nikhilesh Bhagavatula
0 siblings, 1 reply; 17+ messages in thread
From: Olivier MATZ @ 2017-12-07 13:21 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: ferruh.yigit, thomas, dev
On Wed, Nov 22, 2017 at 02:58:06PM +0530, Pavan Nikhilesh wrote:
> Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
> option for controlling datapath log level.
> RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
> control global and module specific log levels.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Tome, removing the RTE_LOG_LEVEL goes in the good direction (less
compile-time options).
[...]
> --- a/drivers/net/ena/base/ena_plat_dpdk.h
> +++ b/drivers/net/ena/base/ena_plat_dpdk.h
> @@ -96,7 +96,7 @@ typedef uint64_t dma_addr_t;
> #define ENA_GET_SYSTEM_USECS() \
> (rte_get_timer_cycles() * US_PER_S / rte_get_timer_hz())
>
> -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
> +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> #define ENA_ASSERT(cond, format, arg...) \
> do { \
> if (unlikely(!(cond))) { \
> diff --git a/drivers/net/sfc/sfc_debug.h b/drivers/net/sfc/sfc_debug.h
> index 92eba9c38..3f9ccf1e6 100644
> --- a/drivers/net/sfc/sfc_debug.h
> +++ b/drivers/net/sfc/sfc_debug.h
> @@ -35,7 +35,7 @@
> #include <rte_debug.h>
>
> #ifdef RTE_LIBRTE_SFC_EFX_DEBUG
> -/* Avoid dependency from RTE_LOG_LEVEL to be able to enable debug check
> +/* Avoid dependency from RTE_LOG_DP_LEVEL to be able to enable debug check
> * in the driver only.
> */
> #define SFC_ASSERT(exp) RTE_VERIFY(exp)
> diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
> index e50b1a1a8..eb78decdd 100644
> --- a/examples/l3fwd-acl/main.c
> +++ b/examples/l3fwd-acl/main.c
> @@ -68,7 +68,7 @@
> #include <rte_string_fns.h>
> #include <rte_acl.h>
>
> -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
> +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> #define L3FWDACL_DEBUG
> #endif
> #define DO_RFC_1812_CHECKS
> diff --git a/test/test/test.h b/test/test/test.h
> index 08ffe949c..8fdb3045e 100644
> --- a/test/test/test.h
> +++ b/test/test/test.h
> @@ -204,7 +204,7 @@ struct unit_test_case {
>
> #define TEST_CASES_END() { NULL, NULL, NULL, NULL, 0 }
>
> -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
> +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> #define TEST_HEXDUMP(file, title, buf, len) rte_hexdump(file, title, buf, len)
> #else
> #define TEST_HEXDUMP(file, title, buf, len) do {} while (0)
For drivers, it looks correct to replace RTE_LOG_LEVEL by
RTE_LOG_DP_LEVEL, from what I see it's about dataplane logs.
For l3fwd, I'm less sure, but it could make sense too.
For test, I think we should replace TEST_HEXDUMP() by a function
that checks the runtime log level instead of relying on RTE_LOG_DP_LEVEL.
I can submit a patch for this.
Olivier
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [dpdk-dev] [PATCH 3/3] logs: remove log level config option
2017-12-07 13:21 ` Olivier MATZ
@ 2017-12-07 14:07 ` Pavan Nikhilesh Bhagavatula
2017-12-08 15:37 ` Olivier MATZ
0 siblings, 1 reply; 17+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2017-12-07 14:07 UTC (permalink / raw)
To: Olivier MATZ, ferruh.yigit, thomas; +Cc: dev
Hi Oliver,
Thanks for the review.
On Thu, Dec 07, 2017 at 02:21:21PM +0100, Olivier MATZ wrote:
> On Wed, Nov 22, 2017 at 02:58:06PM +0530, Pavan Nikhilesh wrote:
> > Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
> > option for controlling datapath log level.
> > RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
> > control global and module specific log levels.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>
> Tome, removing the RTE_LOG_LEVEL goes in the good direction (less
> compile-time options).
>
> [...]
>
> > --- a/drivers/net/ena/base/ena_plat_dpdk.h
> > +++ b/drivers/net/ena/base/ena_plat_dpdk.h
> > @@ -96,7 +96,7 @@ typedef uint64_t dma_addr_t;
> > #define ENA_GET_SYSTEM_USECS() \
> > (rte_get_timer_cycles() * US_PER_S / rte_get_timer_hz())
> >
> > -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
> > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> > #define ENA_ASSERT(cond, format, arg...) \
> > do { \
> > if (unlikely(!(cond))) { \
> > diff --git a/drivers/net/sfc/sfc_debug.h b/drivers/net/sfc/sfc_debug.h
> > index 92eba9c38..3f9ccf1e6 100644
> > --- a/drivers/net/sfc/sfc_debug.h
> > +++ b/drivers/net/sfc/sfc_debug.h
> > @@ -35,7 +35,7 @@
> > #include <rte_debug.h>
> >
> > #ifdef RTE_LIBRTE_SFC_EFX_DEBUG
> > -/* Avoid dependency from RTE_LOG_LEVEL to be able to enable debug check
> > +/* Avoid dependency from RTE_LOG_DP_LEVEL to be able to enable debug check
> > * in the driver only.
> > */
> > #define SFC_ASSERT(exp) RTE_VERIFY(exp)
> > diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
> > index e50b1a1a8..eb78decdd 100644
> > --- a/examples/l3fwd-acl/main.c
> > +++ b/examples/l3fwd-acl/main.c
> > @@ -68,7 +68,7 @@
> > #include <rte_string_fns.h>
> > #include <rte_acl.h>
> >
> > -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
> > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> > #define L3FWDACL_DEBUG
> > #endif
> > #define DO_RFC_1812_CHECKS
> > diff --git a/test/test/test.h b/test/test/test.h
> > index 08ffe949c..8fdb3045e 100644
> > --- a/test/test/test.h
> > +++ b/test/test/test.h
> > @@ -204,7 +204,7 @@ struct unit_test_case {
> >
> > #define TEST_CASES_END() { NULL, NULL, NULL, NULL, 0 }
> >
> > -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
> > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> > #define TEST_HEXDUMP(file, title, buf, len) rte_hexdump(file, title, buf, len)
> > #else
> > #define TEST_HEXDUMP(file, title, buf, len) do {} while (0)
>
> For drivers, it looks correct to replace RTE_LOG_LEVEL by
> RTE_LOG_DP_LEVEL, from what I see it's about dataplane logs.
>
> For l3fwd, I'm less sure, but it could make sense too.
>
> For test, I think we should replace TEST_HEXDUMP() by a function
> that checks the runtime log level instead of relying on RTE_LOG_DP_LEVEL.
> I can submit a patch for this.
Agreed.
Pavan
>
> Olivier
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [dpdk-dev] [PATCH 3/3] logs: remove log level config option
2017-12-07 14:07 ` Pavan Nikhilesh Bhagavatula
@ 2017-12-08 15:37 ` Olivier MATZ
0 siblings, 0 replies; 17+ messages in thread
From: Olivier MATZ @ 2017-12-08 15:37 UTC (permalink / raw)
To: Pavan Nikhilesh Bhagavatula; +Cc: ferruh.yigit, thomas, dev
On Thu, Dec 07, 2017 at 07:37:14PM +0530, Pavan Nikhilesh Bhagavatula wrote:
> Hi Oliver,
>
> Thanks for the review.
>
> On Thu, Dec 07, 2017 at 02:21:21PM +0100, Olivier MATZ wrote:
> > On Wed, Nov 22, 2017 at 02:58:06PM +0530, Pavan Nikhilesh wrote:
> > > --- a/test/test/test.h
> > > +++ b/test/test/test.h
> > > @@ -204,7 +204,7 @@ struct unit_test_case {
> > >
> > > #define TEST_CASES_END() { NULL, NULL, NULL, NULL, 0 }
> > >
> > > -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
> > > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> > > #define TEST_HEXDUMP(file, title, buf, len) rte_hexdump(file, title, buf, len)
> > > #else
> > > #define TEST_HEXDUMP(file, title, buf, len) do {} while (0)
> >
> > For drivers, it looks correct to replace RTE_LOG_LEVEL by
> > RTE_LOG_DP_LEVEL, from what I see it's about dataplane logs.
> >
> > For l3fwd, I'm less sure, but it could make sense too.
> >
> > For test, I think we should replace TEST_HEXDUMP() by a function
> > that checks the runtime log level instead of relying on RTE_LOG_DP_LEVEL.
> > I can submit a patch for this.
>
> Agreed.
Please see:
http://dpdk.org/ml/archives/dev/2017-December/083295.html
By the way, if you do another version on top of this patchset,
I think you can also do the following replacement for consistency:
--- a/lib/librte_flow_classify/rte_flow_classify.c
+++ b/lib/librte_flow_classify/rte_flow_classify.c
@@ -685,7 +685,7 @@ static void
librte_flow_classify_init_log(void)
{
librte_flow_classify_logtype =
- rte_log_register("librte.flow_classify");
+ rte_log_register("lib.flow_classify");
if (librte_flow_classify_logtype >= 0)
rte_log_set_level(librte_flow_classify_logtype, RTE_LOG_INFO);
}
diff --git a/lib/librte_member/rte_member.c b/lib/librte_member/rte_member.c
index cc9ea84ae..84354cc38 100644
--- a/lib/librte_member/rte_member.c
+++ b/lib/librte_member/rte_member.c
@@ -330,7 +330,7 @@ RTE_INIT(librte_member_init_log);
static void
librte_member_init_log(void)
{
- librte_member_logtype = rte_log_register("librte.member");
+ librte_member_logtype = rte_log_register("lib.member");
if (librte_member_logtype >= 0)
rte_log_set_level(librte_member_logtype, RTE_LOG_DEBUG);
}
Thanks,
Olivier
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex
2017-11-22 9:28 [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex Pavan Nikhilesh
2017-11-22 9:28 ` [dpdk-dev] [PATCH 2/3] eal: update default log levels Pavan Nikhilesh
2017-11-22 9:28 ` [dpdk-dev] [PATCH 3/3] logs: remove log level config option Pavan Nikhilesh
@ 2017-11-22 22:57 ` Ferruh Yigit
2017-12-07 13:14 ` Olivier MATZ
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
4 siblings, 0 replies; 17+ messages in thread
From: Ferruh Yigit @ 2017-11-22 22:57 UTC (permalink / raw)
To: Pavan Nikhilesh, olivier.matz, thomas; +Cc: dev
On 11/22/2017 1:28 AM, Pavan Nikhilesh wrote:
> Update legacy log types regex strings used for registering dynamic logs.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
For series
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex
2017-11-22 9:28 [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex Pavan Nikhilesh
` (2 preceding siblings ...)
2017-11-22 22:57 ` [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex Ferruh Yigit
@ 2017-12-07 13:14 ` Olivier MATZ
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
4 siblings, 0 replies; 17+ messages in thread
From: Olivier MATZ @ 2017-12-07 13:14 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: ferruh.yigit, thomas, dev
On Wed, Nov 22, 2017 at 02:58:04PM +0530, Pavan Nikhilesh wrote:
> Update legacy log types regex strings used for registering dynamic logs.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
> Note:
> This patchset is based on patch set
> http://dpdk.org/dev/patchwork/patch/31443/
> followed by ml discussion
> http://dpdk.org/ml/archives/dev/2017-November/081953.html
>
> lib/librte_eal/common/eal_common_log.c | 39 +++++++++++++++++-----------------
> 1 file changed, 20 insertions(+), 19 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
> index e894b75ec..fa9ac7247 100644
> --- a/lib/librte_eal/common/eal_common_log.c
> +++ b/lib/librte_eal/common/eal_common_log.c
> @@ -219,26 +219,27 @@ struct logtype {
> };
>
> static const struct logtype logtype_strings[] = {
> - {RTE_LOGTYPE_EAL, "eal"},
> - {RTE_LOGTYPE_MALLOC, "malloc"},
> - {RTE_LOGTYPE_RING, "ring"},
> - {RTE_LOGTYPE_MEMPOOL, "mempool"},
> - {RTE_LOGTYPE_TIMER, "timer"},
> + {RTE_LOGTYPE_EAL, "lib.eal"},
> + {RTE_LOGTYPE_MALLOC, "lib.malloc"},
> + {RTE_LOGTYPE_RING, "lib.ring"},
> + {RTE_LOGTYPE_MEMPOOL, "lib.mempool"},
> + {RTE_LOGTYPE_TIMER, "lib.timer"},
[...]
I agree it's much better to have the library prefixed by "lib.".
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
^ permalink raw reply [flat|nested] 17+ messages in thread* [dpdk-dev] [PATCH v2 1/3] eal: update legacy modules dynamic logs regex
2017-11-22 9:28 [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex Pavan Nikhilesh
` (3 preceding siblings ...)
2017-12-07 13:14 ` Olivier MATZ
@ 2017-12-09 13:23 ` Pavan Nikhilesh
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 2/3] eal: update default log levels Pavan Nikhilesh
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option Pavan Nikhilesh
4 siblings, 2 replies; 17+ messages in thread
From: Pavan Nikhilesh @ 2017-12-09 13:23 UTC (permalink / raw)
To: ferruh.yigit, olivier.matz, thomas; +Cc: dev, Pavan Nikhilesh
Update legacy log types regex strings used for registering dynamic logs.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
---
v2 Changes:
- Corrected dynamic log regex strings of 'librte.flow_classify' and
'librte.member' to 'lib.flow_classify' and 'lib.member'.
- Rebased on top of [1].
- reverted changes to test/test/test.h in reference with [1].
[1] http://dpdk.org/dev/patchwork/patch/32038/
lib/librte_eal/common/eal_common_log.c | 39 ++++++++++++++--------------
lib/librte_flow_classify/rte_flow_classify.c | 2 +-
lib/librte_member/rte_member.c | 2 +-
3 files changed, 22 insertions(+), 21 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
index e894b75ec..fa9ac7247 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -219,26 +219,27 @@ struct logtype {
};
static const struct logtype logtype_strings[] = {
- {RTE_LOGTYPE_EAL, "eal"},
- {RTE_LOGTYPE_MALLOC, "malloc"},
- {RTE_LOGTYPE_RING, "ring"},
- {RTE_LOGTYPE_MEMPOOL, "mempool"},
- {RTE_LOGTYPE_TIMER, "timer"},
+ {RTE_LOGTYPE_EAL, "lib.eal"},
+ {RTE_LOGTYPE_MALLOC, "lib.malloc"},
+ {RTE_LOGTYPE_RING, "lib.ring"},
+ {RTE_LOGTYPE_MEMPOOL, "lib.mempool"},
+ {RTE_LOGTYPE_TIMER, "lib.timer"},
{RTE_LOGTYPE_PMD, "pmd"},
- {RTE_LOGTYPE_HASH, "hash"},
- {RTE_LOGTYPE_LPM, "lpm"},
- {RTE_LOGTYPE_KNI, "kni"},
- {RTE_LOGTYPE_ACL, "acl"},
- {RTE_LOGTYPE_POWER, "power"},
- {RTE_LOGTYPE_METER, "meter"},
- {RTE_LOGTYPE_SCHED, "sched"},
- {RTE_LOGTYPE_PORT, "port"},
- {RTE_LOGTYPE_TABLE, "table"},
- {RTE_LOGTYPE_PIPELINE, "pipeline"},
- {RTE_LOGTYPE_MBUF, "mbuf"},
- {RTE_LOGTYPE_CRYPTODEV, "cryptodev"},
- {RTE_LOGTYPE_EFD, "efd"},
- {RTE_LOGTYPE_EVENTDEV, "eventdev"},
+ {RTE_LOGTYPE_HASH, "lib.hash"},
+ {RTE_LOGTYPE_LPM, "lib.lpm"},
+ {RTE_LOGTYPE_KNI, "lib.kni"},
+ {RTE_LOGTYPE_ACL, "lib.acl"},
+ {RTE_LOGTYPE_POWER, "lib.power"},
+ {RTE_LOGTYPE_METER, "lib.meter"},
+ {RTE_LOGTYPE_SCHED, "lib.sched"},
+ {RTE_LOGTYPE_PORT, "lib.port"},
+ {RTE_LOGTYPE_TABLE, "lib.table"},
+ {RTE_LOGTYPE_PIPELINE, "lib.pipeline"},
+ {RTE_LOGTYPE_MBUF, "lib.mbuf"},
+ {RTE_LOGTYPE_CRYPTODEV, "lib.cryptodev"},
+ {RTE_LOGTYPE_EFD, "lib.efd"},
+ {RTE_LOGTYPE_EVENTDEV, "lib.eventdev"},
+ {RTE_LOGTYPE_GSO, "lib.gso"},
{RTE_LOGTYPE_USER1, "user1"},
{RTE_LOGTYPE_USER2, "user2"},
{RTE_LOGTYPE_USER3, "user3"},
diff --git a/lib/librte_flow_classify/rte_flow_classify.c b/lib/librte_flow_classify/rte_flow_classify.c
index e6f448643..72bc8b821 100644
--- a/lib/librte_flow_classify/rte_flow_classify.c
+++ b/lib/librte_flow_classify/rte_flow_classify.c
@@ -685,7 +685,7 @@ static void
librte_flow_classify_init_log(void)
{
librte_flow_classify_logtype =
- rte_log_register("librte.flow_classify");
+ rte_log_register("lib.flow_classify");
if (librte_flow_classify_logtype >= 0)
rte_log_set_level(librte_flow_classify_logtype, RTE_LOG_INFO);
}
diff --git a/lib/librte_member/rte_member.c b/lib/librte_member/rte_member.c
index cc9ea84ae..84354cc38 100644
--- a/lib/librte_member/rte_member.c
+++ b/lib/librte_member/rte_member.c
@@ -330,7 +330,7 @@ RTE_INIT(librte_member_init_log);
static void
librte_member_init_log(void)
{
- librte_member_logtype = rte_log_register("librte.member");
+ librte_member_logtype = rte_log_register("lib.member");
if (librte_member_logtype >= 0)
rte_log_set_level(librte_member_logtype, RTE_LOG_DEBUG);
}
--
2.14.1
^ permalink raw reply [flat|nested] 17+ messages in thread* [dpdk-dev] [PATCH v2 2/3] eal: update default log levels
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
@ 2017-12-09 13:23 ` Pavan Nikhilesh
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option Pavan Nikhilesh
1 sibling, 0 replies; 17+ messages in thread
From: Pavan Nikhilesh @ 2017-12-09 13:23 UTC (permalink / raw)
To: ferruh.yigit, olivier.matz, thomas; +Cc: dev, Pavan Nikhilesh
Use global default loglevel to DEBUG(8) and dynamic default loglevel
to INFO(7).
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
---
lib/librte_eal/common/eal_common_log.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
index fa9ac7247..3210cad7c 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -181,7 +181,7 @@ __rte_log_register(const char *name, int id)
return -ENOMEM;
rte_logs.dynamic_types[id].name = dup_name;
- rte_logs.dynamic_types[id].loglevel = RTE_LOG_DEBUG;
+ rte_logs.dynamic_types[id].loglevel = RTE_LOG_INFO;
return id;
}
@@ -257,11 +257,7 @@ rte_log_init(void)
{
uint32_t i;
-#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
- rte_log_set_global_level(RTE_LOG_INFO);
-#else
- rte_log_set_global_level(RTE_LOG_LEVEL);
-#endif
+ rte_log_set_global_level(RTE_LOG_DEBUG);
rte_logs.dynamic_types = calloc(RTE_LOGTYPE_FIRST_EXT_ID,
sizeof(struct rte_log_dynamic_type));
--
2.14.1
^ permalink raw reply [flat|nested] 17+ messages in thread* [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 2/3] eal: update default log levels Pavan Nikhilesh
@ 2017-12-09 13:23 ` Pavan Nikhilesh
2017-12-12 16:36 ` Olivier MATZ
1 sibling, 1 reply; 17+ messages in thread
From: Pavan Nikhilesh @ 2017-12-09 13:23 UTC (permalink / raw)
To: ferruh.yigit, olivier.matz, thomas; +Cc: dev, Pavan Nikhilesh
Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
option for controlling datapath log level.
RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
control global and module specific log levels.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
config/common_base | 1 -
devtools/test-build.sh | 2 +-
doc/guides/faq/faq.rst | 3 ---
drivers/net/ena/base/ena_plat_dpdk.h | 2 +-
drivers/net/sfc/sfc_debug.h | 2 +-
examples/l3fwd-acl/main.c | 2 +-
6 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/config/common_base b/config/common_base
index e74febef4..e7af26cc8 100644
--- a/config/common_base
+++ b/config/common_base
@@ -94,7 +94,6 @@ CONFIG_RTE_MAX_MEMSEG=256
CONFIG_RTE_MAX_MEMZONE=2560
CONFIG_RTE_MAX_TAILQ=32
CONFIG_RTE_ENABLE_ASSERT=n
-CONFIG_RTE_LOG_LEVEL=RTE_LOG_INFO
CONFIG_RTE_LOG_DP_LEVEL=RTE_LOG_INFO
CONFIG_RTE_LOG_HISTORY=256
CONFIG_RTE_BACKTRACE=y
diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 092d3a7f3..7e9e1e187 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -157,7 +157,7 @@ config () # <directory> <target> <options>
! echo $3 | grep -q '+shared' || \
sed -ri 's,(SHARED_LIB=)n,\1y,' $1/.config
! echo $3 | grep -q '+debug' || ( \
- sed -ri 's,(RTE_LOG_LEVEL=).*,\1RTE_LOG_DEBUG,' $1/.config
+ sed -ri 's,(RTE_LOG_DP_LEVEL=).*,\1RTE_LOG_DEBUG,' $1/.config
sed -ri 's,(_DEBUG.*=)n,\1y,' $1/.config
sed -ri 's,(_STAT.*=)n,\1y,' $1/.config
sed -ri 's,(TEST_PMD_RECORD_.*=)n,\1y,' $1/.config )
diff --git a/doc/guides/faq/faq.rst b/doc/guides/faq/faq.rst
index dac805099..55dcfe9c2 100644
--- a/doc/guides/faq/faq.rst
+++ b/doc/guides/faq/faq.rst
@@ -103,9 +103,6 @@ Yes, the option ``--log-level=`` accepts one of these numbers:
#define RTE_LOG_INFO 7U /* Informational. */
#define RTE_LOG_DEBUG 8U /* Debug-level messages. */
-It is also possible to change the default level at compile time
-with ``CONFIG_RTE_LOG_LEVEL``.
-
How can I tune my network application to achieve lower latency?
---------------------------------------------------------------
diff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h
index accecf518..8cba319eb 100644
--- a/drivers/net/ena/base/ena_plat_dpdk.h
+++ b/drivers/net/ena/base/ena_plat_dpdk.h
@@ -96,7 +96,7 @@ typedef uint64_t dma_addr_t;
#define ENA_GET_SYSTEM_USECS() \
(rte_get_timer_cycles() * US_PER_S / rte_get_timer_hz())
-#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
#define ENA_ASSERT(cond, format, arg...) \
do { \
if (unlikely(!(cond))) { \
diff --git a/drivers/net/sfc/sfc_debug.h b/drivers/net/sfc/sfc_debug.h
index 92eba9c38..3f9ccf1e6 100644
--- a/drivers/net/sfc/sfc_debug.h
+++ b/drivers/net/sfc/sfc_debug.h
@@ -35,7 +35,7 @@
#include <rte_debug.h>
#ifdef RTE_LIBRTE_SFC_EFX_DEBUG
-/* Avoid dependency from RTE_LOG_LEVEL to be able to enable debug check
+/* Avoid dependency from RTE_LOG_DP_LEVEL to be able to enable debug check
* in the driver only.
*/
#define SFC_ASSERT(exp) RTE_VERIFY(exp)
diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
index e50b1a1a8..eb78decdd 100644
--- a/examples/l3fwd-acl/main.c
+++ b/examples/l3fwd-acl/main.c
@@ -68,7 +68,7 @@
#include <rte_string_fns.h>
#include <rte_acl.h>
-#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
#define L3FWDACL_DEBUG
#endif
#define DO_RFC_1812_CHECKS
--
2.14.1
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option Pavan Nikhilesh
@ 2017-12-12 16:36 ` Olivier MATZ
2018-01-12 15:46 ` Thomas Monjalon
2018-01-17 13:22 ` Thomas Monjalon
0 siblings, 2 replies; 17+ messages in thread
From: Olivier MATZ @ 2017-12-12 16:36 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: ferruh.yigit, thomas, dev
On Sat, Dec 09, 2017 at 06:53:58PM +0530, Pavan Nikhilesh wrote:
> Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
> option for controlling datapath log level.
> RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
> control global and module specific log levels.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option
2017-12-12 16:36 ` Olivier MATZ
@ 2018-01-12 15:46 ` Thomas Monjalon
2018-01-12 15:52 ` Pavan Nikhilesh
2018-01-17 13:22 ` Thomas Monjalon
1 sibling, 1 reply; 17+ messages in thread
From: Thomas Monjalon @ 2018-01-12 15:46 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: dev, Olivier MATZ, ferruh.yigit
12/12/2017 17:36, Olivier MATZ:
> On Sat, Dec 09, 2017 at 06:53:58PM +0530, Pavan Nikhilesh wrote:
> > Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
> > option for controlling datapath log level.
> > RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
> > control global and module specific log levels.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
It breaks compilation of test/ directory.
Please check git grep RTE_LOG_LEVEL
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option
2018-01-12 15:46 ` Thomas Monjalon
@ 2018-01-12 15:52 ` Pavan Nikhilesh
2018-01-12 16:08 ` Thomas Monjalon
0 siblings, 1 reply; 17+ messages in thread
From: Pavan Nikhilesh @ 2018-01-12 15:52 UTC (permalink / raw)
To: Thomas Monjalon, Olivier MATZ, ferruh.yigit; +Cc: dev
Hi Thomas,
The patchset depends on the following patchset
http://dpdk.org/dev/patchwork/patch/32038/
Thanks,
Pavan
On Fri, Jan 12, 2018 at 04:46:47PM +0100, Thomas Monjalon wrote:
> 12/12/2017 17:36, Olivier MATZ:
> > On Sat, Dec 09, 2017 at 06:53:58PM +0530, Pavan Nikhilesh wrote:
> > > Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
> > > option for controlling datapath log level.
> > > RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
> > > control global and module specific log levels.
> > >
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> >
> > Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
>
> It breaks compilation of test/ directory.
> Please check git grep RTE_LOG_LEVEL
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option
2017-12-12 16:36 ` Olivier MATZ
2018-01-12 15:46 ` Thomas Monjalon
@ 2018-01-17 13:22 ` Thomas Monjalon
1 sibling, 0 replies; 17+ messages in thread
From: Thomas Monjalon @ 2018-01-17 13:22 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: dev, Olivier MATZ, ferruh.yigit
12/12/2017 17:36, Olivier MATZ:
> On Sat, Dec 09, 2017 at 06:53:58PM +0530, Pavan Nikhilesh wrote:
> > Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
> > option for controlling datapath log level.
> > RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
> > control global and module specific log levels.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
Series applied, thanks
^ permalink raw reply [flat|nested] 17+ messages in thread