From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D08CA00E6 for ; Tue, 6 Aug 2019 13:24:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 17CE91BE55; Tue, 6 Aug 2019 13:24:45 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 076BF1BE54 for ; Tue, 6 Aug 2019 13:24:43 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id E5DAC48C; Tue, 6 Aug 2019 07:24:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 06 Aug 2019 07:24:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=qjNR2Cja3uSbk1M++cMeadmB8+w8BijYXEfJvKWxUTY=; b=VX+JvlOzy+1O ARcIu/M/zF5RItyChMDi6sHBPWB3S55bEHJbY65dwIETCvftNhkJoC7KJi/OAhjm o2E/XUz+/rUMsp2GTxoiSjMCClVw+s+jxWOam3fu1RlWpAHAtJfVkt3VUUrK8d0q iwATgZYrUh6/EiKeoSguT1kRY/V0Uz8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=qjNR2Cja3uSbk1M++cMeadmB8+w8BijYXEfJvKWxU TY=; b=Lxv4ApK3elhsbSUiHefF/00Rg2z/DleH0ztm6u7AWJzyP3PffAsvq2ENW GsMGPlAal3CNP8q7ngx4q+U1bGhW33XUSzWLZYSBsP6fPcZnnBgcQhgG59J/MHwj ysUsXHDD+/NSmdPnw5Vf9ZHBT5+mv/Dw4K1kv35Ghx4b6wlkqEWpHcw0npKujgUM Y0/ypz+9pPxuc3dL6AJHH5bnE3xBmZ3vGugeQKjH/3ZWkeAaNwvoOrncmJygorGs /1fkru/86ODNpNVYI9A5My/tN8LeY0JPvMmj3iuKGSbfvNRyGs5OdtIZ/dR8ub4F BhYyZbMDe2aoghrmlJqlrw/ITWnaA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddruddutddgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeelfedriedrudegledruddugeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 2BD31380092; Tue, 6 Aug 2019 07:24:40 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, Ferruh Yigit Date: Tue, 06 Aug 2019 13:24:38 +0200 Message-ID: <5059724.Axm0xEFYWp@xps> In-Reply-To: References: <1563890871-26901-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API returning void X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/07/2019 16:22, Ferruh Yigit: > On 7/23/2019 3:07 PM, Andrew Rybchenko wrote: > > void return value is bad for get API (like rte_eth_dev_info-get()) > > since caller does not know if the function does its job or not and > > output value is filled in. > > > > void return value is bad for state changing API (like > > rte_eth_promiscuous_enable()) since caller should use get API > > to understand if state is really changed. > > > > Signed-off-by: Andrew Rybchenko > > --- > > +* ethdev: update API functions returning ``void`` to return ``int`` with > > + negative errno values to indicate various error conditions (e.g. > > + invalid port ID, unsupported operation, failed operation): > > + > > + - ``rte_eth_dev_info_get`` > > + - ``rte_eth_promiscuous_enable`` and ``rte_eth_promiscuous_disable`` > > + - ``rte_eth_allmulticast_enable`` and ``rte_eth_allmulticast_disable`` > > + - ``rte_eth_link_get`` and ``rte_eth_link_get_nowait`` > > + - ``rte_eth_dev_stop`` > > + - ``rte_eth_dev_close`` > > + - ``rte_eth_xstats_reset`` > > + - ``rte_eth_macaddr_get`` > > + - ``rte_eth_dev_owner_delete`` > > Acked-by: Ferruh Yigit Acked-by: Thomas Monjalon