From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 858942B88
 for <dev@dpdk.org>; Fri, 23 Dec 2016 16:14:44 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP; 23 Dec 2016 07:14:42 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,393,1477983600"; d="scan'208";a="1075637172"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29])
 ([10.237.220.29])
 by orsmga001.jf.intel.com with ESMTP; 23 Dec 2016 07:14:41 -0800
To: Harish Patil <harish.patil@qlogic.com>
References: <91ac9846-530c-2dd3-4bd6-2c3b9143405b@intel.com>
 <1482454091-12819-1-git-send-email-harish.patil@qlogic.com>
Cc: dev@dpdk.org, Dept-EngDPDKDev@cavium.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <5065235d-f3c1-c07f-309d-da5536fa4d4d@intel.com>
Date: Fri, 23 Dec 2016 15:14:41 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1482454091-12819-1-git-send-email-harish.patil@qlogic.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2 1/7] net/qede: reduce noise in debug logs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Dec 2016 15:14:44 -0000

On 12/23/2016 12:48 AM, Harish Patil wrote:
> Move DP_NOTICE msg under CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO.
> 
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> ---

<...>

>  
> -#ifdef RTE_LIBRTE_QEDE_DEBUG_DRIVER
> -#define PMD_DRV_LOG_RAW(level, fmt, args...) \
> -	RTE_LOG(level, PMD, "%s(): " fmt, __func__, ## args)
> -#else
> -#define PMD_DRV_LOG_RAW(level, fmt, args...) do { } while (0)
> -#endif
> -
>  #define PMD_DRV_LOG(level, fmt, args...) \
>  	PMD_DRV_LOG_RAW(level, fmt "\n", ## args)

This is now useless since PMD_DRV_LOG_RAW no more defined, I guess  this
doesn't give a compile error because PMD_DRV_LOG is not used at all in
the driver.
I think if PMD_DRV_LOG_RAW removed, PMD_DRV_LOG also should be removed.

>  
>