From: Thomas Monjalon <thomas@monjalon.net>
To: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
Cc: "Kelly, Karen" <karen.kelly@intel.com>,
anatoly.burakov@intel.com, david.marchand@redhat.com,
dev@dpdk.org, john.mcnamara@intel.com, ferruh.yigit@amd.com,
"Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH] examples/l3fwd-power: fix to configure the uncore env
Date: Mon, 27 Nov 2023 22:19:28 +0100 [thread overview]
Message-ID: <5067151.6tgchFWduM@thomas> (raw)
In-Reply-To: <ea9379ff-c1fd-fc98-81d5-6b1a58be322f@intel.com>
27/10/2023 14:37, Hunt, David:
> On 27/10/2023 13:36, Kelly, Karen wrote:
> > On 26/10/2023 16:19, Sivaprasad Tummala wrote:
> >> Updated the l3fwd-power app to configure the uncore env before invoking
> >> any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is
> >> too late because other APIs already called.
> >>
> >> Bugzilla ID: 1304
> >> Fixes: ac1edcb6621a ("power: refactor uncore power management API")
> >> Cc:karen.kelly@intel.com
> >>
> >> Signed-off-by: Sivaprasad Tummala<sivaprasad.tummala@amd.com>
> >> ---
> >> examples/l3fwd-power/main.c | 6 ++++++
> >> lib/power/rte_power_uncore.c | 7 +++++++
> >> lib/power/rte_power_uncore.h | 9 +++++----
> >> 3 files changed, 18 insertions(+), 4 deletions(-)
> > Ran on my system, bug is resolved after applying this patch.
> >
> > Tested-by: Karen Kelly <karen.kelly@intel.com>
> >
>
> Acked-by: David Hunt <david.hunt@intel.com>
So I merge it to fix a bug in the library, despite the patch title.
I am fixing a typo, and the commit description.
Applied
next prev parent reply other threads:[~2023-11-27 21:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 15:19 Sivaprasad Tummala
2023-10-27 12:36 ` Kelly, Karen
2023-10-27 12:37 ` Hunt, David
2023-11-27 21:19 ` Thomas Monjalon [this message]
2023-11-23 1:58 ` Thomas Monjalon
2023-11-23 10:26 ` Ferruh Yigit
2023-11-27 16:54 ` Bruce Richardson
2023-11-27 21:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5067151.6tgchFWduM@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=john.mcnamara@intel.com \
--cc=karen.kelly@intel.com \
--cc=sivaprasad.tummala@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).