From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D99EA05A1; Wed, 22 Apr 2020 04:09:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2253D1C2B7; Wed, 22 Apr 2020 04:09:26 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E57C51C2B4 for ; Wed, 22 Apr 2020 04:09:24 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 972DC5C0127; Tue, 21 Apr 2020 22:09:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 21 Apr 2020 22:09:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= ajEAxHPqfQkTUPkJHq5U7Fr1xAiJf9allHFGP/Au5tI=; b=gAvedqIoKjPMvLtb pxyQt4K8+pI3Gq8gcyZv+xhIRSwYeeYhc6E9ixswohg8A8s2dnWraBErdUgh6zUn aMi4rHva4HeHVRhJbYtsTM2rwBZBcBrzRlfFs/Pp2NZ1PY7InQPsIccPBRI0Rl13 Crm4iaDmkHRWwXoQ7HS4f63zdAEteokgLBXZf/dCEkkOItVtvjZ101Ci1lJ4Hybf 7ZmZQAAZed5PdWTAJ2Oq1tDC683xtj/Xwcynkb32Ip0WugQCd4e6jer/62YYqPen kOWyM1V5EplNZRQXUmLutYhE3DxS2Ucqvh4Bz5NTUhoT/1ykqKK+GWG48SvDQuVH vRx2DQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ajEAxHPqfQkTUPkJHq5U7Fr1xAiJf9allHFGP/Au5 tI=; b=hewtpCzalzCjfbYlIulK/IIciSAAIV3S6UH+alBMeCPutVMepwUMMltAt +LaZxJCxxkjuAJqgnsLYfJurc6ft1VUOz0ZNXXS/blwuUdyTHo63hvWcMYzplDbo KVYTGMk9MOdOFLp5biN7Dsh/rqqwjbxnTxJx5zY+Qoi+MGVreYaBfOU+WWE725y0 PwF+TPRvgeKylwZJZBjjyXTCn5pgQcx1NHdxOZPbmVNqmmXqscHCpogpQOimqlKa 7hzhKZaEtvu7QISunTIvJfu1wRC6eR+1auU8sI/oAi9owoFD2mUgN1EhiIZIW/au 7eSBWbBOu3zXG6uX9Pyr7viE2ynGg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeeigdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B885D3065CB4; Tue, 21 Apr 2020 22:09:20 -0400 (EDT) From: Thomas Monjalon To: Bing Zhao Cc: john.mcnamara@intel.com, marko.kovacevic@intel.com, viacheslavo@mellanox.com, orika@mellanox.com, matan@mellanox.com, shahafs@mellanox.com, rasland@mellanox.com, dev@dpdk.org Date: Wed, 22 Apr 2020 04:09:19 +0200 Message-ID: <5073065.29KlJPOoH8@thomas> In-Reply-To: <1587449290-124383-1-git-send-email-bingz@mellanox.com> References: <1586789756-227464-1-git-send-email-bingz@mellanox.com> <1587449290-124383-1-git-send-email-bingz@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] doc: update flow non-cached mode notes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Please prefer splitting lines after punctuation signs. 21/04/2020 08:08, Bing Zhao: > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > > +Notes for rte_flow A blank line is missing below: > +------------------ > +Implementation of flows organization is in non-cached mode. When stopping a This can be simpler in direct form: Flows are not cached in the driver. > +device, all the flows inserted from application will be considered invalid and device -> device port > +flushed automatically in the background. After restarting of the device, no restarting of the device -> restarting the device > +application's flow exists in the system. All reference pointers to these flows Why "application's flow"? What about "no flow is represented in the system"? reference pointers -> references > +held by the application are not valid anymore and should be discarded by the > +application. Invalid and discard explanations are repeated below. > + > +The application should recreate the flows as required after device restarting, device restarting -> port restart Better to stop the sentence here, and move it at the end of the paragraph after "stop". > +and must not try to destroy or flush the invalid flows after stopping (except After stopping, flows become invalid. They should be discarded but neither destroyed nor flushed. > +discarding them). > + > Notes for testpmd > ----------------- > > diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst > index bacd4c6..367c5df 100644 > --- a/doc/guides/rel_notes/release_20_05.rst > +++ b/doc/guides/rel_notes/release_20_05.rst > @@ -63,6 +63,8 @@ New Features > * Added support for matching on IPv4 Time To Live and IPv6 Hop Limit. > * Added support for creating Relaxed Ordering Memory Regions. > * Added support for jumbo frame size (9K MTU) in Multi-Packet RQ mode. > + * Flow rules caching removed from the driver for memory saving and > + correctness according to RTE flow and RTE ethdev. Removed flow rules caching for memory saving and compliance with ethdev API.